From: Peter Maydell <peter.maydell@linaro.org>
To: Alex Barcelo <abarcelo@ac.upc.edu>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] signal: Preparing safe sigprocmask wrapper on qemu-user
Date: Wed, 10 Oct 2012 16:37:41 +0100 [thread overview]
Message-ID: <CAFEAcA-dwm4-vkgE8pBHZTfe0eGL=ua2WP_P0u-nsZ86sjxieQ@mail.gmail.com> (raw)
In-Reply-To: <CAFKAgTdwrfyEw2q2QvevYZakYcBmOvtV66dvosoC3eErHhSKKw@mail.gmail.com>
On 8 October 2012 19:42, Alex Barcelo <abarcelo@ac.upc.edu> wrote:
> okay, now I see that this lacks a lot of "presentation".
> Before sending a v2, is there something more that I should correct?
Well, yes, your cover letter could be a little more verbose, but I
think mostly it's just that nobody's got round to reviewing the
patches yet. I'll have a look at them in a moment.
One thing that is definitely missing and is critical is that
you need to include a Signed-off-by: line in your patches'
commit messages: we cannot commit them without one.
(http://wiki.qemu.org/Contribute/SubmitAPatch mentions this and
has some other hints, if you haven't read it.)
> And one netiquete question, test-breaking code should be in the
> description (cover, 00/00)? On a next post in the same thread? Another
> thread?
In the cover letter is fine.
-- PMM
next prev parent reply other threads:[~2012-10-10 15:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 16:11 [Qemu-devel] [PATCH 0/2] signal: Preparing safe sigprocmask wrapper on qemu-user Alex Barcelo
2012-09-29 16:11 ` [Qemu-devel] [PATCH 1/2] signal: added a wrapper for sigprocmask function Alex Barcelo
2012-10-10 15:48 ` Peter Maydell
2012-09-29 16:11 ` [Qemu-devel] [PATCH 2/2] signal: sigsegv protection on do_sigprocmask Alex Barcelo
2012-10-10 15:54 ` Peter Maydell
2012-10-08 18:42 ` [Qemu-devel] [PATCH 0/2] signal: Preparing safe sigprocmask wrapper on qemu-user Alex Barcelo
2012-10-10 15:37 ` Peter Maydell [this message]
2012-10-17 14:22 ` Alex Barcelo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-dwm4-vkgE8pBHZTfe0eGL=ua2WP_P0u-nsZ86sjxieQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=abarcelo@ac.upc.edu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.