* [trivial PATCH 1/1] hw/intc: Improve formatting of MEMTX_ERROR guest error message
@ 2021-07-06 21:14 Rebecca Cran
2021-07-06 21:36 ` Philippe Mathieu-Daudé
2021-07-08 9:54 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Rebecca Cran @ 2021-07-06 21:14 UTC (permalink / raw)
To: Michael Tokarev, Laurent Vivier, qemu-trivial, Peter Maydell, qemu-arm
Cc: Rebecca Cran, qemu-devel
Add a space in the message printed when gicr_read*/gicr_write* returns
MEMTX_ERROR in arm_gicv3_redist.c.
Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
hw/intc/arm_gicv3_redist.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/intc/arm_gicv3_redist.c b/hw/intc/arm_gicv3_redist.c
index 8645220d6183..53da703ed843 100644
--- a/hw/intc/arm_gicv3_redist.c
+++ b/hw/intc/arm_gicv3_redist.c
@@ -453,7 +453,7 @@ MemTxResult gicv3_redist_read(void *opaque, hwaddr offset, uint64_t *data,
if (r == MEMTX_ERROR) {
qemu_log_mask(LOG_GUEST_ERROR,
"%s: invalid guest read at offset " TARGET_FMT_plx
- "size %u\n", __func__, offset, size);
+ " size %u\n", __func__, offset, size);
trace_gicv3_redist_badread(gicv3_redist_affid(cs), offset,
size, attrs.secure);
/* The spec requires that reserved registers are RAZ/WI;
@@ -510,7 +510,7 @@ MemTxResult gicv3_redist_write(void *opaque, hwaddr offset, uint64_t data,
if (r == MEMTX_ERROR) {
qemu_log_mask(LOG_GUEST_ERROR,
"%s: invalid guest write at offset " TARGET_FMT_plx
- "size %u\n", __func__, offset, size);
+ " size %u\n", __func__, offset, size);
trace_gicv3_redist_badwrite(gicv3_redist_affid(cs), offset, data,
size, attrs.secure);
/* The spec requires that reserved registers are RAZ/WI;
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [trivial PATCH 1/1] hw/intc: Improve formatting of MEMTX_ERROR guest error message
2021-07-06 21:14 [trivial PATCH 1/1] hw/intc: Improve formatting of MEMTX_ERROR guest error message Rebecca Cran
@ 2021-07-06 21:36 ` Philippe Mathieu-Daudé
2021-07-08 9:54 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-07-06 21:36 UTC (permalink / raw)
To: Rebecca Cran, Michael Tokarev, Laurent Vivier, qemu-trivial,
Peter Maydell, qemu-arm
Cc: qemu-devel
On 7/6/21 11:14 PM, Rebecca Cran wrote:
> Add a space in the message printed when gicr_read*/gicr_write* returns
> MEMTX_ERROR in arm_gicv3_redist.c.
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
> hw/intc/arm_gicv3_redist.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [trivial PATCH 1/1] hw/intc: Improve formatting of MEMTX_ERROR guest error message
2021-07-06 21:14 [trivial PATCH 1/1] hw/intc: Improve formatting of MEMTX_ERROR guest error message Rebecca Cran
2021-07-06 21:36 ` Philippe Mathieu-Daudé
@ 2021-07-08 9:54 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2021-07-08 9:54 UTC (permalink / raw)
To: Rebecca Cran
Cc: QEMU Trivial, qemu-arm, Michael Tokarev, Laurent Vivier, QEMU Developers
On Tue, 6 Jul 2021 at 22:14, Rebecca Cran <rebecca@nuviainc.com> wrote:
>
> Add a space in the message printed when gicr_read*/gicr_write* returns
> MEMTX_ERROR in arm_gicv3_redist.c.
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
> hw/intc/arm_gicv3_redist.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-08 9:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06 21:14 [trivial PATCH 1/1] hw/intc: Improve formatting of MEMTX_ERROR guest error message Rebecca Cran
2021-07-06 21:36 ` Philippe Mathieu-Daudé
2021-07-08 9:54 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.