* [Qemu-devel] [PATCH v4 0/4] Implement some QKeyCode support
@ 2016-03-11 2:24 Programmingkid
2016-03-11 17:14 ` Eric Blake
0 siblings, 1 reply; 4+ messages in thread
From: Programmingkid @ 2016-03-11 2:24 UTC (permalink / raw)
To: Peter Maydell, Gerd Hoffmann, Eric Blake; +Cc: qemu-devel qemu-devel
This patchset adds QKeyCode support the adb and cocoa code.
Note: you do not need to be on a Mac to test out the adb.c, qapi-schema.json,
and adb-keys.h files. Only the cocoa.m file changes are Mac specific.
If you are using Linux as a guest, then the xev command is what you could use to
test out these patches. For a Mac OS guest the Key Caps application would help
with testing out these patches.
John Arbuckle (4):
cocoa.m
qapi-schema.json
adb-keys.h
adb.c
hw/input/adb.c | 223 ++++++++++++++++++++++++-------
include/hw/input/adb-keys.h | 146 ++++++++++++++++++++
qapi-schema.json | 3 +-
ui/cocoa.m | 317 ++++++++++++++++++++------------------------
4 files changed, 466 insertions(+), 223 deletions(-)
create mode 100644 include/hw/input/adb-keys.h
--
2.7.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v4 0/4] Implement some QKeyCode support
2016-03-11 2:24 [Qemu-devel] [PATCH v4 0/4] Implement some QKeyCode support Programmingkid
@ 2016-03-11 17:14 ` Eric Blake
2016-03-11 17:19 ` Programmingkid
0 siblings, 1 reply; 4+ messages in thread
From: Eric Blake @ 2016-03-11 17:14 UTC (permalink / raw)
To: Programmingkid, Peter Maydell, Gerd Hoffmann; +Cc: qemu-devel qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]
On 03/10/2016 07:24 PM, Programmingkid wrote:
> This patchset adds QKeyCode support the adb and cocoa code.
>
> Note: you do not need to be on a Mac to test out the adb.c, qapi-schema.json,
> and adb-keys.h files. Only the cocoa.m file changes are Mac specific.
>
> If you are using Linux as a guest, then the xev command is what you could use to
> test out these patches. For a Mac OS guest the Key Caps application would help
> with testing out these patches.
>
> John Arbuckle (4):
> cocoa.m
> qapi-schema.json
> adb-keys.h
> adb.c
This isn't the typical git cover letter - git lists the titles of the
four patches, not the basenames of the files modified by the patches.
Also, you still didn't manage to get threading quite right; the series
ended up as 5 top-level threads, which makes it harder to find things in
mailers that sort by threads with most recent activity.
>
> hw/input/adb.c | 223 ++++++++++++++++++++++++-------
> include/hw/input/adb-keys.h | 146 ++++++++++++++++++++
> qapi-schema.json | 3 +-
> ui/cocoa.m | 317 ++++++++++++++++++++------------------------
> 4 files changed, 466 insertions(+), 223 deletions(-)
> create mode 100644 include/hw/input/adb-keys.h
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v4 0/4] Implement some QKeyCode support
2016-03-11 17:14 ` Eric Blake
@ 2016-03-11 17:19 ` Programmingkid
2016-03-12 0:25 ` Peter Maydell
0 siblings, 1 reply; 4+ messages in thread
From: Programmingkid @ 2016-03-11 17:19 UTC (permalink / raw)
To: Eric Blake; +Cc: Peter Maydell, Gerd Hoffmann, qemu-devel qemu-devel
On Mar 11, 2016, at 12:14 PM, Eric Blake wrote:
> On 03/10/2016 07:24 PM, Programmingkid wrote:
>> This patchset adds QKeyCode support the adb and cocoa code.
>>
>> Note: you do not need to be on a Mac to test out the adb.c, qapi-schema.json,
>> and adb-keys.h files. Only the cocoa.m file changes are Mac specific.
>>
>> If you are using Linux as a guest, then the xev command is what you could use to
>> test out these patches. For a Mac OS guest the Key Caps application would help
>> with testing out these patches.
>>
>> John Arbuckle (4):
>> cocoa.m
>> qapi-schema.json
>> adb-keys.h
>> adb.c
>
> This isn't the typical git cover letter - git lists the titles of the
> four patches, not the basenames of the files modified by the patches.
> Also, you still didn't manage to get threading quite right; the series
> ended up as 5 top-level threads, which makes it harder to find things in
> mailers that sort by threads with most recent activity.
My git send-email is broken. I spend hours googling fixes that didn't work. The 5 top-level issue is because I sent the patches using my emailer. I will remember next time to add the titles to the cover letter.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v4 0/4] Implement some QKeyCode support
2016-03-11 17:19 ` Programmingkid
@ 2016-03-12 0:25 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2016-03-12 0:25 UTC (permalink / raw)
To: Programmingkid; +Cc: Gerd Hoffmann, qemu-devel qemu-devel
On 12 March 2016 at 00:19, Programmingkid <programmingkidx@gmail.com> wrote:
> My git send-email is broken. I spend hours googling fixes that
> didn't work.
Unfortunately this makes it awkward for me to actually test
your patches, because the tooling for handling patch mails assumes
they're formatted correctly:
$ patches apply id:0CA9C4F8-7294-4A90-BC5C-328F7C73AE96@gmail.com
Cannot apply series: series is either incomplete or improperly threaded.
> I will remember next time to add the titles to the cover letter.
You can just use the git format-patch --cover-letter option, which
will automatically generate a cover mail template with the format
people expect (which you can then edit to add the description/series
title/etc).
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-12 0:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-11 2:24 [Qemu-devel] [PATCH v4 0/4] Implement some QKeyCode support Programmingkid
2016-03-11 17:14 ` Eric Blake
2016-03-11 17:19 ` Programmingkid
2016-03-12 0:25 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.