All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: "Andrew Jeffery" <andrew@aj.id.au>,
	qemu-arm <qemu-arm@nongnu.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Joel Stanley" <joel@jms.id.au>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board
Date: Tue, 10 Oct 2017 14:32:32 +0100	[thread overview]
Message-ID: <CAFEAcA-oJrvJqpdw_7ybBH3oy0ykaVd7SsM_Xx+d9yY9ZXmDkA@mail.gmail.com> (raw)
In-Reply-To: <48144f71-c876-0e89-f01e-cbfe87687aee@kaod.org>

On 10 October 2017 at 14:30, Cédric Le Goater <clg@kaod.org> wrote:
> On 10/09/2017 02:04 AM, Andrew Jeffery wrote:
>> On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote:
>>> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)
>>> +{
>>> +    AspeedSoCState *soc = &bmc->soc;
>>> +
>>> +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 4), "tmp423", 0x4c);
>>> +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 5), "tmp423", 0x4c);
>>> +
>>> +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 9), "tmp105", 0x4a);
>>
>> Looks like I need to track down newer versions of the schematics I have.
>
> the device on the board is a tmp275 but the tmp105 model is compatible.

This kind of deviation from the real hardware is worth having
a comment to document, I think.

thanks
-- PMM

  reply	other threads:[~2017-10-10 13:32 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20  7:01 [Qemu-devel] [PATCH v2 0/6] aspeed: add a witherspoon-bmc machine Cédric Le Goater
2017-09-20  7:01 ` [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board Cédric Le Goater
2017-10-06 15:10   ` Peter Maydell
2017-10-07 16:42     ` Cédric Le Goater
2017-10-10  9:19     ` Cédric Le Goater
2017-10-10  9:54       ` Peter Maydell
2017-10-10 13:21         ` Cédric Le Goater
2017-10-10 13:24           ` Peter Maydell
2017-10-10 15:38             ` Cédric Le Goater
2017-10-10 15:45               ` Peter Maydell
2017-10-10 15:54                 ` Cédric Le Goater
2017-10-09  0:04   ` Andrew Jeffery
2017-10-10 13:30     ` Cédric Le Goater
2017-10-10 13:32       ` Peter Maydell [this message]
2017-10-11  3:49       ` Andrew Jeffery
2017-10-11  7:28         ` Cédric Le Goater
2017-10-16  1:55           ` Andrew Jeffery
2017-09-20  7:01 ` [Qemu-devel] [PATCH v2 2/6] aspeed: add an I2C RTC device to all machines Cédric Le Goater
2017-10-09  0:28   ` Andrew Jeffery
2017-09-20  7:01 ` [Qemu-devel] [PATCH v2 3/6] smbus: add a smbus_eeprom_init_one() routine Cédric Le Goater
2017-10-08 21:35   ` Philippe Mathieu-Daudé
2017-09-20  7:01 ` [Qemu-devel] [PATCH v2 4/6] aspeed: Add EEPROM I2C devices Cédric Le Goater
2017-10-09  0:45   ` Andrew Jeffery
2017-09-20  7:01 ` [Qemu-devel] [PATCH v2 5/6] misc: add pca9552 LED blinker model Cédric Le Goater
2017-10-06 15:12   ` Peter Maydell
2017-10-07 16:41     ` Cédric Le Goater
2017-09-20  7:01 ` [Qemu-devel] [PATCH v2 6/6] aspeed: add the pc9552 chips to the witherspoon machine Cédric Le Goater
2017-10-09  0:47   ` Andrew Jeffery
2017-10-06 15:13 ` [Qemu-devel] [PATCH v2 0/6] aspeed: add a witherspoon-bmc machine Peter Maydell
2017-10-07 16:44   ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA-oJrvJqpdw_7ybBH3oy0ykaVd7SsM_Xx+d9yY9ZXmDkA@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=andrew@aj.id.au \
    --cc=clg@kaod.org \
    --cc=f4bug@amsat.org \
    --cc=joel@jms.id.au \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.