All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: qemu-arm <qemu-arm@nongnu.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"Joel Stanley" <joel@jms.id.au>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH v2 0/6] aspeed: add a witherspoon-bmc machine
Date: Fri, 6 Oct 2017 16:13:59 +0100	[thread overview]
Message-ID: <CAFEAcA9Avqgbm7sZTKuex9dOp-1wzw0Moa8XVvXw5GZjSeC5Xw@mail.gmail.com> (raw)
In-Reply-To: <20170920070135.31379-1-clg@kaod.org>

On 20 September 2017 at 08:01, Cédric Le Goater <clg@kaod.org> wrote:
> Hello,
>
> This series adds a new Aspeed machine to emulate the BMC of a
> Witherspoon system. It also extends the other Aspeed machines with I2C
> devices and adds a simple model for the pca9552 LED blinker present on
> the witherspoon board.
>
> Thanks,
>
> C.
>
> Changes since v1:
>
>  - introduced smbus_eeprom_init_one()
>
> Cédric Le Goater (6):
>   aspeed: add support for the witherspoon-bmc board
>   aspeed: add an I2C RTC device to all machines
>   smbus: add a smbus_eeprom_init_one() routine
>   aspeed: Add EEPROM I2C devices
>   misc: add pca9552 LED blinker model
>   aspeed: add the pc9552 chips to the witherspoon machine

Hi -- I've made a couple of review comments and nothing else
leapt out as obviously wrong, but I'm hoping that somebody more
familiar with the aspeed devices will do review...

thanks
-- PMM

  parent reply	other threads:[~2017-10-06 15:14 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20  7:01 [Qemu-devel] [PATCH v2 0/6] aspeed: add a witherspoon-bmc machine Cédric Le Goater
2017-09-20  7:01 ` [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board Cédric Le Goater
2017-10-06 15:10   ` Peter Maydell
2017-10-07 16:42     ` Cédric Le Goater
2017-10-10  9:19     ` Cédric Le Goater
2017-10-10  9:54       ` Peter Maydell
2017-10-10 13:21         ` Cédric Le Goater
2017-10-10 13:24           ` Peter Maydell
2017-10-10 15:38             ` Cédric Le Goater
2017-10-10 15:45               ` Peter Maydell
2017-10-10 15:54                 ` Cédric Le Goater
2017-10-09  0:04   ` Andrew Jeffery
2017-10-10 13:30     ` Cédric Le Goater
2017-10-10 13:32       ` Peter Maydell
2017-10-11  3:49       ` Andrew Jeffery
2017-10-11  7:28         ` Cédric Le Goater
2017-10-16  1:55           ` Andrew Jeffery
2017-09-20  7:01 ` [Qemu-devel] [PATCH v2 2/6] aspeed: add an I2C RTC device to all machines Cédric Le Goater
2017-10-09  0:28   ` Andrew Jeffery
2017-09-20  7:01 ` [Qemu-devel] [PATCH v2 3/6] smbus: add a smbus_eeprom_init_one() routine Cédric Le Goater
2017-10-08 21:35   ` Philippe Mathieu-Daudé
2017-09-20  7:01 ` [Qemu-devel] [PATCH v2 4/6] aspeed: Add EEPROM I2C devices Cédric Le Goater
2017-10-09  0:45   ` Andrew Jeffery
2017-09-20  7:01 ` [Qemu-devel] [PATCH v2 5/6] misc: add pca9552 LED blinker model Cédric Le Goater
2017-10-06 15:12   ` Peter Maydell
2017-10-07 16:41     ` Cédric Le Goater
2017-09-20  7:01 ` [Qemu-devel] [PATCH v2 6/6] aspeed: add the pc9552 chips to the witherspoon machine Cédric Le Goater
2017-10-09  0:47   ` Andrew Jeffery
2017-10-06 15:13 ` Peter Maydell [this message]
2017-10-07 16:44   ` [Qemu-devel] [PATCH v2 0/6] aspeed: add a witherspoon-bmc machine Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA9Avqgbm7sZTKuex9dOp-1wzw0Moa8XVvXw5GZjSeC5Xw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=andrew@aj.id.au \
    --cc=clg@kaod.org \
    --cc=f4bug@amsat.org \
    --cc=joel@jms.id.au \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.