All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	Laurent Desnogues <laurent.desnogues@gmail.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Mulyadi Santosa <mulyadi.santosa@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] tcg: Remove stack protection from helper functions
Date: Mon, 26 Sep 2011 12:33:38 +0100	[thread overview]
Message-ID: <CAFEAcA8Ts6srsJawQHDLddSDSr=BT3Dyb2TCiXg7reL2amEWhw@mail.gmail.com> (raw)
In-Reply-To: <4E805923.50806@siemens.com>

On 26 September 2011 11:51, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> This increases the overhead of frequently executed helpers. We need to
> move rule past QEMU_CFLAGS assignment to ensure that the required simple
> assignment picks up all bits. The signal workaround is moved just for
> the sake of consistency.

> +# NOTE: Must be after the last QEMU_CFLAGS assignment
> +op_helper.o user-exec.o: QEMU_CFLAGS := $(subst -fstack-protector-all,,$(QEMU_CFLAGS)) $(HELPER_CFLAGS)

Why also user-exec.o ? Why not the other source files with helpers in?
This doesn't seem very consistent. Maybe the right answer is to have
some of the offending helper functions inline instead? (Or to not
have -fstack-protector-all globally?)

-- PMM

  reply	other threads:[~2011-09-26 11:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-26  7:46 [Qemu-devel] [PATCH] tcg: Remove stack protection from helper functions Jan Kiszka
2011-09-26  8:01 ` Mulyadi Santosa
2011-09-26  8:15   ` Laurent Desnogues
2011-09-26 17:41     ` Avi Kivity
2011-09-26 19:43       ` Richard Henderson
2011-09-26 19:52         ` Avi Kivity
2011-09-26 19:53           ` Richard Henderson
2011-09-26 20:20             ` Avi Kivity
2011-09-26 20:19           ` Peter Maydell
2011-09-26 20:26             ` Avi Kivity
2011-09-27  4:29             ` Andi Kleen
2011-09-27  7:58               ` Peter Maydell
2011-09-26 10:51 ` [Qemu-devel] [PATCH v2] " Jan Kiszka
2011-09-26 11:33   ` Peter Maydell [this message]
2011-09-26 11:43     ` Jan Kiszka
2011-09-26 11:56       ` Peter Maydell
2011-09-26 17:22         ` Blue Swirl
2011-09-26 17:33           ` Jan Kiszka
2011-09-26 18:20             ` Blue Swirl
2011-09-26 18:25               ` Jan Kiszka
2011-09-26 18:40                 ` Blue Swirl
2011-09-26 19:08               ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8Ts6srsJawQHDLddSDSr=BT3Dyb2TCiXg7reL2amEWhw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=aliguori@us.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=laurent.desnogues@gmail.com \
    --cc=mulyadi.santosa@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.