* [PULL 0/1] Monitor patches for 2020-07-21
@ 2020-07-21 15:25 Markus Armbruster
2020-07-21 15:25 ` [PULL 1/1] qdev: Fix device_add DRIVER,help to print to monitor Markus Armbruster
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Markus Armbruster @ 2020-07-21 15:25 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
The following changes since commit af3d69058e09bede9900f266a618ed11f76f49f3:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200720' into staging (2020-07-20 15:58:07 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2020-07-21
for you to fetch changes up to 029afc4e76041e1a320530d97f99122a1b3d5da2:
qdev: Fix device_add DRIVER,help to print to monitor (2020-07-21 17:22:44 +0200)
----------------------------------------------------------------
Monitor patches for 2020-07-21
----------------------------------------------------------------
Markus Armbruster (1):
qdev: Fix device_add DRIVER,help to print to monitor
qdev-monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PULL 1/1] qdev: Fix device_add DRIVER,help to print to monitor
2020-07-21 15:25 [PULL 0/1] Monitor patches for 2020-07-21 Markus Armbruster
@ 2020-07-21 15:25 ` Markus Armbruster
2020-07-21 19:31 ` [PULL 0/1] Monitor patches for 2020-07-21 Peter Maydell
2020-07-22 11:36 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2020-07-21 15:25 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, Li Qiang, qemu-stable, Dr . David Alan Gilbert,
Marc-André Lureau, Philippe Mathieu-Daudé
Help on device properties gets printed to stdout instead of the
monitor. If you have the monitor anywhere else, no help for you.
Broken when commit e1043d674d "qdev: use object_property_help()"
accidentally switched from qemu_printf() to printf(). Switch right
back.
Fixes: e1043d674d792ff64aebae1a3eafc08b38a8a085
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200714160202.3121879-2-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
qdev-monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qdev-monitor.c b/qdev-monitor.c
index 71ebce19df..e9b7228480 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -300,7 +300,7 @@ int qdev_device_help(QemuOpts *opts)
}
g_ptr_array_sort(array, (GCompareFunc)qemu_pstrcmp0);
for (i = 0; i < array->len; i++) {
- printf("%s\n", (char *)array->pdata[i]);
+ qemu_printf("%s\n", (char *)array->pdata[i]);
}
g_ptr_array_set_free_func(array, g_free);
g_ptr_array_free(array, true);
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PULL 0/1] Monitor patches for 2020-07-21
2020-07-21 15:25 [PULL 0/1] Monitor patches for 2020-07-21 Markus Armbruster
2020-07-21 15:25 ` [PULL 1/1] qdev: Fix device_add DRIVER,help to print to monitor Markus Armbruster
@ 2020-07-21 19:31 ` Peter Maydell
2020-07-22 11:36 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2020-07-21 19:31 UTC (permalink / raw)
To: Markus Armbruster; +Cc: QEMU Developers
On Tue, 21 Jul 2020 at 16:25, Markus Armbruster <armbru@redhat.com> wrote:
>
> The following changes since commit af3d69058e09bede9900f266a618ed11f76f49f3:
>
> Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200720' into staging (2020-07-20 15:58:07 +0100)
>
> are available in the Git repository at:
>
> git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2020-07-21
>
> for you to fetch changes up to 029afc4e76041e1a320530d97f99122a1b3d5da2:
>
> qdev: Fix device_add DRIVER,help to print to monitor (2020-07-21 17:22:44 +0200)
>
> ----------------------------------------------------------------
> Monitor patches for 2020-07-21
>
> ----------------------------------------------------------------
> Markus Armbruster (1):
> qdev: Fix device_add DRIVER,help to print to monitor
>
> qdev-monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This missed rc1, I'm afraid; will go in for rc2.
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PULL 0/1] Monitor patches for 2020-07-21
2020-07-21 15:25 [PULL 0/1] Monitor patches for 2020-07-21 Markus Armbruster
2020-07-21 15:25 ` [PULL 1/1] qdev: Fix device_add DRIVER,help to print to monitor Markus Armbruster
2020-07-21 19:31 ` [PULL 0/1] Monitor patches for 2020-07-21 Peter Maydell
@ 2020-07-22 11:36 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2020-07-22 11:36 UTC (permalink / raw)
To: Markus Armbruster; +Cc: QEMU Developers
On Tue, 21 Jul 2020 at 16:25, Markus Armbruster <armbru@redhat.com> wrote:
>
> The following changes since commit af3d69058e09bede9900f266a618ed11f76f49f3:
>
> Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200720' into staging (2020-07-20 15:58:07 +0100)
>
> are available in the Git repository at:
>
> git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2020-07-21
>
> for you to fetch changes up to 029afc4e76041e1a320530d97f99122a1b3d5da2:
>
> qdev: Fix device_add DRIVER,help to print to monitor (2020-07-21 17:22:44 +0200)
>
> ----------------------------------------------------------------
> Monitor patches for 2020-07-21
>
> ----------------------------------------------------------------
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-22 11:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 15:25 [PULL 0/1] Monitor patches for 2020-07-21 Markus Armbruster
2020-07-21 15:25 ` [PULL 1/1] qdev: Fix device_add DRIVER,help to print to monitor Markus Armbruster
2020-07-21 19:31 ` [PULL 0/1] Monitor patches for 2020-07-21 Peter Maydell
2020-07-22 11:36 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.