* [Qemu-devel] make test fails on Mac OS X @ 2015-04-10 17:56 Programmingkid 2015-04-10 21:37 ` Peter Maydell 2015-04-11 15:46 ` Andreas Färber 0 siblings, 2 replies; 6+ messages in thread From: Programmingkid @ 2015-04-10 17:56 UTC (permalink / raw) To: Peter Maydell; +Cc: qemu-devel qemu-devel The 'make test' command fails to build on Mac OS X. This is because of a missing header file. Here is the error: include/glib-compat.h:19:18: fatal error: glib.h: No such file or directory #include <glib.h> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] make test fails on Mac OS X 2015-04-10 17:56 [Qemu-devel] make test fails on Mac OS X Programmingkid @ 2015-04-10 21:37 ` Peter Maydell 2015-04-11 15:46 ` Andreas Färber 1 sibling, 0 replies; 6+ messages in thread From: Peter Maydell @ 2015-04-10 21:37 UTC (permalink / raw) To: Programmingkid; +Cc: qemu-devel qemu-devel On 10 April 2015 at 18:56, Programmingkid <programmingkidx@gmail.com> wrote: > The 'make test' command fails to build on Mac OS X. This is because of a missing header file. Here is the error: > > include/glib-compat.h:19:18: fatal error: glib.h: No such file or directory > #include <glib.h> "make test" builds a bunch of unmaintained TCG tests. Our actual working test suite is "make check". -- PMM ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] make test fails on Mac OS X 2015-04-10 17:56 [Qemu-devel] make test fails on Mac OS X Programmingkid 2015-04-10 21:37 ` Peter Maydell @ 2015-04-11 15:46 ` Andreas Färber 2015-04-11 15:52 ` Peter Maydell 1 sibling, 1 reply; 6+ messages in thread From: Andreas Färber @ 2015-04-11 15:46 UTC (permalink / raw) To: Programmingkid, Peter Maydell; +Cc: qemu-devel qemu-devel Am 10.04.2015 um 19:56 schrieb Programmingkid: > The 'make test' command fails to build on Mac OS X. This is because of a missing header file. Here is the error: > > include/glib-compat.h:19:18: fatal error: glib.h: No such file or directory > #include <glib.h> On Linux, this gets me past that point, but not yet much further: diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile index 89e3342..64f661a 100644 --- a/tests/tcg/Makefile +++ b/tests/tcg/Makefile @@ -10,6 +10,7 @@ CC_X86_64=$(CC_I386) -m64 QEMU_INCLUDES += -I../.. CFLAGS=-Wall -O2 -g -fno-strict-aliasing #CFLAGS+=-msse2 +QEMU_CFLAGS += $(GLIB_CFLAGS) LDFLAGS= # TODO: automatically detect ARM and MIPS compilers, and run those too On Mac OS X, executing qemu-i386 (as opposed to qemu-system-i386) won't work though, as darwin-user is no longer available. Also, the Makefile seems to assume that it's running on x86. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] make test fails on Mac OS X 2015-04-11 15:46 ` Andreas Färber @ 2015-04-11 15:52 ` Peter Maydell 2015-04-11 20:25 ` Andreas Färber 0 siblings, 1 reply; 6+ messages in thread From: Peter Maydell @ 2015-04-11 15:52 UTC (permalink / raw) To: Andreas Färber; +Cc: Programmingkid, qemu-devel qemu-devel On 11 April 2015 at 16:46, Andreas Färber <afaerber@suse.de> wrote: > On Mac OS X, executing qemu-i386 (as opposed to qemu-system-i386) won't > work though, as darwin-user is no longer available. > > Also, the Makefile seems to assume that it's running on x86. Yes, it has all sorts of problems. We should probably salvage any of the tests that are actually useful and move them into 'make check', and get rid of 'make test' as a target entirely. -- PMM ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] make test fails on Mac OS X 2015-04-11 15:52 ` Peter Maydell @ 2015-04-11 20:25 ` Andreas Färber 2015-04-11 21:31 ` Peter Maydell 0 siblings, 1 reply; 6+ messages in thread From: Andreas Färber @ 2015-04-11 20:25 UTC (permalink / raw) To: Peter Maydell; +Cc: Programmingkid, qemu-devel qemu-devel Am 11.04.2015 um 17:52 schrieb Peter Maydell: > On 11 April 2015 at 16:46, Andreas Färber <afaerber@suse.de> wrote: >> On Mac OS X, executing qemu-i386 (as opposed to qemu-system-i386) won't >> work though, as darwin-user is no longer available. >> >> Also, the Makefile seems to assume that it's running on x86. > > Yes, it has all sorts of problems. We should probably > salvage any of the tests that are actually useful and > move them into 'make check', and get rid of 'make test' > as a target entirely. For now I just sent out a series fixing the fallout. Similar in spirit to some of those tests, I had been thinking about testing linux-user by running host binaries, comparing native and emulated output. make check only covers the softmmus today. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] make test fails on Mac OS X 2015-04-11 20:25 ` Andreas Färber @ 2015-04-11 21:31 ` Peter Maydell 0 siblings, 0 replies; 6+ messages in thread From: Peter Maydell @ 2015-04-11 21:31 UTC (permalink / raw) To: Andreas Färber; +Cc: Programmingkid, Riku Voipio, qemu-devel qemu-devel On 11 April 2015 at 21:25, Andreas Färber <afaerber@suse.de> wrote: > Similar in spirit to some of those tests, I had been thinking about > testing linux-user by running host binaries, comparing native and > emulated output. make check only covers the softmmus today. Yeah. I run the linux-user-test binaries from http://wiki.qemu.org/Testing as a smoke-test that we haven't totally broken things. I think Riku has a more comprehensive set of tests. There's also the LTP linux-test-project tests, though those are pretty heavyweight. The thing I usually end up getting stuck on with linux-user tests is how you make this (a) runnable by anybody (b) reproducible (c) gpl-compliant where relevant (d) easy for anybody to update the tests. The first and arguably the second of those requires "doesn't need a target toolchain when running 'make check'", but the second two argue for "don't check binary blobs into git"... -- PMM ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-04-11 21:42 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-04-10 17:56 [Qemu-devel] make test fails on Mac OS X Programmingkid 2015-04-10 21:37 ` Peter Maydell 2015-04-11 15:46 ` Andreas Färber 2015-04-11 15:52 ` Peter Maydell 2015-04-11 20:25 ` Andreas Färber 2015-04-11 21:31 ` Peter Maydell
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.