* [PATCH] checkpatch: reversed logic with acpi test checks
@ 2020-06-02 5:36 Michael S. Tsirkin
2020-06-02 7:40 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2020-06-02 5:36 UTC (permalink / raw)
To: qemu-devel
Cc: Paolo Bonzini, Richard Henderson, Stefan Hajnoczi,
Philippe Mathieu-Daudé
Logic reversed: allowed list should just be ignored. Instead we
only take that into account :(
Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list")
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 0ba213e9f2..55aa45dc16 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1267,7 +1267,7 @@ sub checkfilename {
# files and when changing tests.
if ($name =~ m#^tests/data/acpi/# and not $name =~ m#^\.sh$#) {
$$acpi_testexpected = $name;
- } elsif ($name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
+ } elsif (not $name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
$$acpi_nontestexpected = $name;
}
if (defined $$acpi_testexpected and defined $$acpi_nontestexpected) {
--
MST
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] checkpatch: reversed logic with acpi test checks
2020-06-02 5:36 [PATCH] checkpatch: reversed logic with acpi test checks Michael S. Tsirkin
@ 2020-06-02 7:40 ` Philippe Mathieu-Daudé
2020-06-02 11:39 ` Auger Eric
2020-06-04 18:45 ` Paolo Bonzini
2 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-02 7:40 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: Paolo Bonzini, Richard Henderson, Stefan Hajnoczi
On 6/2/20 7:36 AM, Michael S. Tsirkin wrote:
> Logic reversed: allowed list should just be ignored. Instead we
> only take that into account :(
>
> Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 0ba213e9f2..55aa45dc16 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1267,7 +1267,7 @@ sub checkfilename {
> # files and when changing tests.
> if ($name =~ m#^tests/data/acpi/# and not $name =~ m#^\.sh$#) {
> $$acpi_testexpected = $name;
> - } elsif ($name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
> + } elsif (not $name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
> $$acpi_nontestexpected = $name;
> }
> if (defined $$acpi_testexpected and defined $$acpi_nontestexpected) {
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] checkpatch: reversed logic with acpi test checks
2020-06-02 5:36 [PATCH] checkpatch: reversed logic with acpi test checks Michael S. Tsirkin
2020-06-02 7:40 ` Philippe Mathieu-Daudé
@ 2020-06-02 11:39 ` Auger Eric
2020-06-04 18:45 ` Paolo Bonzini
2 siblings, 0 replies; 6+ messages in thread
From: Auger Eric @ 2020-06-02 11:39 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: Paolo Bonzini, Richard Henderson, Stefan Hajnoczi,
Philippe Mathieu-Daudé
Hi,
On 6/2/20 7:36 AM, Michael S. Tsirkin wrote:
> Logic reversed: allowed list should just be ignored. Instead we
> only take that into account :(
>
> Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Fixes issues reported in "[RFC 0/6] TPM-TIS bios-tables-test" cover letter
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Tested-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 0ba213e9f2..55aa45dc16 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1267,7 +1267,7 @@ sub checkfilename {
> # files and when changing tests.
> if ($name =~ m#^tests/data/acpi/# and not $name =~ m#^\.sh$#) {
> $$acpi_testexpected = $name;
> - } elsif ($name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
> + } elsif (not $name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
> $$acpi_nontestexpected = $name;
> }
> if (defined $$acpi_testexpected and defined $$acpi_nontestexpected) {
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] checkpatch: reversed logic with acpi test checks
2020-06-02 5:36 [PATCH] checkpatch: reversed logic with acpi test checks Michael S. Tsirkin
2020-06-02 7:40 ` Philippe Mathieu-Daudé
2020-06-02 11:39 ` Auger Eric
@ 2020-06-04 18:45 ` Paolo Bonzini
2020-06-04 19:08 ` Michael S. Tsirkin
2 siblings, 1 reply; 6+ messages in thread
From: Paolo Bonzini @ 2020-06-04 18:45 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: Philippe Mathieu-Daudé, Richard Henderson, Stefan Hajnoczi
On 02/06/20 07:36, Michael S. Tsirkin wrote:
> Logic reversed: allowed list should just be ignored. Instead we
> only take that into account :(
>
> Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 0ba213e9f2..55aa45dc16 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1267,7 +1267,7 @@ sub checkfilename {
> # files and when changing tests.
> if ($name =~ m#^tests/data/acpi/# and not $name =~ m#^\.sh$#) {
> $$acpi_testexpected = $name;
> - } elsif ($name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
> + } elsif (not $name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
> $$acpi_nontestexpected = $name;
> }
> if (defined $$acpi_testexpected and defined $$acpi_nontestexpected) {
>
Queued with "!~" to achieve the logical not.
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] checkpatch: reversed logic with acpi test checks
2020-06-04 18:45 ` Paolo Bonzini
@ 2020-06-04 19:08 ` Michael S. Tsirkin
2020-06-04 19:52 ` Peter Maydell
0 siblings, 1 reply; 6+ messages in thread
From: Michael S. Tsirkin @ 2020-06-04 19:08 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Philippe Mathieu-Daudé,
Richard Henderson, qemu-devel, Stefan Hajnoczi
On Thu, Jun 04, 2020 at 08:45:15PM +0200, Paolo Bonzini wrote:
> On 02/06/20 07:36, Michael S. Tsirkin wrote:
> > Logic reversed: allowed list should just be ignored. Instead we
> > only take that into account :(
> >
> > Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list")
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > scripts/checkpatch.pl | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 0ba213e9f2..55aa45dc16 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -1267,7 +1267,7 @@ sub checkfilename {
> > # files and when changing tests.
> > if ($name =~ m#^tests/data/acpi/# and not $name =~ m#^\.sh$#) {
> > $$acpi_testexpected = $name;
> > - } elsif ($name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
> > + } elsif (not $name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
> > $$acpi_nontestexpected = $name;
> > }
> > if (defined $$acpi_testexpected and defined $$acpi_nontestexpected) {
> >
>
> Queued with "!~" to achieve the logical not.
>
> Paolo
Hmm perl manual says "not" is the logical not. Weird.
What's !~? My perl is a bit rusty :)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] checkpatch: reversed logic with acpi test checks
2020-06-04 19:08 ` Michael S. Tsirkin
@ 2020-06-04 19:52 ` Peter Maydell
0 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2020-06-04 19:52 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Paolo Bonzini, Richard Henderson, Philippe Mathieu-Daudé,
QEMU Developers, Stefan Hajnoczi
On Thu, 4 Jun 2020 at 20:09, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Thu, Jun 04, 2020 at 08:45:15PM +0200, Paolo Bonzini wrote:
> > On 02/06/20 07:36, Michael S. Tsirkin wrote:
> > > + } elsif (not $name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
> > > $$acpi_nontestexpected = $name;
> > > }
> > > if (defined $$acpi_testexpected and defined $$acpi_nontestexpected) {
> > >
> >
> > Queued with "!~" to achieve the logical not.
> >
> > Paolo
>
> Hmm perl manual says "not" is the logical not. Weird.
> What's !~? My perl is a bit rusty :)
man perlop says:
# Binary "!~" is just like "=~" except the return value is negated in
the logical sense.
So it's more idiomatic to use it directly rather than using =~ and then
doing a logical negation separately.
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-04 19:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 5:36 [PATCH] checkpatch: reversed logic with acpi test checks Michael S. Tsirkin
2020-06-02 7:40 ` Philippe Mathieu-Daudé
2020-06-02 11:39 ` Auger Eric
2020-06-04 18:45 ` Paolo Bonzini
2020-06-04 19:08 ` Michael S. Tsirkin
2020-06-04 19:52 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.