All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Max Reitz <mreitz@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Claudio Fontana" <cfontana@suse.de>,
	"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PULL v2 00/52] Misc patches for QEMU 5.1 soft freeze
Date: Fri, 10 Jul 2020 16:50:35 +0100	[thread overview]
Message-ID: <CAFEAcA8xyqyY4dKxZo-3=G2P177X9_v6wHG8Txrkin52gE=oMA@mail.gmail.com> (raw)
In-Reply-To: <2ea3943d-fc5b-4d75-deb2-06723da2ac74@redhat.com>

On Fri, 10 Jul 2020 at 16:46, Max Reitz <mreitz@redhat.com> wrote:
>
> On 10.07.20 17:42, Peter Maydell wrote:
> > On Fri, 10 Jul 2020 at 16:31, Max Reitz <mreitz@redhat.com> wrote:
> >>
> >> On 10.07.20 17:18, Peter Maydell wrote:
> >>> readarray only arrived sometime in bash 4, and the OSX system
> >>> bash is 3.2.57, so it won't have that builtin.
> >>
> >> It arrived with 4.0, actually, which was released 11 years ago.
> >> I had assumed that would be sufficiently mature.
> >>
> >> So, um, 11 years isn’t sufficiently mature then and I’ll have to work
> >> around not having readarray for macOS?
> >
> > It's the usual Apple-vs-GPL3 issue.
> >
> > I note that the iotests do seem to regularly run into
> > non-portable constructs: Kevin's latest pullreq has
> > just failed due to a use of 'truncate' that doesn't
> > work on the BSDs.
>
> :/
>
> I’ll send a patch to drop readarray.

Thanks. I realised as a result of discussion on IRC that
this slipped through my testing because my OSX system
wasn't running iotests at all because it didn't have a
GNU sed available.

As Dan says, the other option is to do the same thing we
do for GNU sed, and skip all the iotests if we don't
have a new enough bash. I can always install sed and
bash out of homebrew to bring my setup into line with the
cirrus CI one. If we take that path we should update the
cirrus CI config to make sure it also installs homebrew
bash (and that the iotests use bash-from-the-path, not
/bin/bash.)

-- PMM


  reply	other threads:[~2020-07-10 15:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08 17:25 [PULL v2 00/52] Misc patches for QEMU 5.1 soft freeze Paolo Bonzini
2020-07-08 17:25 ` [PULL v2 09/52] target/i386: fix IEEE SSE floating-point exception raising Paolo Bonzini
2020-07-08 17:25 ` [PULL v2 44/52] accel/kvm: Simplify kvm_check_extension() Paolo Bonzini
2020-07-08 17:25 ` [PULL v2 52/52] apic: Report current_count via 'info lapic' Paolo Bonzini
2020-07-10 12:14 ` [PULL v2 00/52] Misc patches for QEMU 5.1 soft freeze Peter Maydell
2020-07-10 12:28   ` Peter Maydell
2020-07-10 12:55     ` Claudio Fontana
2020-07-10 12:38   ` Claudio Fontana
2020-07-10 12:43     ` Peter Maydell
2020-07-10 12:52       ` Claudio Fontana
2020-07-10 12:55         ` Peter Maydell
2020-07-10 13:11           ` Philippe Mathieu-Daudé
2020-07-10 14:44             ` Claudio Fontana
2020-07-10 15:13               ` Max Reitz
2020-07-10 15:18                 ` Peter Maydell
2020-07-10 15:31                   ` Max Reitz
2020-07-10 15:42                     ` Peter Maydell
2020-07-10 15:46                       ` Max Reitz
2020-07-10 15:50                         ` Peter Maydell [this message]
2020-07-10 15:47                       ` Daniel P. Berrangé
2020-07-10 15:53                         ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8xyqyY4dKxZo-3=G2P177X9_v6wHG8Txrkin52gE=oMA@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=cfontana@suse.de \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.