* [Qemu-devel] [Bug 1268596] [NEW] Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function
@ 2014-01-13 13:35 DEnis
2014-01-13 14:08 ` [Qemu-devel] [Bug 1268596] " DEnis
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: DEnis @ 2014-01-13 13:35 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
Qemu git-cloned from mo. 13.01.14 (ca. 13:00 GMT), Version 1.7.50
#git clone git://git.qemu-project.org/qemu.git
# cd qemu; git submodule update --init dtc
#./configure --disable-xen --enable-kvm
...No Errors...
#CC="ccache gcc" make -j8
....
GEN qemu.1
Signing optionrom/kvmvapic.bin
GEN qemu-img.1
CC qapi-types.o
hw/virtio/dataplane/vring.c: In function ‘vring_pop’:
hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function [-Werror=uninitialized]
cc1: all warnings being treated as errors
make: *** [hw/virtio/dataplane/vring.o] Error 1
make: *** Waiting for unfinished jobs....
Thx.
** Affects: qemu
Importance: Undecided
Status: New
** Attachment added: "config.log"
https://bugs.launchpad.net/bugs/1268596/+attachment/3947634/+files/config.log
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1268596
Title:
Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may
be used uninitialised in this function
Status in QEMU:
New
Bug description:
Qemu git-cloned from mo. 13.01.14 (ca. 13:00 GMT), Version 1.7.50
#git clone git://git.qemu-project.org/qemu.git
# cd qemu; git submodule update --init dtc
#./configure --disable-xen --enable-kvm
...No Errors...
#CC="ccache gcc" make -j8
....
GEN qemu.1
Signing optionrom/kvmvapic.bin
GEN qemu-img.1
CC qapi-types.o
hw/virtio/dataplane/vring.c: In function ‘vring_pop’:
hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function [-Werror=uninitialized]
cc1: all warnings being treated as errors
make: *** [hw/virtio/dataplane/vring.o] Error 1
make: *** Waiting for unfinished jobs....
Thx.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1268596/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread* [Qemu-devel] [Bug 1268596] Re: Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function
2014-01-13 13:35 [Qemu-devel] [Bug 1268596] [NEW] Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function DEnis
@ 2014-01-13 14:08 ` DEnis
2014-01-13 14:40 ` Paolo Bonzini
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: DEnis @ 2014-01-13 14:08 UTC (permalink / raw)
To: qemu-devel
** Description changed:
Qemu git-cloned from mo. 13.01.14 (ca. 13:00 GMT), Version 1.7.50
-
#git clone git://git.qemu-project.org/qemu.git
# cd qemu; git submodule update --init dtc
#./configure --disable-xen --enable-kvm
...No Errors...
#CC="ccache gcc" make -j8
....
- GEN qemu.1
- Signing optionrom/kvmvapic.bin
- GEN qemu-img.1
- CC qapi-types.o
+ GEN qemu.1
+ Signing optionrom/kvmvapic.bin
+ GEN qemu-img.1
+ CC qapi-types.o
hw/virtio/dataplane/vring.c: In function ‘vring_pop’:
hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function [-Werror=uninitialized]
cc1: all warnings being treated as errors
make: *** [hw/virtio/dataplane/vring.o] Error 1
make: *** Waiting for unfinished jobs....
+ File hw/virtio/dataplane/vring.c:
+ ===========================================
+ out:
+ assert(ret < 0); ----> Line: 400
+ if (ret == -EFAULT) {
+ vring->broken = true;
+ }
+ if (elem) {
+ vring_free_element(elem);
+ }
+ *p_elem = NULL;
+ return ret;
+ }
+ ===========================================
+
+
Thx.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1268596
Title:
Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may
be used uninitialised in this function
Status in QEMU:
New
Bug description:
Qemu git-cloned from mo. 13.01.14 (ca. 13:00 GMT), Version 1.7.50
#git clone git://git.qemu-project.org/qemu.git
# cd qemu; git submodule update --init dtc
#./configure --disable-xen --enable-kvm
...No Errors...
#CC="ccache gcc" make -j8
....
GEN qemu.1
Signing optionrom/kvmvapic.bin
GEN qemu-img.1
CC qapi-types.o
hw/virtio/dataplane/vring.c: In function ‘vring_pop’:
hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function [-Werror=uninitialized]
cc1: all warnings being treated as errors
make: *** [hw/virtio/dataplane/vring.o] Error 1
make: *** Waiting for unfinished jobs....
File hw/virtio/dataplane/vring.c:
===========================================
out:
assert(ret < 0); ----> Line: 400
if (ret == -EFAULT) {
vring->broken = true;
}
if (elem) {
vring_free_element(elem);
}
*p_elem = NULL;
return ret;
}
===========================================
Thx.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1268596/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread* [Qemu-devel] [Bug 1268596] Re: Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function
2014-01-13 13:35 [Qemu-devel] [Bug 1268596] [NEW] Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function DEnis
2014-01-13 14:08 ` [Qemu-devel] [Bug 1268596] " DEnis
@ 2014-01-13 14:40 ` Paolo Bonzini
2014-01-13 14:53 ` Peter Maydell
2014-01-14 5:25 ` Stefan Hajnoczi
` (2 subsequent siblings)
4 siblings, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2014-01-13 14:40 UTC (permalink / raw)
To: qemu-devel
What compiler is this? The variable is quite obviously initialized
before that line.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1268596
Title:
Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may
be used uninitialised in this function
Status in QEMU:
New
Bug description:
Qemu git-cloned from mo. 13.01.14 (ca. 13:00 GMT), Version 1.7.50
#git clone git://git.qemu-project.org/qemu.git
# cd qemu; git submodule update --init dtc
#./configure --disable-xen --enable-kvm
...No Errors...
#CC="ccache gcc" make -j8
....
GEN qemu.1
Signing optionrom/kvmvapic.bin
GEN qemu-img.1
CC qapi-types.o
hw/virtio/dataplane/vring.c: In function ‘vring_pop’:
hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function [-Werror=uninitialized]
cc1: all warnings being treated as errors
make: *** [hw/virtio/dataplane/vring.o] Error 1
make: *** Waiting for unfinished jobs....
File hw/virtio/dataplane/vring.c:
===========================================
out:
assert(ret < 0); ----> Line: 400
if (ret == -EFAULT) {
vring->broken = true;
}
if (elem) {
vring_free_element(elem);
}
*p_elem = NULL;
return ret;
}
===========================================
Thx.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1268596/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [Bug 1268596] Re: Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function
2014-01-13 14:40 ` Paolo Bonzini
@ 2014-01-13 14:53 ` Peter Maydell
0 siblings, 0 replies; 7+ messages in thread
From: Peter Maydell @ 2014-01-13 14:53 UTC (permalink / raw)
To: Bug 1268596; +Cc: QEMU Developers
On 13 January 2014 14:40, Paolo Bonzini <bonzini@gnu.org> wrote:
> What compiler is this? The variable is quite obviously initialized
> before that line.
The issue is that one of the code paths has a shadowing declaration
of 'ret' which is what gets assigned to, and so in that code path
the compiler is correct that the outer 'ret' is not assigned to.
Stefan said he was going to send out a fix for this.
thanks
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] [Bug 1268596] Re: Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function
2014-01-13 13:35 [Qemu-devel] [Bug 1268596] [NEW] Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function DEnis
2014-01-13 14:08 ` [Qemu-devel] [Bug 1268596] " DEnis
2014-01-13 14:40 ` Paolo Bonzini
@ 2014-01-14 5:25 ` Stefan Hajnoczi
2014-01-14 12:42 ` DEnis
2016-06-17 8:31 ` T. Huth
4 siblings, 0 replies; 7+ messages in thread
From: Stefan Hajnoczi @ 2014-01-14 5:25 UTC (permalink / raw)
To: qemu-devel
A fix has been posted to the mailing list and will soon be merged into
qemu.git:
http://thread.gmane.org/gmane.comp.emulators.qemu/250657
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1268596
Title:
Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may
be used uninitialised in this function
Status in QEMU:
New
Bug description:
Qemu git-cloned from mo. 13.01.14 (ca. 13:00 GMT), Version 1.7.50
#git clone git://git.qemu-project.org/qemu.git
# cd qemu; git submodule update --init dtc
#./configure --disable-xen --enable-kvm
...No Errors...
#CC="ccache gcc" make -j8
....
GEN qemu.1
Signing optionrom/kvmvapic.bin
GEN qemu-img.1
CC qapi-types.o
hw/virtio/dataplane/vring.c: In function ‘vring_pop’:
hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function [-Werror=uninitialized]
cc1: all warnings being treated as errors
make: *** [hw/virtio/dataplane/vring.o] Error 1
make: *** Waiting for unfinished jobs....
File hw/virtio/dataplane/vring.c:
===========================================
out:
assert(ret < 0); ----> Line: 400
if (ret == -EFAULT) {
vring->broken = true;
}
if (elem) {
vring_free_element(elem);
}
*p_elem = NULL;
return ret;
}
===========================================
Thx.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1268596/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread* [Qemu-devel] [Bug 1268596] Re: Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function
2014-01-13 13:35 [Qemu-devel] [Bug 1268596] [NEW] Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function DEnis
` (2 preceding siblings ...)
2014-01-14 5:25 ` Stefan Hajnoczi
@ 2014-01-14 12:42 ` DEnis
2016-06-17 8:31 ` T. Huth
4 siblings, 0 replies; 7+ messages in thread
From: DEnis @ 2014-01-14 12:42 UTC (permalink / raw)
To: qemu-devel
Thanks a lot.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1268596
Title:
Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may
be used uninitialised in this function
Status in QEMU:
New
Bug description:
Qemu git-cloned from mo. 13.01.14 (ca. 13:00 GMT), Version 1.7.50
#git clone git://git.qemu-project.org/qemu.git
# cd qemu; git submodule update --init dtc
#./configure --disable-xen --enable-kvm
...No Errors...
#CC="ccache gcc" make -j8
....
GEN qemu.1
Signing optionrom/kvmvapic.bin
GEN qemu-img.1
CC qapi-types.o
hw/virtio/dataplane/vring.c: In function ‘vring_pop’:
hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function [-Werror=uninitialized]
cc1: all warnings being treated as errors
make: *** [hw/virtio/dataplane/vring.o] Error 1
make: *** Waiting for unfinished jobs....
File hw/virtio/dataplane/vring.c:
===========================================
out:
assert(ret < 0); ----> Line: 400
if (ret == -EFAULT) {
vring->broken = true;
}
if (elem) {
vring_free_element(elem);
}
*p_elem = NULL;
return ret;
}
===========================================
Thx.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1268596/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread* [Qemu-devel] [Bug 1268596] Re: Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function
2014-01-13 13:35 [Qemu-devel] [Bug 1268596] [NEW] Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function DEnis
` (3 preceding siblings ...)
2014-01-14 12:42 ` DEnis
@ 2016-06-17 8:31 ` T. Huth
4 siblings, 0 replies; 7+ messages in thread
From: T. Huth @ 2016-06-17 8:31 UTC (permalink / raw)
To: qemu-devel
Fix had been included here:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=385c04d0b66917457b6
... thus marking this ticked as fixed.
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1268596
Title:
Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may
be used uninitialised in this function
Status in QEMU:
Fix Released
Bug description:
Qemu git-cloned from mo. 13.01.14 (ca. 13:00 GMT), Version 1.7.50
#git clone git://git.qemu-project.org/qemu.git
# cd qemu; git submodule update --init dtc
#./configure --disable-xen --enable-kvm
...No Errors...
#CC="ccache gcc" make -j8
....
GEN qemu.1
Signing optionrom/kvmvapic.bin
GEN qemu-img.1
CC qapi-types.o
hw/virtio/dataplane/vring.c: In function ‘vring_pop’:
hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function [-Werror=uninitialized]
cc1: all warnings being treated as errors
make: *** [hw/virtio/dataplane/vring.o] Error 1
make: *** Waiting for unfinished jobs....
File hw/virtio/dataplane/vring.c:
===========================================
out:
assert(ret < 0); ----> Line: 400
if (ret == -EFAULT) {
vring->broken = true;
}
if (elem) {
vring_free_element(elem);
}
*p_elem = NULL;
return ret;
}
===========================================
Thx.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1268596/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-06-17 9:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-13 13:35 [Qemu-devel] [Bug 1268596] [NEW] Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function DEnis
2014-01-13 14:08 ` [Qemu-devel] [Bug 1268596] " DEnis
2014-01-13 14:40 ` Paolo Bonzini
2014-01-13 14:53 ` Peter Maydell
2014-01-14 5:25 ` Stefan Hajnoczi
2014-01-14 12:42 ` DEnis
2016-06-17 8:31 ` T. Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.