* [Qemu-devel] [PATCH] linux-user: Correct TARGET_NR_timerfd to TARGET_NR_timerfd_create.
@ 2015-04-08 20:26 Timothy E Baldwin
2015-04-08 20:30 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Timothy E Baldwin @ 2015-04-08 20:26 UTC (permalink / raw)
To: riku.voipio, qemu-devel; +Cc: Timothy E Baldwin
Misspelled system call name in macro was causing timerfd_create not to be supported for the ARM target.
---
linux-user/arm/syscall_nr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/arm/syscall_nr.h b/linux-user/arm/syscall_nr.h
index 7d7be7c..53552be 100644
--- a/linux-user/arm/syscall_nr.h
+++ b/linux-user/arm/syscall_nr.h
@@ -354,7 +354,7 @@
#define TARGET_NR_kexec_load (347)
#define TARGET_NR_utimensat (348)
#define TARGET_NR_signalfd (349)
-#define TARGET_NR_timerfd (350)
+#define TARGET_NR_timerfd_create (350)
#define TARGET_NR_eventfd (351)
#define TARGET_NR_fallocate (352)
#define TARGET_NR_timerfd_settime (353)
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user: Correct TARGET_NR_timerfd to TARGET_NR_timerfd_create.
2015-04-08 20:26 [Qemu-devel] [PATCH] linux-user: Correct TARGET_NR_timerfd to TARGET_NR_timerfd_create Timothy E Baldwin
@ 2015-04-08 20:30 ` Peter Maydell
2015-04-08 20:31 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2015-04-08 20:30 UTC (permalink / raw)
To: Timothy E Baldwin; +Cc: Riku Voipio, QEMU Developers
On 8 April 2015 at 21:26, Timothy E Baldwin
<T.E.Baldwin99@members.leeds.ac.uk> wrote:
> Misspelled system call name in macro was causing timerfd_create not to be supported for the ARM target.
> ---
> linux-user/arm/syscall_nr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/arm/syscall_nr.h b/linux-user/arm/syscall_nr.h
> index 7d7be7c..53552be 100644
> --- a/linux-user/arm/syscall_nr.h
> +++ b/linux-user/arm/syscall_nr.h
> @@ -354,7 +354,7 @@
> #define TARGET_NR_kexec_load (347)
> #define TARGET_NR_utimensat (348)
> #define TARGET_NR_signalfd (349)
> -#define TARGET_NR_timerfd (350)
> +#define TARGET_NR_timerfd_create (350)
> #define TARGET_NR_eventfd (351)
> #define TARGET_NR_fallocate (352)
> #define TARGET_NR_timerfd_settime (353)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user: Correct TARGET_NR_timerfd to TARGET_NR_timerfd_create.
2015-04-08 20:30 ` Peter Maydell
@ 2015-04-08 20:31 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2015-04-08 20:31 UTC (permalink / raw)
To: Timothy E Baldwin; +Cc: Riku Voipio, QEMU Developers
On 8 April 2015 at 21:30, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 8 April 2015 at 21:26, Timothy E Baldwin
> <T.E.Baldwin99@members.leeds.ac.uk> wrote:
>> Misspelled system call name in macro was causing timerfd_create not to be supported for the ARM target.
>> ---
>> linux-user/arm/syscall_nr.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/linux-user/arm/syscall_nr.h b/linux-user/arm/syscall_nr.h
>> index 7d7be7c..53552be 100644
>> --- a/linux-user/arm/syscall_nr.h
>> +++ b/linux-user/arm/syscall_nr.h
>> @@ -354,7 +354,7 @@
>> #define TARGET_NR_kexec_load (347)
>> #define TARGET_NR_utimensat (348)
>> #define TARGET_NR_signalfd (349)
>> -#define TARGET_NR_timerfd (350)
>> +#define TARGET_NR_timerfd_create (350)
>> #define TARGET_NR_eventfd (351)
>> #define TARGET_NR_fallocate (352)
>> #define TARGET_NR_timerfd_settime (353)
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
...except I've just noticed you haven't added a
Signed-off-by: line in your commit message. We need
this, or we can't apply your patch.
(It would also be good to linewrap your commit messages
at 70-75 columns or so.)
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-08 20:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-08 20:26 [Qemu-devel] [PATCH] linux-user: Correct TARGET_NR_timerfd to TARGET_NR_timerfd_create Timothy E Baldwin
2015-04-08 20:30 ` Peter Maydell
2015-04-08 20:31 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.