From: Peter Maydell <peter.maydell@linaro.org> To: "Philippe Mathieu-Daudé" <philmd@redhat.com> Cc: "Stefano Stabellini" <sstabellini@kernel.org>, "Paolo Bonzini" <pbonzini@redhat.com>, "Paul Durrant" <paul@xen.org>, "Richard Henderson" <richard.henderson@linaro.org>, "QEMU Developers" <qemu-devel@nongnu.org>, "Laurent Vivier" <laurent@vivier.eu>, qemu-arm <qemu-arm@nongnu.org>, "Gerd Hoffmann" <kraxel@redhat.com>, "Stefan Hajnoczi" <stefanha@redhat.com>, "open list:X86" <xen-devel@lists.xenproject.org>, "Anthony Perard" <anthony.perard@citrix.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com> Subject: Re: [PATCH v3 03/13] compiler.h: remove GCC < 3 __builtin_expect fallback Date: Thu, 10 Dec 2020 14:46:43 +0000 [thread overview] Message-ID: <CAFEAcA986crbUmJLR2GU5PE9BOq8w9KWKA5obYfY3eSoviMtnw@mail.gmail.com> (raw) In-Reply-To: <fead8bf1-7848-8809-c67a-e6354e7b5cf7@redhat.com> On Thu, 10 Dec 2020 at 14:32, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > On 12/10/20 2:47 PM, marcandre.lureau@redhat.com wrote: > > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > > > Since commit efc6c07 ("configure: Add a test for the minimum compiler > > version"), QEMU explicitely depends on GCC >= 4.8. > > > > (clang >= 3.4 advertizes itself as GCC >= 4.2 compatible and supports > > __builtin_expect too) > > > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > Shouldn't it becleaner to test in the configure script or Meson that > likely() and unlikely() are not defined, and define them here > unconditionally? That sounds like way more infrastructure than we need if just checking "is it already defined" is sufficient... -- PMM
WARNING: multiple messages have this Message-ID (diff)
From: Peter Maydell <peter.maydell@linaro.org> To: "Philippe Mathieu-Daudé" <philmd@redhat.com> Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>, "QEMU Developers" <qemu-devel@nongnu.org>, "Richard Henderson" <richard.henderson@linaro.org>, "Laurent Vivier" <laurent@vivier.eu>, "Paul Durrant" <paul@xen.org>, "open list:X86" <xen-devel@lists.xenproject.org>, "Stefan Hajnoczi" <stefanha@redhat.com>, "Gerd Hoffmann" <kraxel@redhat.com>, "Stefano Stabellini" <sstabellini@kernel.org>, "Anthony Perard" <anthony.perard@citrix.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu-arm <qemu-arm@nongnu.org>, "Paolo Bonzini" <pbonzini@redhat.com> Subject: Re: [PATCH v3 03/13] compiler.h: remove GCC < 3 __builtin_expect fallback Date: Thu, 10 Dec 2020 14:46:43 +0000 [thread overview] Message-ID: <CAFEAcA986crbUmJLR2GU5PE9BOq8w9KWKA5obYfY3eSoviMtnw@mail.gmail.com> (raw) In-Reply-To: <fead8bf1-7848-8809-c67a-e6354e7b5cf7@redhat.com> On Thu, 10 Dec 2020 at 14:32, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > On 12/10/20 2:47 PM, marcandre.lureau@redhat.com wrote: > > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > > > Since commit efc6c07 ("configure: Add a test for the minimum compiler > > version"), QEMU explicitely depends on GCC >= 4.8. > > > > (clang >= 3.4 advertizes itself as GCC >= 4.2 compatible and supports > > __builtin_expect too) > > > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > Shouldn't it becleaner to test in the configure script or Meson that > likely() and unlikely() are not defined, and define them here > unconditionally? That sounds like way more infrastructure than we need if just checking "is it already defined" is sufficient... -- PMM
next prev parent reply other threads:[~2020-12-10 14:49 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-10 13:47 [PATCH v3 00/13] Remove GCC < 4.8 checks marcandre.lureau 2020-12-10 13:47 ` marcandre.lureau 2020-12-10 13:47 ` [PATCH v3 01/13] qemu/atomic: Drop special case for unsupported compiler marcandre.lureau 2020-12-10 13:47 ` marcandre.lureau 2020-12-14 16:56 ` Stefan Hajnoczi 2020-12-14 16:56 ` Stefan Hajnoczi 2020-12-10 13:47 ` [PATCH v3 02/13] accel/tcg: Remove special case for GCC < 4.6 marcandre.lureau 2020-12-10 13:47 ` marcandre.lureau 2020-12-10 13:47 ` [PATCH v3 03/13] compiler.h: remove GCC < 3 __builtin_expect fallback marcandre.lureau 2020-12-10 13:47 ` marcandre.lureau 2020-12-10 14:32 ` Philippe Mathieu-Daudé 2020-12-10 14:32 ` Philippe Mathieu-Daudé 2020-12-10 14:46 ` Peter Maydell [this message] 2020-12-10 14:46 ` Peter Maydell 2020-12-10 14:55 ` Marc-André Lureau 2020-12-10 14:55 ` Marc-André Lureau 2020-12-14 10:17 ` Paolo Bonzini 2020-12-10 13:47 ` [PATCH v3 04/13] qemu-plugin.h: remove GCC < 4 marcandre.lureau 2020-12-10 13:47 ` marcandre.lureau 2020-12-10 13:47 ` [PATCH v3 05/13] tests: remove GCC < 4 fallbacks marcandre.lureau 2020-12-10 13:47 ` marcandre.lureau 2020-12-10 13:47 ` [PATCH v3 06/13] virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON marcandre.lureau 2020-12-10 13:47 ` marcandre.lureau 2020-12-11 20:11 ` Dr. David Alan Gilbert 2020-12-11 20:11 ` Dr. David Alan Gilbert 2020-12-14 16:57 ` Stefan Hajnoczi 2020-12-14 16:57 ` Stefan Hajnoczi 2020-12-10 13:47 ` [PATCH v3 07/13] compiler.h: explicit case for Clang printf attribute marcandre.lureau 2020-12-10 13:47 ` marcandre.lureau 2020-12-11 4:20 ` Michael Tokarev 2020-12-10 13:47 ` [PATCH v3 08/13] audio: remove GNUC & MSVC check marcandre.lureau 2020-12-10 13:47 ` marcandre.lureau 2020-12-10 14:26 ` Philippe Mathieu-Daudé 2020-12-10 14:26 ` Philippe Mathieu-Daudé 2020-12-10 14:27 ` Peter Maydell 2020-12-10 14:27 ` Peter Maydell 2020-12-10 14:34 ` Philippe Mathieu-Daudé 2020-12-10 14:34 ` Philippe Mathieu-Daudé 2020-12-10 14:56 ` Marc-André Lureau 2020-12-10 14:56 ` Marc-André Lureau 2020-12-10 13:47 ` [PATCH v3 09/13] poison: remove GNUC check marcandre.lureau 2020-12-10 13:47 ` marcandre.lureau 2020-12-10 14:27 ` Philippe Mathieu-Daudé 2020-12-10 14:27 ` Philippe Mathieu-Daudé 2020-12-10 13:47 ` [PATCH v3 10/13] xen: " marcandre.lureau 2020-12-10 13:47 ` marcandre.lureau 2020-12-10 13:47 ` [PATCH v3 11/13] compiler: " marcandre.lureau 2020-12-10 13:47 ` marcandre.lureau 2020-12-12 13:53 ` Marc-André Lureau 2020-12-12 13:53 ` Marc-André Lureau 2020-12-12 14:00 ` Peter Maydell 2020-12-12 14:00 ` Peter Maydell 2020-12-10 13:47 ` [PATCH v3 12/13] linux-user: " marcandre.lureau 2020-12-10 13:47 ` marcandre.lureau 2020-12-10 14:27 ` Philippe Mathieu-Daudé 2020-12-10 14:27 ` Philippe Mathieu-Daudé 2020-12-10 13:47 ` [PATCH v3 13/13] compiler.h: remove QEMU_GNUC_PREREQ marcandre.lureau 2020-12-10 13:47 ` marcandre.lureau 2020-12-14 8:05 ` Marc-André Lureau 2020-12-14 8:05 ` Marc-André Lureau 2020-12-10 13:57 ` [PATCH v3 00/13] Remove GCC < 4.8 checks no-reply 2020-12-10 13:57 ` no-reply 2020-12-14 10:20 ` Paolo Bonzini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAFEAcA986crbUmJLR2GU5PE9BOq8w9KWKA5obYfY3eSoviMtnw@mail.gmail.com \ --to=peter.maydell@linaro.org \ --cc=anthony.perard@citrix.com \ --cc=dgilbert@redhat.com \ --cc=kraxel@redhat.com \ --cc=laurent@vivier.eu \ --cc=marcandre.lureau@redhat.com \ --cc=paul@xen.org \ --cc=pbonzini@redhat.com \ --cc=philmd@redhat.com \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=richard.henderson@linaro.org \ --cc=sstabellini@kernel.org \ --cc=stefanha@redhat.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.