All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Alexandre Iooss <erdnaxe@crans.org>
Cc: "open list:STM32F100" <qemu-arm@nongnu.org>,
	"open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [PATCH 2/2] stm32vldiscovery: Add the STM32VLDISCOVERY Machine
Date: Mon, 14 Jun 2021 16:52:26 +0100	[thread overview]
Message-ID: <CAFEAcA9EEOg92Vz3ZiyV3XeWXn8PV=sGm7wiaqoj==K6PoPM-w@mail.gmail.com> (raw)
In-Reply-To: <20210608161028.4159582-3-erdnaxe@crans.org>

On Tue, 8 Jun 2021 at 17:10, Alexandre Iooss <erdnaxe@crans.org> wrote:
>
> This is a Cortex-M3 based machine. Information can be found at:
> https://www.st.com/en/evaluation-tools/stm32vldiscovery.html
>
> Signed-off-by: Alexandre Iooss <erdnaxe@crans.org>

The commit message says this is Cortex-M3 based, but the
code gives it a Cortex-M4. Which is correct?

> ---
>  MAINTAINERS                             |  6 +++
>  default-configs/devices/arm-softmmu.mak |  1 +
>  hw/arm/Kconfig                          |  4 ++
>  hw/arm/meson.build                      |  1 +
>  hw/arm/stm32vldiscovery.c               | 66 +++++++++++++++++++++++++
>  5 files changed, 78 insertions(+)
>  create mode 100644 hw/arm/stm32vldiscovery.c

Could you add some documentation for the new board, please?
This lives in docs/system/arm. Commit c9f8511ea8d2b807 gives
an example of adding docs for a board.

thanks
-- PMM


  reply	other threads:[~2021-06-14 16:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08 16:10 [PATCH 0/2] STM32VLDISCOVERY Machine Model Alexandre Iooss
2021-06-08 16:10 ` [PATCH 1/2] stm32f100: Add the stm32f100 SoC Alexandre Iooss
2021-06-14 16:04   ` Peter Maydell
2021-06-15  7:56     ` Alexandre IOOSS
2021-06-15  7:41   ` Alistair Francis
2021-06-15  7:49     ` Alexandre IOOSS
2021-06-15  8:04       ` Alistair Francis
2021-06-15  9:15         ` Alexandre IOOSS
2021-06-15 10:40           ` Alistair Francis
2021-06-08 16:10 ` [PATCH 2/2] stm32vldiscovery: Add the STM32VLDISCOVERY Machine Alexandre Iooss
2021-06-14 15:52   ` Peter Maydell [this message]
2021-06-15  7:16     ` Alexandre IOOSS
2021-06-15  7:50       ` Alistair Francis
2021-06-15  9:07       ` Peter Maydell
2021-06-14 16:05 ` [PATCH 0/2] STM32VLDISCOVERY Machine Model Peter Maydell
2021-06-14 16:16   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA9EEOg92Vz3ZiyV3XeWXn8PV=sGm7wiaqoj==K6PoPM-w@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=erdnaxe@crans.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.