All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Zhang Chen <chen.zhang@intel.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	qemu-dev <qemu-devel@nongnu.org>, John Snow <jsnow@redhat.com>,
	Fam Zheng <fam@euphon.net>
Subject: Re: [Qemu-devel] [PATCH] bitops.h: Remove unused bitops function test_and_change_bit()
Date: Thu, 4 Apr 2019 08:43:27 +0700	[thread overview]
Message-ID: <CAFEAcA9PU4=C8yApkU8bRd2-rCHd2DqtnDv5v=pC5M+PK8rkMw@mail.gmail.com> (raw)
In-Reply-To: <20190329200445.28512-1-chen.zhang@intel.com>

On Sat, 30 Mar 2019 at 03:09, Zhang Chen <chen.zhang@intel.com> wrote:
>
> From: Zhang Chen <chen.zhang@intel.com>
>
> In current codes we use change_bit() to finish the job.
>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> ---
>  include/qemu/bitmap.h |  1 -
>  include/qemu/bitops.h | 15 ---------------
>  2 files changed, 16 deletions(-)

Do we gain anything by removing this function? IIRC these functions
are all borrowed from the Linux kernel, so keeping the same API
as the kernel does would make sense to me, even if we happen
not to use all of it right now.

thanks
-- PMM

  parent reply	other threads:[~2019-04-04  1:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190329200445.28512-1-chen.zhang@intel.com>
2019-04-03 20:44 ` [Qemu-devel] [PATCH] bitops.h: Remove unused bitops function test_and_change_bit() John Snow
2019-04-04  1:43 ` Peter Maydell [this message]
2019-04-04  6:25   ` Zhang, Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA9PU4=C8yApkU8bRd2-rCHd2DqtnDv5v=pC5M+PK8rkMw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=chen.zhang@intel.com \
    --cc=dgilbert@redhat.com \
    --cc=fam@euphon.net \
    --cc=jsnow@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.