From: Peter Maydell <peter.maydell@linaro.org>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "proljc@gmail.com" <proljc@gmail.com>,
"kbastian@mail.uni-paderborn.de" <kbastian@mail.uni-paderborn.de>,
"mark.cave-ayland@ilande.co.uk" <mark.cave-ayland@ilande.co.uk>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"agraf@suse.de" <agraf@suse.de>,
"blauwirbel@gmail.com" <blauwirbel@gmail.com>,
"jcmvbkbc@gmail.com" <jcmvbkbc@gmail.com>,
Aleksandar Markovic <Aleksandar.Markovic@imgtec.com>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
Petar Jovanovic <Petar.Jovanovic@imgtec.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
Miodrag Dinic <Miodrag.Dinic@imgtec.com>,
"edgar.iglesias@gmail.com" <edgar.iglesias@gmail.com>,
"gxt@mprc.pku.edu.cn" <gxt@mprc.pku.edu.cn>,
Leon Alrae <Leon.Alrae@imgtec.com>,
"afaerber@suse.de" <afaerber@suse.de>,
"aurelien@aurel32.net" <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 1/2] softfloat: Enable run-time-configurable meaning of signaling NaN bit
Date: Mon, 4 Apr 2016 20:38:54 +0100 [thread overview]
Message-ID: <CAFEAcA9axhkDC0tDT1ujNZUpHbCnMqSxaL-KTD2=TV=XOyEbuw@mail.gmail.com> (raw)
In-Reply-To: <20160404193723.GD22665@thinpad.lan.raisama.net>
On 4 April 2016 at 20:37, Eduardo Habkost <ehabkost@redhat.com> wrote:
> On Mon, Apr 04, 2016 at 02:31:47PM +0100, Peter Maydell wrote:
>> On 4 April 2016 at 14:21, Aleksandar Markovic
>> <Aleksandar.Markovic@imgtec.com> wrote:
>> > B. arm - explicitely sets other fields of float_status,
>> > explicit invocation of set_snan_bit_is_one(0) added
>>
>> We zero the float_status structs on reset, because they are earlier
>> in the CPUARMState structure than the 'features' field (and so the
>> memset() in arm_cpu_reset() will clear them). So you don't
>> need to explicitly zero a field like this. I expect the other
>> architectures are the same.
>
> Even if it is not zeroed on reset, it is zeroed on object_new().
> Isn't that enough?
It must be zeroed on reset, otherwise we won't get the right
behaviour if you reset the CPU after running it for a bit.
object_new() zeroing is not sufficient.
thanks
-- PMM
next prev parent reply other threads:[~2016-04-04 19:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 12:50 [Qemu-devel] [PATCH 0/2] target-mips: Fix IEEE 754-2008-related issues Aleksandar Markovic
2016-03-25 12:50 ` [Qemu-devel] [PATCH 1/2] softfloat: Enable run-time-configurable meaning of signaling NaN bit Aleksandar Markovic
2016-03-28 21:36 ` Richard Henderson
2016-04-04 13:21 ` Aleksandar Markovic
2016-04-04 13:31 ` Peter Maydell
2016-04-04 19:37 ` Eduardo Habkost
2016-04-04 19:38 ` Peter Maydell [this message]
2016-04-04 19:42 ` Eduardo Habkost
2016-04-04 19:46 ` Peter Maydell
2016-04-04 19:56 ` Eduardo Habkost
2016-03-29 12:50 ` Bastian Koppelmann
2016-03-30 16:58 ` Aleksandar Markovic
2016-04-01 19:02 ` Leon Alrae
2016-04-03 14:25 ` Aleksandar Markovic
2016-04-04 16:10 ` Leon Alrae
2016-03-25 12:50 ` [Qemu-devel] [PATCH 2/2] target-mips: Implement IEEE 754-2008 functionality for R6 and MSA instructions Aleksandar Markovic
2016-03-28 21:49 ` Richard Henderson
2016-03-30 19:28 ` Aleksandar Markovic
2016-03-31 11:55 ` Aleksandar Markovic
2016-03-31 16:30 ` Richard Henderson
2016-04-01 19:07 ` Leon Alrae
2016-04-03 15:05 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9axhkDC0tDT1ujNZUpHbCnMqSxaL-KTD2=TV=XOyEbuw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=Aleksandar.Markovic@imgtec.com \
--cc=Leon.Alrae@imgtec.com \
--cc=Miodrag.Dinic@imgtec.com \
--cc=Petar.Jovanovic@imgtec.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jcmvbkbc@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=proljc@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.