* [PATCH] Makefile: add missing mkdir MANUAL_BUILDDIR
@ 2020-01-20 16:34 Stefan Hajnoczi
2020-01-21 11:06 ` Miroslav Rezanina
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Hajnoczi @ 2020-01-20 16:34 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, mrezanin, Stefan Hajnoczi
The MANUAL_BUILDDIR directory is automatically created by sphinx-build
for the other targets. The index.html target does not use sphinx-build
so we must manually create the directory to avoid the following error:
GEN docs/built/index.html
/bin/sh: docs/built/index.html: No such file or directory
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index afa5cb6548..6562b0dc97 100644
--- a/Makefile
+++ b/Makefile
@@ -1022,6 +1022,7 @@ $(MANUAL_BUILDDIR)/interop/qemu-ga.8: $(call manual-deps,interop)
$(call build-manual,interop,man)
$(MANUAL_BUILDDIR)/index.html: $(SRC_PATH)/docs/index.html.in qemu-version.h
+ @mkdir -p "$(MANUAL_BUILDDIR)"
$(call quiet-command, sed "s|@@VERSION@@|${VERSION}|g" $< >$@, \
"GEN","$@")
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile: add missing mkdir MANUAL_BUILDDIR
2020-01-20 16:34 [PATCH] Makefile: add missing mkdir MANUAL_BUILDDIR Stefan Hajnoczi
@ 2020-01-21 11:06 ` Miroslav Rezanina
2020-01-21 11:56 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Miroslav Rezanina @ 2020-01-21 11:06 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Peter Maydell, qemu-devel
On Mon, Jan 20, 2020 at 04:34:00PM +0000, Stefan Hajnoczi wrote:
> The MANUAL_BUILDDIR directory is automatically created by sphinx-build
> for the other targets. The index.html target does not use sphinx-build
> so we must manually create the directory to avoid the following error:
>
> GEN docs/built/index.html
> /bin/sh: docs/built/index.html: No such file or directory
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index afa5cb6548..6562b0dc97 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1022,6 +1022,7 @@ $(MANUAL_BUILDDIR)/interop/qemu-ga.8: $(call manual-deps,interop)
> $(call build-manual,interop,man)
>
> $(MANUAL_BUILDDIR)/index.html: $(SRC_PATH)/docs/index.html.in qemu-version.h
> + @mkdir -p "$(MANUAL_BUILDDIR)"
> $(call quiet-command, sed "s|@@VERSION@@|${VERSION}|g" $< >$@, \
> "GEN","$@")
>
> --
> 2.24.1
>
Fixing our issues with build,
Reviewed-by: Miroslav Rezanina <mrezanin@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile: add missing mkdir MANUAL_BUILDDIR
2020-01-21 11:06 ` Miroslav Rezanina
@ 2020-01-21 11:56 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2020-01-21 11:56 UTC (permalink / raw)
To: Miroslav Rezanina; +Cc: QEMU Developers, Stefan Hajnoczi
On Tue, 21 Jan 2020 at 11:06, Miroslav Rezanina <mrezanin@redhat.com> wrote:
>
> On Mon, Jan 20, 2020 at 04:34:00PM +0000, Stefan Hajnoczi wrote:
> > The MANUAL_BUILDDIR directory is automatically created by sphinx-build
> > for the other targets. The index.html target does not use sphinx-build
> > so we must manually create the directory to avoid the following error:
> >
> > GEN docs/built/index.html
> > /bin/sh: docs/built/index.html: No such file or directory
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Makefile b/Makefile
> > index afa5cb6548..6562b0dc97 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1022,6 +1022,7 @@ $(MANUAL_BUILDDIR)/interop/qemu-ga.8: $(call manual-deps,interop)
> > $(call build-manual,interop,man)
> >
> > $(MANUAL_BUILDDIR)/index.html: $(SRC_PATH)/docs/index.html.in qemu-version.h
> > + @mkdir -p "$(MANUAL_BUILDDIR)"
> > $(call quiet-command, sed "s|@@VERSION@@|${VERSION}|g" $< >$@, \
> > "GEN","$@")
> >
> > --
> > 2.24.1
> >
>
> Fixing our issues with build,
>
> Reviewed-by: Miroslav Rezanina <mrezanin@redhat.com>
Thanks; applied to master as a build-fix.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-21 11:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-20 16:34 [PATCH] Makefile: add missing mkdir MANUAL_BUILDDIR Stefan Hajnoczi
2020-01-21 11:06 ` Miroslav Rezanina
2020-01-21 11:56 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.