From: Peter Maydell <peter.maydell@linaro.org>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
Shannon Zhao <shannon.zhao@linaro.org>,
kvm-devel <kvm@vger.kernel.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
Subject: Re: [PATCH 1/2] arm: KVM: Do not update PC if the trap handler has updated it
Date: Tue, 22 Dec 2015 14:50:15 +0000 [thread overview]
Message-ID: <CAFEAcA9dALQv8Xcyg5FLAvRaJfH5UT2u4jrLjofLh5Ff2yo=8Q@mail.gmail.com> (raw)
In-Reply-To: <20151222143947.GA5631@cbox>
On 22 December 2015 at 14:39, Christoffer Dall
<christoffer.dall@linaro.org> wrote:
> On Tue, Dec 22, 2015 at 11:08:10AM +0000, Peter Maydell wrote:
>> Won't this result in our incorrectly skipping the first insn
>> in the fault handler if the original offending instruction
>> was itself the first insn in the fault handler?
>>
> Wouldn't that then loop with the exception forever?
Yes, but so would real hardware...
thanks
-- PMM
WARNING: multiple messages have this Message-ID (diff)
From: peter.maydell@linaro.org (Peter Maydell)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm: KVM: Do not update PC if the trap handler has updated it
Date: Tue, 22 Dec 2015 14:50:15 +0000 [thread overview]
Message-ID: <CAFEAcA9dALQv8Xcyg5FLAvRaJfH5UT2u4jrLjofLh5Ff2yo=8Q@mail.gmail.com> (raw)
In-Reply-To: <20151222143947.GA5631@cbox>
On 22 December 2015 at 14:39, Christoffer Dall
<christoffer.dall@linaro.org> wrote:
> On Tue, Dec 22, 2015 at 11:08:10AM +0000, Peter Maydell wrote:
>> Won't this result in our incorrectly skipping the first insn
>> in the fault handler if the original offending instruction
>> was itself the first insn in the fault handler?
>>
> Wouldn't that then loop with the exception forever?
Yes, but so would real hardware...
thanks
-- PMM
next prev parent reply other threads:[~2015-12-22 14:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 9:55 [PATCH 0/2] Fix PC corruption when injecting a fault Marc Zyngier
2015-12-22 9:55 ` Marc Zyngier
2015-12-22 9:55 ` [PATCH 1/2] arm: KVM: Do not update PC if the trap handler has updated it Marc Zyngier
2015-12-22 9:55 ` Marc Zyngier
2015-12-22 10:35 ` Shannon Zhao
2015-12-22 10:35 ` Shannon Zhao
2015-12-22 11:08 ` Peter Maydell
2015-12-22 11:08 ` Peter Maydell
2015-12-22 14:39 ` Christoffer Dall
2015-12-22 14:39 ` Christoffer Dall
2015-12-22 14:50 ` Peter Maydell [this message]
2015-12-22 14:50 ` Peter Maydell
2016-01-07 8:50 ` Marc Zyngier
2016-01-07 8:50 ` Marc Zyngier
2016-01-07 8:59 ` Shannon Zhao
2016-01-07 8:59 ` Shannon Zhao
2016-01-07 9:05 ` Marc Zyngier
2016-01-07 9:05 ` Marc Zyngier
2015-12-22 9:55 ` [PATCH 2/2] arm64: " Marc Zyngier
2015-12-22 9:55 ` Marc Zyngier
2015-12-22 10:15 ` Shannon Zhao
2015-12-22 10:15 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9dALQv8Xcyg5FLAvRaJfH5UT2u4jrLjofLh5Ff2yo=8Q@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=shannon.zhao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.