* [Qemu-devel] [PATCH 0/1] tcg: queued patch
@ 2019-06-13 4:16 Richard Henderson
2019-06-13 4:16 ` [Qemu-devel] [PATCH 1/1] tcg: Fix typos in helper_gvec_sar{8, 32, 64}v Richard Henderson
2019-06-13 4:24 ` [Qemu-devel] [PULL 0/1] tcg: queued patch Richard Henderson
0 siblings, 2 replies; 8+ messages in thread
From: Richard Henderson @ 2019-06-13 4:16 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
The following changes since commit a050901d4b40092dc356b59912c6df39e389c7b9:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190612' into staging (2019-06-12 14:43:47 +0100)
are available in the Git repository at:
https://github.com/rth7680/qemu.git tags/pull-tcg-20190612
for you to fetch changes up to 899f08ad1d1231dbbfa67298413f05ed2679fb02:
tcg: Fix typos in helper_gvec_sar{8,32,64}v (2019-06-12 21:08:38 -0700)
----------------------------------------------------------------
Fix vector arithmetic right shift helpers.
----------------------------------------------------------------
Richard Henderson (1):
tcg: Fix typos in helper_gvec_sar{8,32,64}v
accel/tcg/tcg-runtime-gvec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 8+ messages in thread* [Qemu-devel] [PATCH 1/1] tcg: Fix typos in helper_gvec_sar{8, 32, 64}v 2019-06-13 4:16 [Qemu-devel] [PATCH 0/1] tcg: queued patch Richard Henderson @ 2019-06-13 4:16 ` Richard Henderson 2019-06-14 5:22 ` Aleksandar Markovic 2019-06-13 4:24 ` [Qemu-devel] [PULL 0/1] tcg: queued patch Richard Henderson 1 sibling, 1 reply; 8+ messages in thread From: Richard Henderson @ 2019-06-13 4:16 UTC (permalink / raw) To: qemu-devel; +Cc: peter.maydell The loop is written with scalars, not vectors. Use the correct type when incrementing. Fixes: 5ee5c14cacd Reported-by: Laurent Vivier <lvivier@redhat.com> Tested-by: Laurent Vivier <lvivier@redhat.com> Reviewed-by: Laurent Vivier <lvivier@redhat.com> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- accel/tcg/tcg-runtime-gvec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/accel/tcg/tcg-runtime-gvec.c b/accel/tcg/tcg-runtime-gvec.c index 3b6052fe97..51cb29ca79 100644 --- a/accel/tcg/tcg-runtime-gvec.c +++ b/accel/tcg/tcg-runtime-gvec.c @@ -874,7 +874,7 @@ void HELPER(gvec_sar8v)(void *d, void *a, void *b, uint32_t desc) intptr_t oprsz = simd_oprsz(desc); intptr_t i; - for (i = 0; i < oprsz; i += sizeof(vec8)) { + for (i = 0; i < oprsz; i += sizeof(int8_t)) { uint8_t sh = *(uint8_t *)(b + i) & 7; *(int8_t *)(d + i) = *(int8_t *)(a + i) >> sh; } @@ -898,7 +898,7 @@ void HELPER(gvec_sar32v)(void *d, void *a, void *b, uint32_t desc) intptr_t oprsz = simd_oprsz(desc); intptr_t i; - for (i = 0; i < oprsz; i += sizeof(vec32)) { + for (i = 0; i < oprsz; i += sizeof(int32_t)) { uint8_t sh = *(uint32_t *)(b + i) & 31; *(int32_t *)(d + i) = *(int32_t *)(a + i) >> sh; } @@ -910,7 +910,7 @@ void HELPER(gvec_sar64v)(void *d, void *a, void *b, uint32_t desc) intptr_t oprsz = simd_oprsz(desc); intptr_t i; - for (i = 0; i < oprsz; i += sizeof(vec64)) { + for (i = 0; i < oprsz; i += sizeof(int64_t)) { uint8_t sh = *(uint64_t *)(b + i) & 63; *(int64_t *)(d + i) = *(int64_t *)(a + i) >> sh; } -- 2.17.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] tcg: Fix typos in helper_gvec_sar{8, 32, 64}v 2019-06-13 4:16 ` [Qemu-devel] [PATCH 1/1] tcg: Fix typos in helper_gvec_sar{8, 32, 64}v Richard Henderson @ 2019-06-14 5:22 ` Aleksandar Markovic 2019-06-14 6:03 ` Aleksandar Markovic 0 siblings, 1 reply; 8+ messages in thread From: Aleksandar Markovic @ 2019-06-14 5:22 UTC (permalink / raw) To: Richard Henderson; +Cc: peter.maydell, qemu-devel On Jun 13, 2019 6:16 AM, "Richard Henderson" <richard.henderson@linaro.org> wrote: > > The loop is written with scalars, not vectors. > Use the correct type when incrementing. > > Fixes: 5ee5c14cacd > Reported-by: Laurent Vivier <lvivier@redhat.com> > Tested-by: Laurent Vivier <lvivier@redhat.com> > Reviewed-by: Laurent Vivier <lvivier@redhat.com> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- This is certainly not a case of “typo” (which would mean that you accidentally typed “vec8” instead od “int8_t”). So, change the title to “tcg: Fix loop step in helper_gvec_sar{8, 32, 64}v” or similar. > accel/tcg/tcg-runtime-gvec.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/accel/tcg/tcg-runtime-gvec.c b/accel/tcg/tcg-runtime-gvec.c > index 3b6052fe97..51cb29ca79 100644 > --- a/accel/tcg/tcg-runtime-gvec.c > +++ b/accel/tcg/tcg-runtime-gvec.c > @@ -874,7 +874,7 @@ void HELPER(gvec_sar8v)(void *d, void *a, void *b, uint32_t desc) > intptr_t oprsz = simd_oprsz(desc); > intptr_t i; > > - for (i = 0; i < oprsz; i += sizeof(vec8)) { > + for (i = 0; i < oprsz; i += sizeof(int8_t)) { > uint8_t sh = *(uint8_t *)(b + i) & 7; > *(int8_t *)(d + i) = *(int8_t *)(a + i) >> sh; > } > @@ -898,7 +898,7 @@ void HELPER(gvec_sar32v)(void *d, void *a, void *b, uint32_t desc) > intptr_t oprsz = simd_oprsz(desc); > intptr_t i; > > - for (i = 0; i < oprsz; i += sizeof(vec32)) { > + for (i = 0; i < oprsz; i += sizeof(int32_t)) { > uint8_t sh = *(uint32_t *)(b + i) & 31; > *(int32_t *)(d + i) = *(int32_t *)(a + i) >> sh; > } > @@ -910,7 +910,7 @@ void HELPER(gvec_sar64v)(void *d, void *a, void *b, uint32_t desc) > intptr_t oprsz = simd_oprsz(desc); > intptr_t i; > > - for (i = 0; i < oprsz; i += sizeof(vec64)) { > + for (i = 0; i < oprsz; i += sizeof(int64_t)) { > uint8_t sh = *(uint64_t *)(b + i) & 63; > *(int64_t *)(d + i) = *(int64_t *)(a + i) >> sh; > } > -- > 2.17.1 > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] tcg: Fix typos in helper_gvec_sar{8, 32, 64}v 2019-06-14 5:22 ` Aleksandar Markovic @ 2019-06-14 6:03 ` Aleksandar Markovic 2019-06-14 6:09 ` Aleksandar Markovic 0 siblings, 1 reply; 8+ messages in thread From: Aleksandar Markovic @ 2019-06-14 6:03 UTC (permalink / raw) To: Richard Henderson; +Cc: peter.maydell, qemu-devel On Jun 14, 2019 7:22 AM, "Aleksandar Markovic" <aleksandar.m.mail@gmail.com> wrote: > > > On Jun 13, 2019 6:16 AM, "Richard Henderson" <richard.henderson@linaro.org> wrote: > > I just noticed that this patch is already applied to the upstream - no pull request, no waiting time for community review - > > The loop is written with scalars, not vectors. > > Use the correct type when incrementing. > > > > Fixes: 5ee5c14cacd > > Reported-by: Laurent Vivier <lvivier@redhat.com> > > Tested-by: Laurent Vivier <lvivier@redhat.com> > > Reviewed-by: Laurent Vivier <lvivier@redhat.com> > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > > --- > > This is certainly not a case of “typo” (which would mean that you accidentally typed “vec8” instead od “int8_t”). So, change the title to “tcg: Fix loop step in > helper_gvec_sar{8, 32, 64}v” or similar. > > > accel/tcg/tcg-runtime-gvec.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/accel/tcg/tcg-runtime-gvec.c b/accel/tcg/tcg-runtime-gvec.c > > index 3b6052fe97..51cb29ca79 100644 > > --- a/accel/tcg/tcg-runtime-gvec.c > > +++ b/accel/tcg/tcg-runtime-gvec.c > > @@ -874,7 +874,7 @@ void HELPER(gvec_sar8v)(void *d, void *a, void *b, uint32_t desc) > > intptr_t oprsz = simd_oprsz(desc); > > intptr_t i; > > > > - for (i = 0; i < oprsz; i += sizeof(vec8)) { > > + for (i = 0; i < oprsz; i += sizeof(int8_t)) { > > uint8_t sh = *(uint8_t *)(b + i) & 7; > > *(int8_t *)(d + i) = *(int8_t *)(a + i) >> sh; > > } > > @@ -898,7 +898,7 @@ void HELPER(gvec_sar32v)(void *d, void *a, void *b, uint32_t desc) > > intptr_t oprsz = simd_oprsz(desc); > > intptr_t i; > > > > - for (i = 0; i < oprsz; i += sizeof(vec32)) { > > + for (i = 0; i < oprsz; i += sizeof(int32_t)) { > > uint8_t sh = *(uint32_t *)(b + i) & 31; > > *(int32_t *)(d + i) = *(int32_t *)(a + i) >> sh; > > } > > @@ -910,7 +910,7 @@ void HELPER(gvec_sar64v)(void *d, void *a, void *b, uint32_t desc) > > intptr_t oprsz = simd_oprsz(desc); > > intptr_t i; > > > > - for (i = 0; i < oprsz; i += sizeof(vec64)) { > > + for (i = 0; i < oprsz; i += sizeof(int64_t)) { > > uint8_t sh = *(uint64_t *)(b + i) & 63; > > *(int64_t *)(d + i) = *(int64_t *)(a + i) >> sh; > > } > > -- > > 2.17.1 > > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] tcg: Fix typos in helper_gvec_sar{8, 32, 64}v 2019-06-14 6:03 ` Aleksandar Markovic @ 2019-06-14 6:09 ` Aleksandar Markovic 2019-06-14 8:33 ` Peter Maydell 0 siblings, 1 reply; 8+ messages in thread From: Aleksandar Markovic @ 2019-06-14 6:09 UTC (permalink / raw) To: Richard Henderson; +Cc: peter.maydell, qemu-devel On Jun 14, 2019 8:03 AM, "Aleksandar Markovic" <aleksandar.m.mail@gmail.com> wrote: > > > On Jun 14, 2019 7:22 AM, "Aleksandar Markovic" < aleksandar.m.mail@gmail.com> wrote: > > > > > > On Jun 13, 2019 6:16 AM, "Richard Henderson" < richard.henderson@linaro.org> wrote: > > > > > I just noticed that this patch is already applied to the upstream - no pull request, no waiting time for community review - > Peter, would you please explain to me what was going on with this patch? I am truly confused, since all rules and procedures seem to be somehow circumvented, don't they? Yours, Aleksandar > > > The loop is written with scalars, not vectors. > > > Use the correct type when incrementing. > > > > > > Fixes: 5ee5c14cacd > > > Reported-by: Laurent Vivier <lvivier@redhat.com> > > > Tested-by: Laurent Vivier <lvivier@redhat.com> > > > Reviewed-by: Laurent Vivier <lvivier@redhat.com> > > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > > > --- > > > > This is certainly not a case of “typo” (which would mean that you accidentally typed “vec8” instead od “int8_t”). So, change the title to “tcg: Fix loop step in > > helper_gvec_sar{8, 32, 64}v” or similar. > > > > > accel/tcg/tcg-runtime-gvec.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/accel/tcg/tcg-runtime-gvec.c b/accel/tcg/tcg-runtime-gvec.c > > > index 3b6052fe97..51cb29ca79 100644 > > > --- a/accel/tcg/tcg-runtime-gvec.c > > > +++ b/accel/tcg/tcg-runtime-gvec.c > > > @@ -874,7 +874,7 @@ void HELPER(gvec_sar8v)(void *d, void *a, void *b, uint32_t desc) > > > intptr_t oprsz = simd_oprsz(desc); > > > intptr_t i; > > > > > > - for (i = 0; i < oprsz; i += sizeof(vec8)) { > > > + for (i = 0; i < oprsz; i += sizeof(int8_t)) { > > > uint8_t sh = *(uint8_t *)(b + i) & 7; > > > *(int8_t *)(d + i) = *(int8_t *)(a + i) >> sh; > > > } > > > @@ -898,7 +898,7 @@ void HELPER(gvec_sar32v)(void *d, void *a, void *b, uint32_t desc) > > > intptr_t oprsz = simd_oprsz(desc); > > > intptr_t i; > > > > > > - for (i = 0; i < oprsz; i += sizeof(vec32)) { > > > + for (i = 0; i < oprsz; i += sizeof(int32_t)) { > > > uint8_t sh = *(uint32_t *)(b + i) & 31; > > > *(int32_t *)(d + i) = *(int32_t *)(a + i) >> sh; > > > } > > > @@ -910,7 +910,7 @@ void HELPER(gvec_sar64v)(void *d, void *a, void *b, uint32_t desc) > > > intptr_t oprsz = simd_oprsz(desc); > > > intptr_t i; > > > > > > - for (i = 0; i < oprsz; i += sizeof(vec64)) { > > > + for (i = 0; i < oprsz; i += sizeof(int64_t)) { > > > uint8_t sh = *(uint64_t *)(b + i) & 63; > > > *(int64_t *)(d + i) = *(int64_t *)(a + i) >> sh; > > > } > > > -- > > > 2.17.1 > > > > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] tcg: Fix typos in helper_gvec_sar{8, 32, 64}v 2019-06-14 6:09 ` Aleksandar Markovic @ 2019-06-14 8:33 ` Peter Maydell 0 siblings, 0 replies; 8+ messages in thread From: Peter Maydell @ 2019-06-14 8:33 UTC (permalink / raw) To: Aleksandar Markovic; +Cc: Richard Henderson, QEMU Developers On Fri, 14 Jun 2019 at 07:09, Aleksandar Markovic <aleksandar.m.mail@gmail.com> wrote: > Peter, would you please explain to me what was going on with this patch? The original patch was posted to the list on the 7th June; it got reviewed and tested by Laurent. This email accidentally has "PATCH" in the subject line instead of "PULL" but it's just part of the pull request that got it into master -- that's just an accidental error by Richard when he put the pull request together. thanks -- PMM ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Qemu-devel] [PULL 0/1] tcg: queued patch 2019-06-13 4:16 [Qemu-devel] [PATCH 0/1] tcg: queued patch Richard Henderson 2019-06-13 4:16 ` [Qemu-devel] [PATCH 1/1] tcg: Fix typos in helper_gvec_sar{8, 32, 64}v Richard Henderson @ 2019-06-13 4:24 ` Richard Henderson 2019-06-13 12:24 ` Peter Maydell 1 sibling, 1 reply; 8+ messages in thread From: Richard Henderson @ 2019-06-13 4:24 UTC (permalink / raw) To: qemu-devel, Peter Maydell Dang it, forgot the PULL tag. r~ The following changes since commit a050901d4b40092dc356b59912c6df39e389c7b9: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190612' into staging (2019-06-12 14:43:47 +0100) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-tcg-20190612 for you to fetch changes up to 899f08ad1d1231dbbfa67298413f05ed2679fb02: tcg: Fix typos in helper_gvec_sar{8,32,64}v (2019-06-12 21:08:38 -0700) ---------------------------------------------------------------- Fix vector arithmetic right shift helpers. ---------------------------------------------------------------- Richard Henderson (1): tcg: Fix typos in helper_gvec_sar{8,32,64}v accel/tcg/tcg-runtime-gvec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PULL 0/1] tcg: queued patch 2019-06-13 4:24 ` [Qemu-devel] [PULL 0/1] tcg: queued patch Richard Henderson @ 2019-06-13 12:24 ` Peter Maydell 0 siblings, 0 replies; 8+ messages in thread From: Peter Maydell @ 2019-06-13 12:24 UTC (permalink / raw) To: Richard Henderson; +Cc: qemu-devel On Thu, 13 Jun 2019 at 05:24, Richard Henderson <richard.henderson@linaro.org> wrote: > > Dang it, forgot the PULL tag. > > > r~ > > > The following changes since commit a050901d4b40092dc356b59912c6df39e389c7b9: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190612' into > staging (2019-06-12 14:43:47 +0100) > > are available in the Git repository at: > > https://github.com/rth7680/qemu.git tags/pull-tcg-20190612 > > for you to fetch changes up to 899f08ad1d1231dbbfa67298413f05ed2679fb02: > > tcg: Fix typos in helper_gvec_sar{8,32,64}v (2019-06-12 21:08:38 -0700) > > ---------------------------------------------------------------- > Fix vector arithmetic right shift helpers. > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.1 for any user-visible changes. -- PMM ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-06-14 8:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-13 4:16 [Qemu-devel] [PATCH 0/1] tcg: queued patch Richard Henderson
2019-06-13 4:16 ` [Qemu-devel] [PATCH 1/1] tcg: Fix typos in helper_gvec_sar{8, 32, 64}v Richard Henderson
2019-06-14 5:22 ` Aleksandar Markovic
2019-06-14 6:03 ` Aleksandar Markovic
2019-06-14 6:09 ` Aleksandar Markovic
2019-06-14 8:33 ` Peter Maydell
2019-06-13 4:24 ` [Qemu-devel] [PULL 0/1] tcg: queued patch Richard Henderson
2019-06-13 12:24 ` Peter Maydell
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.