Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8.2

From: Peter Maydell <peter.maydell@linaro.org>
To: Michael Clark <mjc@sifive.com>
Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
	Palmer Dabbelt <palmer@sifive.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	RISC-V Patches <patches@groups.riscv.org>,
	Sagar Karandikar <sagark@eecs.berkeley.edu>
Subject: Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8.2
Date: Thu, 8 Mar 2018 11:19:30 +0000	[thread overview]
Message-ID: <CAFEAcA9xMj_Wq_mxJU-vhUDidUKk+UVtCNGeGK-Hx_bcqkjMug@mail.gmail.com> (raw)
In-Reply-To: <CAHNT7NtRnSB-GYHp=v3iM7+_72y43YpZesbYCrnTvCikTiUMuw@mail.gmail.com>

On 8 March 2018 at 11:10, Michael Clark <mjc@sifive.com> wrote:
>
> On Thu, 8 Mar 2018 at 11:02 PM, Peter Maydell <peter.maydell@linaro.org>
> wrote:
>>
>> On 6 March 2018 at 19:46, Michael Clark <mjc@sifive.com> wrote:
>> > -----BEGIN PGP SIGNED MESSAGE-----
>> > Hash: SHA1
>> >
>> > The following changes since commit
>> > f32408f3b472a088467474ab152be3b6285b2d7b:
>> >
>> >   misc: don't use hwaddr as a type in trace events (2018-03-06 14:24:30
>> > +0000)
>> >
>> > are available in the git repository at:
>> >
>> >   https://github.com/riscv/riscv-qemu.git tags/riscv-qemu-upstream-v8.2
>> >
>> > for you to fetch changes up to 7051b081bf6796e5e84406f6223a7c4900bf7298:
>> >
>> >   RISC-V - Remove support for adhoc non-standard X_COP local-interrupt
>> > (2018-03-07 08:36:03 +1300)
>>
>>
>> Hi -- I would have applied this, but some of the commits
>> have no signed-off-by lines.
>>
>> This is important, and I've already asked for it once. We cannot
>> accept anything that doesn't have a clear record in the commit
>> message of everybody (person or company) who's contributed code
>> to it, indicating that they're happy for their copyrighted
>> contributions to be taken into QEMU under our license. Lists
>> of names without emails in the cover letter are not sufficient.
>>
>> In fact a lot of the last part of this patchset looks like
>> unreviewed changes/fixes that if we were going to have them we
>> should have squashed into the correct patches and resent the
>> series for review. Please don't do this. Code review is an
>> important part of how the QEMU project works.
>
>
> You must be looking at the wrong tag. There are multiple sign-offs in all 23
> commits. The tag is riscv-qemu-upstream-v8.2. Sagar and Bastian contacted me
> out of band to add their sign-offs. Please look at the commits again and
> tell me which commit id doesn’t have a sign-off on that tag (23 commits
> iirc)

I'm looking at the one this email tells me to pull:
  https://github.com/riscv/riscv-qemu.git tags/riscv-qemu-upstream-v8.2
  changes up to 7051b081bf6796e5e84406f6223a7c4900bf7298

Commit 7051b081bf6796e5e84406f6223a7c4900bf7298,
9390ed5f4ca5fd3bde10ee2dcf4e7d915d1c189d,
b38548c4057fb670950a4b94efe5c03b8aba4118,
etc etc all have no signoff.

thanks
-- PHMM