* [PATCH] Fix scripts/checkpatch.py style failures.
@ 2023-08-05 12:51 Nathan Egge
2023-08-05 13:31 ` Michael Tokarev
2023-08-05 16:43 ` Michael Tokarev
0 siblings, 2 replies; 4+ messages in thread
From: Nathan Egge @ 2023-08-05 12:51 UTC (permalink / raw)
To: Richard Henderson; +Cc: Akihiko Odaki, Helge Deller, qemu-devel, Nathan Egge
From: "Nathan Egge" <negge@xiph.org>
Signed-off-by: Nathan Egge <negge@xiph.org>
---
linux-user/syscall.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 95727a816a..38ab2201e2 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -863,8 +863,8 @@ abi_long do_brk(abi_ulong brk_val)
if (new_host_brk_page > brk_page) {
new_alloc_size = new_host_brk_page - brk_page;
mapped_addr = get_errno(target_mmap(brk_page, new_alloc_size,
- PROT_READ|PROT_WRITE,
- MAP_ANON|MAP_PRIVATE, 0, 0));
+ PROT_READ | PROT_WRITE,
+ MAP_ANON | MAP_PRIVATE, 0, 0));
} else {
new_alloc_size = 0;
mapped_addr = brk_page;
@@ -6128,8 +6128,8 @@ static abi_long write_ldt(CPUX86State *env,
if (!ldt_table) {
env->ldt.base = target_mmap(0,
TARGET_LDT_ENTRIES * TARGET_LDT_ENTRY_SIZE,
- PROT_READ|PROT_WRITE,
- MAP_ANONYMOUS|MAP_PRIVATE, -1, 0);
+ PROT_READ | PROT_WRITE,
+ MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
if (env->ldt.base == -1)
return -TARGET_ENOMEM;
memset(g2h_untagged(env->ldt.base), 0,
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix scripts/checkpatch.py style failures.
2023-08-05 12:51 [PATCH] Fix scripts/checkpatch.py style failures Nathan Egge
@ 2023-08-05 13:31 ` Michael Tokarev
2023-08-05 16:43 ` Michael Tokarev
1 sibling, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2023-08-05 13:31 UTC (permalink / raw)
To: Nathan Egge, Richard Henderson
Cc: Akihiko Odaki, Helge Deller, qemu-devel, QEMU Trivial
Applied to my trivial-patches tree (for 8.2).
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix scripts/checkpatch.py style failures.
2023-08-05 12:51 [PATCH] Fix scripts/checkpatch.py style failures Nathan Egge
2023-08-05 13:31 ` Michael Tokarev
@ 2023-08-05 16:43 ` Michael Tokarev
2023-08-07 9:24 ` Peter Maydell
1 sibling, 1 reply; 4+ messages in thread
From: Michael Tokarev @ 2023-08-05 16:43 UTC (permalink / raw)
To: Nathan Egge, Richard Henderson; +Cc: Akihiko Odaki, Helge Deller, qemu-devel
05.08.2023 15:51, Nathan Egge пишет:
> From: "Nathan Egge" <negge@xiph.org>
>
> Signed-off-by: Nathan Egge <negge@xiph.org>
This needs at least some meaningful subject prefix.
With the subject like it is now, it feels like the
patch is about fixing checkpatch.py script itself.
Something like:
linux-user/syscall.c: fix coding-style issue (space-around-or)
I think one of the two places should be fixed in a
patch which touches this place in tcg-next series
instead of separately.
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix scripts/checkpatch.py style failures.
2023-08-05 16:43 ` Michael Tokarev
@ 2023-08-07 9:24 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2023-08-07 9:24 UTC (permalink / raw)
To: Michael Tokarev
Cc: Nathan Egge, Richard Henderson, Akihiko Odaki, Helge Deller, qemu-devel
On Sat, 5 Aug 2023 at 17:44, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> 05.08.2023 15:51, Nathan Egge пишет:
> > From: "Nathan Egge" <negge@xiph.org>
> >
> > Signed-off-by: Nathan Egge <negge@xiph.org>
>
> This needs at least some meaningful subject prefix.
> With the subject like it is now, it feels like the
> patch is about fixing checkpatch.py script itself.
>
> Something like:
>
> linux-user/syscall.c: fix coding-style issue (space-around-or)
>
> I think one of the two places should be fixed in a
> patch which touches this place in tcg-next series
> instead of separately.
Also, this specific area of code (brk handling) is currently
being worked on quite heavily. I'm pretty sure there's a patchset
on list which touches these specific lines of code (and might
well have fixed the style issue in passing). So we should hold
off on the purely coding-style fixes here until after the dust
has settled on those changes.
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-07 9:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-05 12:51 [PATCH] Fix scripts/checkpatch.py style failures Nathan Egge
2023-08-05 13:31 ` Michael Tokarev
2023-08-05 16:43 ` Michael Tokarev
2023-08-07 9:24 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.