* [PATCH] linux-user: Fix missing space in error message
@ 2022-03-10 19:21 Patrick Venture
2022-03-10 20:32 ` Peter Maydell
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Patrick Venture @ 2022-03-10 19:21 UTC (permalink / raw)
To: laurent; +Cc: qemu-devel, Fergus Henderson, Patrick Venture
From: Fergus Henderson <fergus@google.com>
Signed-off-by: Fergus Henderson <fergus@google.com>
Signed-off-by: Patrick Venture <venture@google.com>
---
linux-user/elfload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 9628a38361..c45da4d633 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -2504,7 +2504,7 @@ static void pgb_reserved_va(const char *image_name, abi_ulong guest_loaddr,
addr = mmap(test, reserved_va, PROT_NONE, flags, -1, 0);
if (addr == MAP_FAILED || addr != test) {
error_report("Unable to reserve 0x%lx bytes of virtual address "
- "space at %p (%s) for use as guest address space (check your"
+ "space at %p (%s) for use as guest address space (check your "
"virtual memory ulimit setting, min_mmap_addr or reserve less "
"using -R option)", reserved_va, test, strerror(errno));
exit(EXIT_FAILURE);
--
2.35.1.723.g4982287a31-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] linux-user: Fix missing space in error message
2022-03-10 19:21 [PATCH] linux-user: Fix missing space in error message Patrick Venture
@ 2022-03-10 20:32 ` Peter Maydell
2022-03-10 22:34 ` [PATCH-for-7.0] " Philippe Mathieu-Daudé
2022-03-22 11:34 ` [PATCH] " Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2022-03-10 20:32 UTC (permalink / raw)
To: Patrick Venture; +Cc: Fergus Henderson, Laurent, qemu-devel
On Thu, 10 Mar 2022 at 19:29, Patrick Venture <venture@google.com> wrote:
>
> From: Fergus Henderson <fergus@google.com>
>
> Signed-off-by: Fergus Henderson <fergus@google.com>
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH-for-7.0] linux-user: Fix missing space in error message
2022-03-10 19:21 [PATCH] linux-user: Fix missing space in error message Patrick Venture
2022-03-10 20:32 ` Peter Maydell
@ 2022-03-10 22:34 ` Philippe Mathieu-Daudé
2022-03-22 11:34 ` [PATCH] " Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-03-10 22:34 UTC (permalink / raw)
To: Patrick Venture, laurent; +Cc: Fergus Henderson, qemu-devel
On 10/3/22 20:21, Patrick Venture wrote:
> From: Fergus Henderson <fergus@google.com>
>
> Signed-off-by: Fergus Henderson <fergus@google.com>
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
> linux-user/elfload.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index 9628a38361..c45da4d633 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -2504,7 +2504,7 @@ static void pgb_reserved_va(const char *image_name, abi_ulong guest_loaddr,
> addr = mmap(test, reserved_va, PROT_NONE, flags, -1, 0);
> if (addr == MAP_FAILED || addr != test) {
> error_report("Unable to reserve 0x%lx bytes of virtual address "
> - "space at %p (%s) for use as guest address space (check your"
> + "space at %p (%s) for use as guest address space (check your "
> "virtual memory ulimit setting, min_mmap_addr or reserve less "
> "using -R option)", reserved_va, test, strerror(errno));
> exit(EXIT_FAILURE);
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] linux-user: Fix missing space in error message
2022-03-10 19:21 [PATCH] linux-user: Fix missing space in error message Patrick Venture
2022-03-10 20:32 ` Peter Maydell
2022-03-10 22:34 ` [PATCH-for-7.0] " Philippe Mathieu-Daudé
@ 2022-03-22 11:34 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2022-03-22 11:34 UTC (permalink / raw)
To: Patrick Venture; +Cc: Fergus Henderson, qemu-devel
Le 10/03/2022 à 20:21, Patrick Venture a écrit :
> From: Fergus Henderson <fergus@google.com>
>
> Signed-off-by: Fergus Henderson <fergus@google.com>
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
> linux-user/elfload.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index 9628a38361..c45da4d633 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -2504,7 +2504,7 @@ static void pgb_reserved_va(const char *image_name, abi_ulong guest_loaddr,
> addr = mmap(test, reserved_va, PROT_NONE, flags, -1, 0);
> if (addr == MAP_FAILED || addr != test) {
> error_report("Unable to reserve 0x%lx bytes of virtual address "
> - "space at %p (%s) for use as guest address space (check your"
> + "space at %p (%s) for use as guest address space (check your "
> "virtual memory ulimit setting, min_mmap_addr or reserve less "
> "using -R option)", reserved_va, test, strerror(errno));
> exit(EXIT_FAILURE);
Applied to my linux-user-for-7.0 branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-22 11:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-10 19:21 [PATCH] linux-user: Fix missing space in error message Patrick Venture
2022-03-10 20:32 ` Peter Maydell
2022-03-10 22:34 ` [PATCH-for-7.0] " Philippe Mathieu-Daudé
2022-03-22 11:34 ` [PATCH] " Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.