* [PULL 0/1] Fix qemu_strtosz regression
@ 2021-03-15 18:51 Richard Henderson
2021-03-15 18:51 ` [PULL 1/1] utils: Use fixed-point arithmetic in qemu_strtosz Richard Henderson
2021-03-17 9:06 ` [PULL 0/1] Fix qemu_strtosz regression Peter Maydell
0 siblings, 2 replies; 6+ messages in thread
From: Richard Henderson @ 2021-03-15 18:51 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
The following changes since commit 51204c2f188ec1e2a38f14718d38a3772f850a4b:
Merge remote-tracking branch 'remotes/bkoppelmann2/tags/pull-tricore-20210314' into staging (2021-03-15 15:34:27 +0000)
are available in the Git repository at:
https://gitlab.com/rth7680/qemu.git tags/pull-misc-20210315
for you to fetch changes up to 7625a1ed013a042748753750c9d9b1a33c9cd8e0:
utils: Use fixed-point arithmetic in qemu_strtosz (2021-03-15 12:47:08 -0600)
----------------------------------------------------------------
Fix qemu_strtosz testsuite failures for i686.
----------------------------------------------------------------
Richard Henderson (1):
utils: Use fixed-point arithmetic in qemu_strtosz
tests/unit/test-cutils.c | 2 +-
util/cutils.c | 50 +++++++++++++++++++++++++++++++++---------------
2 files changed, 36 insertions(+), 16 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PULL 1/1] utils: Use fixed-point arithmetic in qemu_strtosz
2021-03-15 18:51 [PULL 0/1] Fix qemu_strtosz regression Richard Henderson
@ 2021-03-15 18:51 ` Richard Henderson
2021-03-15 19:11 ` Eric Blake
2021-03-17 9:06 ` [PULL 0/1] Fix qemu_strtosz regression Peter Maydell
1 sibling, 1 reply; 6+ messages in thread
From: Richard Henderson @ 2021-03-15 18:51 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
Once we've parsed the fractional value, extract it into an integral
64-bit fraction. Perform the scaling with integer arithmetic, and
simplify the overflow detection.
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20210315155835.1970210-2-richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tests/unit/test-cutils.c | 2 +-
util/cutils.c | 50 ++++++++++++++++++++++++++++------------
2 files changed, 36 insertions(+), 16 deletions(-)
diff --git a/tests/unit/test-cutils.c b/tests/unit/test-cutils.c
index bad3a60993..e025b54c05 100644
--- a/tests/unit/test-cutils.c
+++ b/tests/unit/test-cutils.c
@@ -2128,7 +2128,7 @@ static void test_qemu_strtosz_float(void)
str = "12.345M";
err = qemu_strtosz(str, &endptr, &res);
g_assert_cmpint(err, ==, 0);
- g_assert_cmpint(res, ==, (uint64_t) (12.345 * MiB));
+ g_assert_cmpint(res, ==, (uint64_t) (12.345 * MiB + 0.5));
g_assert(endptr == str + 7);
}
diff --git a/util/cutils.c b/util/cutils.c
index d89a40a8c3..c442882b88 100644
--- a/util/cutils.c
+++ b/util/cutils.c
@@ -275,10 +275,9 @@ static int do_strtosz(const char *nptr, const char **end,
int retval;
const char *endptr, *f;
unsigned char c;
- bool mul_required = false, hex = false;
- uint64_t val;
+ bool hex = false;
+ uint64_t val, valf = 0;
int64_t mul;
- double fraction = 0.0;
/* Parse integral portion as decimal. */
retval = qemu_strtou64(nptr, &endptr, 10, &val);
@@ -308,17 +307,19 @@ static int do_strtosz(const char *nptr, const char **end,
* without fractional digits. If we see an exponent, treat
* the entire input as invalid instead.
*/
+ double fraction;
+
f = endptr;
retval = qemu_strtod_finite(f, &endptr, &fraction);
if (retval) {
- fraction = 0.0;
endptr++;
} else if (memchr(f, 'e', endptr - f) || memchr(f, 'E', endptr - f)) {
endptr = nptr;
retval = -EINVAL;
goto out;
- } else if (fraction != 0) {
- mul_required = true;
+ } else {
+ /* Extract into a 64-bit fixed-point fraction. */
+ valf = (uint64_t)(fraction * 0x1p64);
}
}
c = *endptr;
@@ -333,16 +334,35 @@ static int do_strtosz(const char *nptr, const char **end,
mul = suffix_mul(default_suffix, unit);
assert(mul > 0);
}
- if (mul == 1 && mul_required) {
- endptr = nptr;
- retval = -EINVAL;
- goto out;
+ if (mul == 1) {
+ /* When a fraction is present, a scale is required. */
+ if (valf != 0) {
+ endptr = nptr;
+ retval = -EINVAL;
+ goto out;
+ }
+ } else {
+ uint64_t valh, tmp;
+
+ /* Compute exact result: 64.64 x 64.0 -> 128.64 fixed point */
+ mulu64(&val, &valh, val, mul);
+ mulu64(&valf, &tmp, valf, mul);
+ val += tmp;
+ valh += val < tmp;
+
+ /* Round 0.5 upward. */
+ tmp = valf >> 63;
+ val += tmp;
+ valh += val < tmp;
+
+ /* Report overflow. */
+ if (valh != 0) {
+ retval = -ERANGE;
+ goto out;
+ }
}
- if (val > (UINT64_MAX - ((uint64_t) (fraction * mul))) / mul) {
- retval = -ERANGE;
- goto out;
- }
- *result = val * mul + (uint64_t) (fraction * mul);
+
+ *result = val;
retval = 0;
out:
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PULL 1/1] utils: Use fixed-point arithmetic in qemu_strtosz
2021-03-15 18:51 ` [PULL 1/1] utils: Use fixed-point arithmetic in qemu_strtosz Richard Henderson
@ 2021-03-15 19:11 ` Eric Blake
0 siblings, 0 replies; 6+ messages in thread
From: Eric Blake @ 2021-03-15 19:11 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: peter.maydell
On 3/15/21 1:51 PM, Richard Henderson wrote:
> Once we've parsed the fractional value, extract it into an integral
> 64-bit fraction. Perform the scaling with integer arithmetic, and
> simplify the overflow detection.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Message-Id: <20210315155835.1970210-2-richard.henderson@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
A bit late now that it's in a pull request, but adding
Fixes: cf923b783efd5 (utils: Improve qemu_strtosz() to have 64 bits of
precision)
would have been nice.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PULL 0/1] Fix qemu_strtosz regression
2021-03-15 18:51 [PULL 0/1] Fix qemu_strtosz regression Richard Henderson
2021-03-15 18:51 ` [PULL 1/1] utils: Use fixed-point arithmetic in qemu_strtosz Richard Henderson
@ 2021-03-17 9:06 ` Peter Maydell
1 sibling, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2021-03-17 9:06 UTC (permalink / raw)
To: Richard Henderson; +Cc: QEMU Developers
On Mon, 15 Mar 2021 at 18:51, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> The following changes since commit 51204c2f188ec1e2a38f14718d38a3772f850a4b:
>
> Merge remote-tracking branch 'remotes/bkoppelmann2/tags/pull-tricore-20210314' into staging (2021-03-15 15:34:27 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/rth7680/qemu.git tags/pull-misc-20210315
>
> for you to fetch changes up to 7625a1ed013a042748753750c9d9b1a33c9cd8e0:
>
> utils: Use fixed-point arithmetic in qemu_strtosz (2021-03-15 12:47:08 -0600)
>
> ----------------------------------------------------------------
> Fix qemu_strtosz testsuite failures for i686.
>
> ----------------------------------------------------------------
> Richard Henderson (1):
> utils: Use fixed-point arithmetic in qemu_strtosz
>
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PULL 0/1] Fix qemu_strtosz regression
2021-03-15 18:50 Richard Henderson
@ 2021-03-15 18:52 ` Richard Henderson
0 siblings, 0 replies; 6+ messages in thread
From: Richard Henderson @ 2021-03-15 18:52 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
On 3/15/21 12:50 PM, Richard Henderson wrote:
> The following changes since commit 51204c2f188ec1e2a38f14718d38a3772f850a4b:
>
> Merge remote-tracking branch 'remotes/bkoppelmann2/tags/pull-tricore-20210314' into staging (2021-03-15 15:34:27 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/rth7680/qemu.git tags/pull-misc-20210315
>
> for you to fetch changes up to 7625a1ed013a042748753750c9d9b1a33c9cd8e0:
>
> utils: Use fixed-point arithmetic in qemu_strtosz (2021-03-15 12:47:08 -0600)
>
> ----------------------------------------------------------------
> Fix qemu_strtosz testsuite failures for i686.
>
> ----------------------------------------------------------------
> Richard Henderson (1):
> utils: Use fixed-point arithmetic in qemu_strtosz
>
> tests/unit/test-cutils.c | 2 +-
> util/cutils.c | 50 +++++++++++++++++++++++++++++++++---------------
> 2 files changed, 36 insertions(+), 16 deletions(-)
>
Sorry for the duplicate. Misfire on the git send-email.
r~
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PULL 0/1] Fix qemu_strtosz regression
@ 2021-03-15 18:50 Richard Henderson
2021-03-15 18:52 ` Richard Henderson
0 siblings, 1 reply; 6+ messages in thread
From: Richard Henderson @ 2021-03-15 18:50 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
The following changes since commit 51204c2f188ec1e2a38f14718d38a3772f850a4b:
Merge remote-tracking branch 'remotes/bkoppelmann2/tags/pull-tricore-20210314' into staging (2021-03-15 15:34:27 +0000)
are available in the Git repository at:
https://gitlab.com/rth7680/qemu.git tags/pull-misc-20210315
for you to fetch changes up to 7625a1ed013a042748753750c9d9b1a33c9cd8e0:
utils: Use fixed-point arithmetic in qemu_strtosz (2021-03-15 12:47:08 -0600)
----------------------------------------------------------------
Fix qemu_strtosz testsuite failures for i686.
----------------------------------------------------------------
Richard Henderson (1):
utils: Use fixed-point arithmetic in qemu_strtosz
tests/unit/test-cutils.c | 2 +-
util/cutils.c | 50 +++++++++++++++++++++++++++++++++---------------
2 files changed, 36 insertions(+), 16 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-17 9:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-15 18:51 [PULL 0/1] Fix qemu_strtosz regression Richard Henderson
2021-03-15 18:51 ` [PULL 1/1] utils: Use fixed-point arithmetic in qemu_strtosz Richard Henderson
2021-03-15 19:11 ` Eric Blake
2021-03-17 9:06 ` [PULL 0/1] Fix qemu_strtosz regression Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2021-03-15 18:50 Richard Henderson
2021-03-15 18:52 ` Richard Henderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.