Re: [Qemu-devel] [Qemu-discuss] -serial option broken in master?

Re: [Qemu-devel] [Qemu-discuss] -serial option broken in master?

[Peter Maydell]

On 7 June 2016 at 15:47, Jérôme Forissier <jerome.forissier@linaro.org> wrote:
> Hi,
>
> I just noticed this error [1] (QEMU master branch):
>
> ../qemu/arm-softmmu/qemu-system-arm -nographic -monitor none -machine
> virt -machine secure=on -cpu cortex-a15 -m 1057 -serial stdio -serial
> file:serial1.log -bios
> /home/travis/optee_repo/build/../out/bios-qemu/bios.bin
> Unexpected error in parse_chr() at hw/core/qdev-properties-system.c:149:
> qemu-system-arm: Property 'pl011.chardev' can't take value 'serial0',
> it's in use
>
> FYI, revert commits e5fabad7ccfd ("char: get rid of
> qemu_char_get_next_serial") and f0d1d2c115df ("hw/char: QOM'ify pl011
> model"), and the problem disappears.
>
> Should I use a different syntax?

No, it's a bug that we broke this somehow. Xiaoqiang, could you
have a look at this, please?

thanks
-- PMM

Re: [Qemu-devel] [Qemu-discuss] -serial option broken in master?

[xiaoqiang zhao]

> 在 2016年6月8日，05:24，Peter Maydell <peter.maydell@linaro.org> 写道：
> 
>> On 7 June 2016 at 15:47, Jérôme Forissier <jerome.forissier@linaro.org> wrote:
>> Hi,
>> 
>> I just noticed this error [1] (QEMU master branch):
>> 
>> ../qemu/arm-softmmu/qemu-system-arm -nographic -monitor none -machine
>> virt -machine secure=on -cpu cortex-a15 -m 1057 -serial stdio -serial
>> file:serial1.log -bios
>> /home/travis/optee_repo/build/../out/bios-qemu/bios.bin
>> Unexpected error in parse_chr() at hw/core/qdev-properties-system.c:149:
>> qemu-system-arm: Property 'pl011.chardev' can't take value 'serial0',
>> it's in use
>> 
>> FYI, revert commits e5fabad7ccfd ("char: get rid of
>> qemu_char_get_next_serial") and f0d1d2c115df ("hw/char: QOM'ify pl011
>> model"), and the problem disappears.
>> 
>> Should I use a different syntax?
> 
> No, it's a bug that we broke this somehow. Xiaoqiang, could you
> have a look at this, please?
> 
> thanks
> -- PMM
> 
Okay！

Re: [Qemu-devel] [Qemu-discuss] -serial option broken in master?

[xiaoqiang zhao]

在 2016年06月08日 05:24, Peter Maydell 写道:
> On 7 June 2016 at 15:47, Jérôme Forissier <jerome.forissier@linaro.org> wrote:
>> Hi,
>>
>> I just noticed this error [1] (QEMU master branch):
>>
>> ../qemu/arm-softmmu/qemu-system-arm -nographic -monitor none -machine
>> virt -machine secure=on -cpu cortex-a15 -m 1057 -serial stdio -serial
>> file:serial1.log -bios
>> /home/travis/optee_repo/build/../out/bios-qemu/bios.bin
>> Unexpected error in parse_chr() at hw/core/qdev-properties-system.c:149:
>> qemu-system-arm: Property 'pl011.chardev' can't take value 'serial0',
>> it's in use
>>
>> FYI, revert commits e5fabad7ccfd ("char: get rid of
>> qemu_char_get_next_serial") and f0d1d2c115df ("hw/char: QOM'ify pl011
>> model"), and the problem disappears.
>>
>> Should I use a different syntax?
> No, it's a bug that we broke this somehow. Xiaoqiang, could you
> have a look at this, please?
>
> thanks
> -- PMM
Hi, peter:
  The bug was caught. It is because in vrit.c, create_uart is called 
twice, in which serial_hds array is hardcoded.
  I will send a patch to fix this later .