All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Aurelien Jarno <aurelien@aurel32.net>,
	Leon Alrae <leon.alrae@imgtec.com>,
	Petar Jovanovic <petar.jovanovic@imgtec.com>,
	Miodrag Dinic <miodrag.dinic@imgtec.com>,
	Aleksandar Markovic <aleksandar.markovic@imgtec.com>
Subject: Re: [Qemu-devel] [PATCH v9 04/10] softfloat: For Mips only, correct order in pickNaNMulAdd()
Date: Thu, 23 Jun 2016 16:38:51 +0100	[thread overview]
Message-ID: <CAFEAcA_kJ8WScA2fSZsCsUozMsi+iGVeAfeX=-grpuzquxovZw@mail.gmail.com> (raw)
In-Reply-To: <1465552668-30084-5-git-send-email-aleksandar.markovic@rt-rk.com>

On 10 June 2016 at 10:57, Aleksandar Markovic
<aleksandar.markovic@rt-rk.com> wrote:
> From: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
>
> Only for Mips platform, and only for cases when snan_bit_is_one is 0,
> correct the order of argument comparisons in pickNaNMulAdd().
>
> For more info, see [1], page 53, section "3.5.3 NaN Propagation".
>
> [1] "MIPS Architecture for Programmers Volume IV-j:
>     The MIPS32 SIMD Architecture Module",
>     Imagination Technologies LTD, Revision 1.12, February 3, 2016
>
> Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>
> Signed-off-by: Aleksandar Markovic <aleksandar.markovic@imgtec.com>

I think the subject line of this commit message would be a little
clearer as
  softfloat: Handle snan_bit_is_one == 0 in MIPS pickNaNMulAdd()

Otherwise:
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

  reply	other threads:[~2016-06-23 15:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10  9:57 [Qemu-devel] [PATCH v9 00/10] IEEE 754-2008 support for Mips Aleksandar Markovic
2016-06-10  9:57 ` [Qemu-devel] [PATCH v9 01/10] softfloat: Implement run-time-configurable meaning of signaling NaN bit Aleksandar Markovic
2016-06-14 14:07   ` Leon Alrae
2016-06-23 15:30   ` Peter Maydell
2016-06-10  9:57 ` [Qemu-devel] [PATCH v9 02/10] softfloat: Clean code format in fpu/softfloat-specialize.h Aleksandar Markovic
2016-06-23 15:31   ` Peter Maydell
2016-06-10  9:57 ` [Qemu-devel] [PATCH v9 03/10] softfloat: For Mips only, correct default NaN values Aleksandar Markovic
2016-06-23 15:36   ` Peter Maydell
2016-06-10  9:57 ` [Qemu-devel] [PATCH v9 04/10] softfloat: For Mips only, correct order in pickNaNMulAdd() Aleksandar Markovic
2016-06-23 15:38   ` Peter Maydell [this message]
2016-06-10  9:57 ` [Qemu-devel] [PATCH v9 05/10] linux-user: Update preprocessor constants for Mips-specific e_flags bits Aleksandar Markovic
2016-06-23 15:40   ` Peter Maydell
2016-06-10  9:57 ` [Qemu-devel] [PATCH v9 06/10] target-mips: Activate IEEE 754-2008 signaling NaN bit meaning for MSA Aleksandar Markovic
2016-06-10  9:57 ` [Qemu-devel] [PATCH v9 07/10] target-mips: Add abs2008 flavor of <ABS|NEG>.<S|D> Aleksandar Markovic
2016-06-10  9:57 ` [Qemu-devel] [PATCH v9 08/10] target-mips: Add nan2008 flavor of <CEIL|CVT|FLOOR|ROUND|TRUNC>.<L|W>.<S|D> Aleksandar Markovic
2016-06-10  9:57 ` [Qemu-devel] [PATCH v9 09/10] target-mips: Implement FCR31's R/W bitmask and related functionalities Aleksandar Markovic
2016-06-14 14:08   ` Leon Alrae
2016-06-10  9:57 ` [Qemu-devel] [PATCH v9 10/10] target-mips: Add FCR31's FS bit definition Aleksandar Markovic
2016-06-14 14:12   ` Leon Alrae
2016-06-21 12:41 ` [Qemu-devel] [PATCH v9 00/10] IEEE 754-2008 support for Mips Aleksandar Markovic
2016-06-23 15:46 ` Peter Maydell
2016-06-23 16:44   ` Leon Alrae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA_kJ8WScA2fSZsCsUozMsi+iGVeAfeX=-grpuzquxovZw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=aleksandar.markovic@imgtec.com \
    --cc=aleksandar.markovic@rt-rk.com \
    --cc=aurelien@aurel32.net \
    --cc=leon.alrae@imgtec.com \
    --cc=miodrag.dinic@imgtec.com \
    --cc=petar.jovanovic@imgtec.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.