* [PATCH v3] hw/arm/Kconfig: no need to enable ACPI_MEMORY_HOTPLUG/ACPI_NVDIMM explicitly
@ 2021-08-19 16:26 Ani Sinha
2021-08-26 13:20 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Ani Sinha @ 2021-08-19 16:26 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, mst, shameerali.kolothum.thodi, qemu-arm,
Ani Sinha, imammedo, philmd
Since commit
36b79e3219d ("hw/acpi/Kconfig: Add missing Kconfig dependencies (build error)"),
ACPI_MEMORY_HOTPLUG and ACPI_NVDIMM is implicitly turned on when
ACPI_HW_REDUCED is selected. ACPI_HW_REDUCED is already enabled. No need to
turn on ACPI_MEMORY_HOTPLUG or ACPI_NVDIMM explicitly. This is a minor cleanup.
Signed-off-by: Ani Sinha <ani@anisinha.ca>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/arm/Kconfig | 2 --
1 file changed, 2 deletions(-)
changelog:
v1: initial patch
v2: commit log updated and ACPI_NVDIMM also removed from config.
v3: added missing parenthesis in commit message.
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 4ba0aca067..dc050b5c37 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -25,9 +25,7 @@ config ARM_VIRT
select ACPI_PCI
select MEM_DEVICE
select DIMM
- select ACPI_MEMORY_HOTPLUG
select ACPI_HW_REDUCED
- select ACPI_NVDIMM
select ACPI_APEI
config CHEETAH
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] hw/arm/Kconfig: no need to enable ACPI_MEMORY_HOTPLUG/ACPI_NVDIMM explicitly
2021-08-19 16:26 [PATCH v3] hw/arm/Kconfig: no need to enable ACPI_MEMORY_HOTPLUG/ACPI_NVDIMM explicitly Ani Sinha
@ 2021-08-26 13:20 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2021-08-26 13:20 UTC (permalink / raw)
To: Ani Sinha
Cc: Michael S. Tsirkin, QEMU Developers, Shameerali Kolothum Thodi,
qemu-arm, Igor Mammedov, Philippe Mathieu-Daudé
On Thu, 19 Aug 2021 at 17:26, Ani Sinha <ani@anisinha.ca> wrote:
>
> Since commit
> 36b79e3219d ("hw/acpi/Kconfig: Add missing Kconfig dependencies (build error)"),
> ACPI_MEMORY_HOTPLUG and ACPI_NVDIMM is implicitly turned on when
> ACPI_HW_REDUCED is selected. ACPI_HW_REDUCED is already enabled. No need to
> turn on ACPI_MEMORY_HOTPLUG or ACPI_NVDIMM explicitly. This is a minor cleanup.
>
> Signed-off-by: Ani Sinha <ani@anisinha.ca>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-26 13:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-19 16:26 [PATCH v3] hw/arm/Kconfig: no need to enable ACPI_MEMORY_HOTPLUG/ACPI_NVDIMM explicitly Ani Sinha
2021-08-26 13:20 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.