All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: lsoaresp@redhat.com, marcandre.lureau@gmail.com,
	qemu-devel@nongnu.org, peterx@redhat.com, quintela@redhat.com
Subject: Re: [PATCH v2 2/3] migration: Add canary to VMSTATE_END_OF_LIST
Date: Thu, 13 Jan 2022 20:41:39 +0000	[thread overview]
Message-ID: <CAFEAcA_ueCNVPukWPUksXAYBSg25hgO7UaqJ4v8vqc=Q57Zr7w@mail.gmail.com> (raw)
In-Reply-To: <20220113194452.254011-3-dgilbert@redhat.com>

On Thu, 13 Jan 2022 at 19:45, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
>
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> We fairly regularly forget VMSTATE_END_OF_LIST markers off descriptions;
> given that the current check is only for ->name being NULL, sometimes
> we get unlucky and the code apparently works and no one spots the error.
>
> Explicitly add a flag, VMS_END that should be set, and assert it is
> set during the traversal.
>
> Note: This can't go in until we update the copy of vmstate.h in slirp.
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM


  reply	other threads:[~2022-01-13 20:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13 19:44 [PATCH v2 0/3] vmsd checks Dr. David Alan Gilbert (git)
2022-01-13 19:44 ` [PATCH v2 1/3] ppc: Fix vmstate_pbr403 subsection name Dr. David Alan Gilbert (git)
2022-01-13 20:43   ` Peter Maydell
2022-01-17  9:53     ` Dr. David Alan Gilbert
2022-01-26 20:51   ` Juan Quintela
2022-01-13 19:44 ` [PATCH v2 2/3] migration: Add canary to VMSTATE_END_OF_LIST Dr. David Alan Gilbert (git)
2022-01-13 20:41   ` Peter Maydell [this message]
2022-01-14 11:32   ` Philippe Mathieu-Daudé via
2022-01-14 15:35     ` Philippe Mathieu-Daudé via
2022-01-13 19:44 ` [PATCH v2 3/3] migration: Perform vmsd structure check during tests Dr. David Alan Gilbert (git)
2022-01-13 20:42   ` Peter Maydell
2022-01-26 20:53   ` Juan Quintela
2022-01-27 15:49     ` Dr. David Alan Gilbert
2022-01-31  9:00       ` Juan Quintela
2022-02-02 11:32         ` Dr. David Alan Gilbert
2022-02-02 13:09           ` Juan Quintela
2022-02-02 13:52           ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA_ueCNVPukWPUksXAYBSg25hgO7UaqJ4v8vqc=Q57Zr7w@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=dgilbert@redhat.com \
    --cc=lsoaresp@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.