All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: lsoaresp@redhat.com, marcandre.lureau@gmail.com,
	qemu-devel@nongnu.org, peterx@redhat.com, quintela@redhat.com
Subject: Re: [PATCH v2 1/3] ppc: Fix vmstate_pbr403 subsection name
Date: Mon, 17 Jan 2022 09:53:53 +0000	[thread overview]
Message-ID: <YeU8scwJWgWSjirg@work-vm> (raw)
In-Reply-To: <CAFEAcA80kZMYZkOpw8mka+skyMyq4W_pLUeYg_1D2MJUGYLUJQ@mail.gmail.com>

* Peter Maydell (peter.maydell@linaro.org) wrote:
> On Thu, 13 Jan 2022 at 19:45, Dr. David Alan Gilbert (git)
> <dgilbert@redhat.com> wrote:
> >
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > The pbr403 subsection is part of the tlb6xx state, so I believe it's
> > name needs to be:
> >
> >     .name = "cpu/tlb6xx/pbr403",
> >
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > ---
> >  target/ppc/machine.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/target/ppc/machine.c b/target/ppc/machine.c
> > index 756d8de5d8..e535edb7c4 100644
> > --- a/target/ppc/machine.c
> > +++ b/target/ppc/machine.c
> > @@ -718,7 +718,7 @@ static bool pbr403_needed(void *opaque)
> >  }
> >
> >  static const VMStateDescription vmstate_pbr403 = {
> > -    .name = "cpu/pbr403",
> > +    .name = "cpu/tlb6xx/pbr403",
> >      .version_id = 1,
> >      .minimum_version_id = 1,
> >      .needed = pbr403_needed,
> > --
> > 2.34.1
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Actually, we'll drop this one; Cédric Le Goater has just published
'target/ppc: Finish removal of 401/403 CPUs' that kills this code off.

Dave

> thanks
> -- PMM
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK



  reply	other threads:[~2022-01-17  9:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13 19:44 [PATCH v2 0/3] vmsd checks Dr. David Alan Gilbert (git)
2022-01-13 19:44 ` [PATCH v2 1/3] ppc: Fix vmstate_pbr403 subsection name Dr. David Alan Gilbert (git)
2022-01-13 20:43   ` Peter Maydell
2022-01-17  9:53     ` Dr. David Alan Gilbert [this message]
2022-01-26 20:51   ` Juan Quintela
2022-01-13 19:44 ` [PATCH v2 2/3] migration: Add canary to VMSTATE_END_OF_LIST Dr. David Alan Gilbert (git)
2022-01-13 20:41   ` Peter Maydell
2022-01-14 11:32   ` Philippe Mathieu-Daudé via
2022-01-14 15:35     ` Philippe Mathieu-Daudé via
2022-01-13 19:44 ` [PATCH v2 3/3] migration: Perform vmsd structure check during tests Dr. David Alan Gilbert (git)
2022-01-13 20:42   ` Peter Maydell
2022-01-26 20:53   ` Juan Quintela
2022-01-27 15:49     ` Dr. David Alan Gilbert
2022-01-31  9:00       ` Juan Quintela
2022-02-02 11:32         ` Dr. David Alan Gilbert
2022-02-02 13:09           ` Juan Quintela
2022-02-02 13:52           ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YeU8scwJWgWSjirg@work-vm \
    --to=dgilbert@redhat.com \
    --cc=lsoaresp@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.