All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guodong Xu <guodong.xu@linaro.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Wei Xu <xuwei5@hisilicon.com>,
	Rob Herring <rob.herring@linaro.org>,
	Fathi Boudra <fathi.boudra@linaro.org>,
	John Stultz <john.stultz@linaro.org>,
	Xinliang Liu <xinliang.liu@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH] arm64: dts: hikey: extend default cma size to 128MB
Date: Thu, 25 Aug 2016 10:02:31 +0800	[thread overview]
Message-ID: <CAFGCpxwQLhADWH9aZufgX8YhPF2T-63ZPv1GB6gK8w1dzTzN4w@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqJxE+fAbSsp=N7dvzvQiKwh3nM8-oSJH1OzV+KfW3w4jw@mail.gmail.com>

On 24 August 2016 at 23:10, Rob Herring <robh+dt@kernel.org> wrote:
> On Wed, Aug 24, 2016 at 8:35 AM, Guodong Xu <guodong.xu@linaro.org> wrote:
>> To support display in Debian on HiKey, cma heap is used to allocate
>> graphic buffers. The default size of CMA is 16 MB which is not enought.
>
> s/enought/enough/
>
>>
>> Increase the default CMA size to 128 MB.
>>
>> cc: Rob Herring <rob.herring@linaro.org>
>> cc: Fathi Boudra <fathi.boudra@linaro.org>
>> cc: John Stultz <john.stultz@linaro.org>
>> cc: Xinliang Liu <xinliang.liu@linaro.org>
>> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
>> ---
>>  arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> index 4a51058..abb3434 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> @@ -45,6 +45,20 @@
>>                       <0x00000000 0x22000000 0x00000000 0x1c000000>;
>>         };
>>
>> +       reserved-memory {
>> +               #address-cells = <2>;
>> +               #size-cells = <2>;
>> +               ranges;
>> +
>> +               /* global autoconfigured region for contiguous allocations */
>> +               linux,cma {
>> +                       compatible = "shared-dma-pool";
>> +                       reusable;
>> +                       size = <0x00000000 0x08000000>;
>> +                       linux,cma-default;
>> +               };
>> +       };
>> +
>>         pstore: pstore@0x21f00000 {
>
> So what is upstream (as of 4.8) for ramoops also uses reserved-memory,
> so you should separately fix this.
>

Got it. I will fix and resend.

> Acked-by: Rob Herring <robh@kernel.org>
>

Thanks.
-Guodong


> Rob

WARNING: multiple messages have this Message-ID (diff)
From: Guodong Xu <guodong.xu@linaro.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <rob.herring@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Xinliang Liu <xinliang.liu@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Wei Xu <xuwei5@hisilicon.com>,
	John Stultz <john.stultz@linaro.org>,
	Fathi Boudra <fathi.boudra@linaro.org>,
	Thierry Reding <treding@nvidia.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: hikey: extend default cma size to 128MB
Date: Thu, 25 Aug 2016 10:02:31 +0800	[thread overview]
Message-ID: <CAFGCpxwQLhADWH9aZufgX8YhPF2T-63ZPv1GB6gK8w1dzTzN4w@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqJxE+fAbSsp=N7dvzvQiKwh3nM8-oSJH1OzV+KfW3w4jw@mail.gmail.com>

On 24 August 2016 at 23:10, Rob Herring <robh+dt@kernel.org> wrote:
> On Wed, Aug 24, 2016 at 8:35 AM, Guodong Xu <guodong.xu@linaro.org> wrote:
>> To support display in Debian on HiKey, cma heap is used to allocate
>> graphic buffers. The default size of CMA is 16 MB which is not enought.
>
> s/enought/enough/
>
>>
>> Increase the default CMA size to 128 MB.
>>
>> cc: Rob Herring <rob.herring@linaro.org>
>> cc: Fathi Boudra <fathi.boudra@linaro.org>
>> cc: John Stultz <john.stultz@linaro.org>
>> cc: Xinliang Liu <xinliang.liu@linaro.org>
>> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
>> ---
>>  arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> index 4a51058..abb3434 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> @@ -45,6 +45,20 @@
>>                       <0x00000000 0x22000000 0x00000000 0x1c000000>;
>>         };
>>
>> +       reserved-memory {
>> +               #address-cells = <2>;
>> +               #size-cells = <2>;
>> +               ranges;
>> +
>> +               /* global autoconfigured region for contiguous allocations */
>> +               linux,cma {
>> +                       compatible = "shared-dma-pool";
>> +                       reusable;
>> +                       size = <0x00000000 0x08000000>;
>> +                       linux,cma-default;
>> +               };
>> +       };
>> +
>>         pstore: pstore@0x21f00000 {
>
> So what is upstream (as of 4.8) for ramoops also uses reserved-memory,
> so you should separately fix this.
>

Got it. I will fix and resend.

> Acked-by: Rob Herring <robh@kernel.org>
>

Thanks.
-Guodong


> Rob

WARNING: multiple messages have this Message-ID (diff)
From: guodong.xu@linaro.org (Guodong Xu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: hikey: extend default cma size to 128MB
Date: Thu, 25 Aug 2016 10:02:31 +0800	[thread overview]
Message-ID: <CAFGCpxwQLhADWH9aZufgX8YhPF2T-63ZPv1GB6gK8w1dzTzN4w@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqJxE+fAbSsp=N7dvzvQiKwh3nM8-oSJH1OzV+KfW3w4jw@mail.gmail.com>

On 24 August 2016 at 23:10, Rob Herring <robh+dt@kernel.org> wrote:
> On Wed, Aug 24, 2016 at 8:35 AM, Guodong Xu <guodong.xu@linaro.org> wrote:
>> To support display in Debian on HiKey, cma heap is used to allocate
>> graphic buffers. The default size of CMA is 16 MB which is not enought.
>
> s/enought/enough/
>
>>
>> Increase the default CMA size to 128 MB.
>>
>> cc: Rob Herring <rob.herring@linaro.org>
>> cc: Fathi Boudra <fathi.boudra@linaro.org>
>> cc: John Stultz <john.stultz@linaro.org>
>> cc: Xinliang Liu <xinliang.liu@linaro.org>
>> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
>> ---
>>  arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> index 4a51058..abb3434 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> @@ -45,6 +45,20 @@
>>                       <0x00000000 0x22000000 0x00000000 0x1c000000>;
>>         };
>>
>> +       reserved-memory {
>> +               #address-cells = <2>;
>> +               #size-cells = <2>;
>> +               ranges;
>> +
>> +               /* global autoconfigured region for contiguous allocations */
>> +               linux,cma {
>> +                       compatible = "shared-dma-pool";
>> +                       reusable;
>> +                       size = <0x00000000 0x08000000>;
>> +                       linux,cma-default;
>> +               };
>> +       };
>> +
>>         pstore: pstore at 0x21f00000 {
>
> So what is upstream (as of 4.8) for ramoops also uses reserved-memory,
> so you should separately fix this.
>

Got it. I will fix and resend.

> Acked-by: Rob Herring <robh@kernel.org>
>

Thanks.
-Guodong


> Rob

  reply	other threads:[~2016-08-25  5:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24 13:35 [PATCH] arm64: dts: hikey: extend default cma size to 128MB Guodong Xu
2016-08-24 13:35 ` Guodong Xu
2016-08-24 15:10 ` Rob Herring
2016-08-24 15:10   ` Rob Herring
2016-08-24 15:10   ` Rob Herring
2016-08-25  2:02   ` Guodong Xu [this message]
2016-08-25  2:02     ` Guodong Xu
2016-08-25  2:02     ` Guodong Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFGCpxwQLhADWH9aZufgX8YhPF2T-63ZPv1GB6gK8w1dzTzN4w@mail.gmail.com \
    --to=guodong.xu@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fathi.boudra@linaro.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rob.herring@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=treding@nvidia.com \
    --cc=will.deacon@arm.com \
    --cc=xinliang.liu@linaro.org \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.