All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI
@ 2016-06-20  3:59 Xinliang Liu
  2016-06-21 13:34 ` Thierry Reding
  0 siblings, 1 reply; 9+ messages in thread
From: Xinliang Liu @ 2016-06-20  3:59 UTC (permalink / raw)
  To: dri-devel; +Cc: Zoltan Kuscsik, guodong.xu

From: Guodong Xu <guodong.xu@linaro.org>

Add select HISI_KIRIN_DW_DSI to Kconfig.
The DRM driver depends on dsi sub-driver.

Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
---
 drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/hisilicon/kirin/Kconfig b/drivers/gpu/drm/hisilicon/kirin/Kconfig
index ea0df6115f7e..499f64405dac 100644
--- a/drivers/gpu/drm/hisilicon/kirin/Kconfig
+++ b/drivers/gpu/drm/hisilicon/kirin/Kconfig
@@ -4,6 +4,7 @@ config DRM_HISI_KIRIN
 	select DRM_KMS_HELPER
 	select DRM_GEM_CMA_HELPER
 	select DRM_KMS_CMA_HELPER
+	select HISI_KIRIN_DW_DSI
 	help
 	  Choose this option if you have a hisilicon Kirin chipsets(hi6220).
 	  If M is selected the module will be called kirin-drm.
-- 
2.8.3

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI
  2016-06-20  3:59 [PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI Xinliang Liu
@ 2016-06-21 13:34 ` Thierry Reding
  2016-06-22  0:54   ` Guodong Xu
  2016-06-22  2:34   ` Xinliang Liu
  0 siblings, 2 replies; 9+ messages in thread
From: Thierry Reding @ 2016-06-21 13:34 UTC (permalink / raw)
  To: Xinliang Liu; +Cc: Zoltan Kuscsik, guodong.xu, dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 581 bytes --]

On Mon, Jun 20, 2016 at 11:59:03AM +0800, Xinliang Liu wrote:
> From: Guodong Xu <guodong.xu@linaro.org>
> 
> Add select HISI_KIRIN_DW_DSI to Kconfig.
> The DRM driver depends on dsi sub-driver.
> 
> Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
> ---
>  drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

You've got the Signed-off-by area messed up. If Guodong wrote this patch
that his Signed-off-by needs to be added. Your Signed-off by should also
be added because you forwarded the patch to the mailing list.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI
  2016-06-21 13:34 ` Thierry Reding
@ 2016-06-22  0:54   ` Guodong Xu
  2016-06-22  2:35     ` Xinliang Liu
  2016-06-22 12:59     ` Thierry Reding
  2016-06-22  2:34   ` Xinliang Liu
  1 sibling, 2 replies; 9+ messages in thread
From: Guodong Xu @ 2016-06-22  0:54 UTC (permalink / raw)
  To: Thierry Reding; +Cc: Zoltan Kuscsik, dri-devel

On 21 June 2016 at 21:34, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Mon, Jun 20, 2016 at 11:59:03AM +0800, Xinliang Liu wrote:
>> From: Guodong Xu <guodong.xu@linaro.org>
>>
>> Add select HISI_KIRIN_DW_DSI to Kconfig.
>> The DRM driver depends on dsi sub-driver.
>>
>> Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
>> ---
>>  drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>
> You've got the Signed-off-by area messed up. If Guodong wrote this patch

Hi, Xinliang,

To clarify this, you don't need my Signed-off. Zoltan is the author,
and I am just the person who ever integrated that patch into my local
tree.

-Guodong

> that his Signed-off-by needs to be added. Your Signed-off by should also
> be added because you forwarded the patch to the mailing list.
>
> Thierry
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI
  2016-06-21 13:34 ` Thierry Reding
  2016-06-22  0:54   ` Guodong Xu
@ 2016-06-22  2:34   ` Xinliang Liu
  1 sibling, 0 replies; 9+ messages in thread
From: Xinliang Liu @ 2016-06-22  2:34 UTC (permalink / raw)
  To: Thierry Reding; +Cc: Zoltan Kuscsik, Guodong Xu, dri-devel

Hi,

On 21 June 2016 at 21:34, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Mon, Jun 20, 2016 at 11:59:03AM +0800, Xinliang Liu wrote:
>> From: Guodong Xu <guodong.xu@linaro.org>
>>
>> Add select HISI_KIRIN_DW_DSI to Kconfig.
>> The DRM driver depends on dsi sub-driver.
>>
>> Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
>> ---
>>  drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>
> You've got the Signed-off-by area messed up. If Guodong wrote this patch
> that his Signed-off-by needs to be added. Your Signed-off by should also
> be added because you forwarded the patch to the mailing list.

Thierry, yes, you are right. I should add a Signed-off-by in the patch.

Thanks,
-xinliang

>
> Thierry
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI
  2016-06-22  0:54   ` Guodong Xu
@ 2016-06-22  2:35     ` Xinliang Liu
  2016-06-22 12:59     ` Thierry Reding
  1 sibling, 0 replies; 9+ messages in thread
From: Xinliang Liu @ 2016-06-22  2:35 UTC (permalink / raw)
  To: Guodong Xu; +Cc: Zoltan Kuscsik, dri-devel

On 22 June 2016 at 08:54, Guodong Xu <guodong.xu@linaro.org> wrote:
> On 21 June 2016 at 21:34, Thierry Reding <thierry.reding@gmail.com> wrote:
>> On Mon, Jun 20, 2016 at 11:59:03AM +0800, Xinliang Liu wrote:
>>> From: Guodong Xu <guodong.xu@linaro.org>
>>>
>>> Add select HISI_KIRIN_DW_DSI to Kconfig.
>>> The DRM driver depends on dsi sub-driver.
>>>
>>> Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
>>> ---
>>>  drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>> You've got the Signed-off-by area messed up. If Guodong wrote this patch
>
> Hi, Xinliang,
>
> To clarify this, you don't need my Signed-off. Zoltan is the author,
> and I am just the person who ever integrated that patch into my local
> tree.

OK, Guodong.
Thanks,
-xinliang

>
> -Guodong
>
>> that his Signed-off-by needs to be added. Your Signed-off by should also
>> be added because you forwarded the patch to the mailing list.
>>
>> Thierry
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI
  2016-06-22  0:54   ` Guodong Xu
  2016-06-22  2:35     ` Xinliang Liu
@ 2016-06-22 12:59     ` Thierry Reding
  2016-06-29  9:08       ` Xinliang Liu
  1 sibling, 1 reply; 9+ messages in thread
From: Thierry Reding @ 2016-06-22 12:59 UTC (permalink / raw)
  To: Guodong Xu; +Cc: Zoltan Kuscsik, dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 1031 bytes --]

On Wed, Jun 22, 2016 at 08:54:02AM +0800, Guodong Xu wrote:
> On 21 June 2016 at 21:34, Thierry Reding <thierry.reding@gmail.com> wrote:
> > On Mon, Jun 20, 2016 at 11:59:03AM +0800, Xinliang Liu wrote:
> >> From: Guodong Xu <guodong.xu@linaro.org>
> >>
> >> Add select HISI_KIRIN_DW_DSI to Kconfig.
> >> The DRM driver depends on dsi sub-driver.
> >>
> >> Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
> >> ---
> >>  drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
> >>  1 file changed, 1 insertion(+)
> >
> > You've got the Signed-off-by area messed up. If Guodong wrote this patch
> 
> Hi, Xinliang,
> 
> To clarify this, you don't need my Signed-off. Zoltan is the author,
> and I am just the person who ever integrated that patch into my local
> tree.

If Zoltan is the author, then his name should be in the From: line
above. As it is, git am will apply this with you as author. Also, see
section 11) in Documentation/SubmittingPatches on why you need to add
your S-o-b as well.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI
  2016-06-22 12:59     ` Thierry Reding
@ 2016-06-29  9:08       ` Xinliang Liu
  0 siblings, 0 replies; 9+ messages in thread
From: Xinliang Liu @ 2016-06-29  9:08 UTC (permalink / raw)
  To: Thierry Reding; +Cc: Zoltan Kuscsik, dri-devel, Guodong Xu

Hi,

On 22 June 2016 at 20:59, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Wed, Jun 22, 2016 at 08:54:02AM +0800, Guodong Xu wrote:
>> On 21 June 2016 at 21:34, Thierry Reding <thierry.reding@gmail.com> wrote:
>> > On Mon, Jun 20, 2016 at 11:59:03AM +0800, Xinliang Liu wrote:
>> >> From: Guodong Xu <guodong.xu@linaro.org>
>> >>
>> >> Add select HISI_KIRIN_DW_DSI to Kconfig.
>> >> The DRM driver depends on dsi sub-driver.
>> >>
>> >> Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
>> >> ---
>> >>  drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
>> >>  1 file changed, 1 insertion(+)
>> >
>> > You've got the Signed-off-by area messed up. If Guodong wrote this patch
>>
>> Hi, Xinliang,
>>
>> To clarify this, you don't need my Signed-off. Zoltan is the author,
>> and I am just the person who ever integrated that patch into my local
>> tree.
>
> If Zoltan is the author, then his name should be in the From: line
> above. As it is, git am will apply this with you as author. Also, see
> section 11) in Documentation/SubmittingPatches on why you need to add
> your S-o-b as well.

Thierry, that's right. I will resent the patch in the author of zoltan
and adding my s-o-b.

Thanks,
-xinliang

>
> Thierry
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI
@ 2016-06-29 10:18 Zoltan Kuscsik
  0 siblings, 0 replies; 9+ messages in thread
From: Zoltan Kuscsik @ 2016-06-29 10:18 UTC (permalink / raw)
  To: dri-devel; +Cc: Zoltan Kuscsik

 Add select HISI_KIRIN_DW_DSI to Kconfig.
 The DRM driver depends on dsi sub-driver.

Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
---
 drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/hisilicon/kirin/Kconfig b/drivers/gpu/drm/hisilicon/kirin/Kconfig
index ea0df61..499f644 100644
--- a/drivers/gpu/drm/hisilicon/kirin/Kconfig
+++ b/drivers/gpu/drm/hisilicon/kirin/Kconfig
@@ -4,6 +4,7 @@ config DRM_HISI_KIRIN
 	select DRM_KMS_HELPER
 	select DRM_GEM_CMA_HELPER
 	select DRM_KMS_CMA_HELPER
+	select HISI_KIRIN_DW_DSI
 	help
 	  Choose this option if you have a hisilicon Kirin chipsets(hi6220).
 	  If M is selected the module will be called kirin-drm.
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI
@ 2016-06-22  2:40 Xinliang Liu
  0 siblings, 0 replies; 9+ messages in thread
From: Xinliang Liu @ 2016-06-22  2:40 UTC (permalink / raw)
  To: dri-devel; +Cc: Zoltan Kuscsik, guodong.xu

From: Guodong Xu <guodong.xu@linaro.org>

Add select HISI_KIRIN_DW_DSI to Kconfig.
The DRM driver depends on dsi sub-driver.

v2: Add myself Signed-off-by, becuase others give me the right to
    forward the patch.

Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org>
Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
---
 drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/hisilicon/kirin/Kconfig b/drivers/gpu/drm/hisilicon/kirin/Kconfig
index ea0df6115f7e..499f64405dac 100644
--- a/drivers/gpu/drm/hisilicon/kirin/Kconfig
+++ b/drivers/gpu/drm/hisilicon/kirin/Kconfig
@@ -4,6 +4,7 @@ config DRM_HISI_KIRIN
 	select DRM_KMS_HELPER
 	select DRM_GEM_CMA_HELPER
 	select DRM_KMS_CMA_HELPER
+	select HISI_KIRIN_DW_DSI
 	help
 	  Choose this option if you have a hisilicon Kirin chipsets(hi6220).
 	  If M is selected the module will be called kirin-drm.
-- 
2.8.3

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-06-29 10:18 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-20  3:59 [PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI Xinliang Liu
2016-06-21 13:34 ` Thierry Reding
2016-06-22  0:54   ` Guodong Xu
2016-06-22  2:35     ` Xinliang Liu
2016-06-22 12:59     ` Thierry Reding
2016-06-29  9:08       ` Xinliang Liu
2016-06-22  2:34   ` Xinliang Liu
2016-06-22  2:40 Xinliang Liu
2016-06-29 10:18 Zoltan Kuscsik

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.