* [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds the option to copy "regulatory.db[.p7s]" to /lib/firmware
@ 2018-07-13 9:32 Christoph Engelbert
2018-07-14 12:38 ` Martin Bark
0 siblings, 1 reply; 11+ messages in thread
From: Christoph Engelbert @ 2018-07-13 9:32 UTC (permalink / raw)
To: buildroot
Certain wireless drivers (like the Broadcom FullMac drivers" expect the regulatory.db and
regulatory.db.p7s files to be available to be loadable from /lib/firmware. If not available
the driver still loads but runs on a minimal subset of channels.
This newly added option gives possibility to have those files copied to the necessary directory.
Signed-off-by: Christoph Engelbert <me@noctarius.com>
---
package/wireless-regdb/wireless-regdb.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/wireless-regdb/wireless-regdb.mk b/package/wireless-regdb/wireless-regdb.mk
index e9283a00e2..829374edcf 100644
--- a/package/wireless-regdb/wireless-regdb.mk
+++ b/package/wireless-regdb/wireless-regdb.mk
@@ -15,6 +15,10 @@ define WIRELESS_REGDB_INSTALL_TARGET_CMDS
$(TARGET_DIR)/usr/lib/crda/regulatory.bin
$(INSTALL) -m 644 -D -T $(@D)/sforshee.key.pub.pem \
$(TARGET_DIR)/etc/wireless-regdb/pubkeys/sforshee.key.pub.pem
+ $(INSTALL) -m 644 -D -T $(@D)/regulatory.db \
+ $(TARGET_DIR)/lib/firmware/regulatory.db
+ $(INSTALL) -m 644 -D -T $(@D)/regulatory.db.p7s \
+ $(TARGET_DIR)/lib/firmware/regulatory.db.p7s
endef
$(eval $(generic-package))
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds the option to copy "regulatory.db[.p7s]" to /lib/firmware
2018-07-13 9:32 [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds the option to copy "regulatory.db[.p7s]" to /lib/firmware Christoph Engelbert
@ 2018-07-14 12:38 ` Martin Bark
2018-07-15 8:13 ` Christoph Engelbert
0 siblings, 1 reply; 11+ messages in thread
From: Martin Bark @ 2018-07-14 12:38 UTC (permalink / raw)
To: buildroot
Chris,
On 13 July 2018 at 10:32, Christoph Engelbert <me@noctarius.com> wrote:
> Certain wireless drivers (like the Broadcom FullMac drivers" expect the regulatory.db and
> regulatory.db.p7s files to be available to be loadable from /lib/firmware. If not available
> the driver still loads but runs on a minimal subset of channels.
>
> This newly added option gives possibility to have those files copied to the necessary directory.
This is a good change but I think the commit message needs changing.
It's not really certain wireless drivers that is the issue, it's that
linux 4.15 added support to load regulatory.db directly without using
crda. If the kernel can't load regulatory.db directly it will still
try and use crda. So this change should allow you to stop using crda
for kernels after 4.15
Thanks
Martin
>
> Signed-off-by: Christoph Engelbert <me@noctarius.com>
> ---
> package/wireless-regdb/wireless-regdb.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/wireless-regdb/wireless-regdb.mk b/package/wireless-regdb/wireless-regdb.mk
> index e9283a00e2..829374edcf 100644
> --- a/package/wireless-regdb/wireless-regdb.mk
> +++ b/package/wireless-regdb/wireless-regdb.mk
> @@ -15,6 +15,10 @@ define WIRELESS_REGDB_INSTALL_TARGET_CMDS
> $(TARGET_DIR)/usr/lib/crda/regulatory.bin
> $(INSTALL) -m 644 -D -T $(@D)/sforshee.key.pub.pem \
> $(TARGET_DIR)/etc/wireless-regdb/pubkeys/sforshee.key.pub.pem
> + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db \
> + $(TARGET_DIR)/lib/firmware/regulatory.db
> + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db.p7s \
> + $(TARGET_DIR)/lib/firmware/regulatory.db.p7s
> endef
>
> $(eval $(generic-package))
> --
> 2.17.1
>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds the option to copy "regulatory.db[.p7s]" to /lib/firmware
2018-07-14 12:38 ` Martin Bark
@ 2018-07-15 8:13 ` Christoph Engelbert
2018-07-15 18:41 ` Martin Bark
0 siblings, 1 reply; 11+ messages in thread
From: Christoph Engelbert @ 2018-07-15 8:13 UTC (permalink / raw)
To: buildroot
Hey Martin,
Oh I see, didn?t know it was a general change. Does that mean it would probably make more sense to only install the new files as a new package and deprecate the old one?
Chris
> On 14. Jul 2018, at 14:38, Martin Bark <martin@barkynet.com> wrote:
>
> Chris,
>
> On 13 July 2018 at 10:32, Christoph Engelbert <me@noctarius.com> wrote:
>> Certain wireless drivers (like the Broadcom FullMac drivers" expect the regulatory.db and
>> regulatory.db.p7s files to be available to be loadable from /lib/firmware. If not available
>> the driver still loads but runs on a minimal subset of channels.
>>
>> This newly added option gives possibility to have those files copied to the necessary directory.
>
> This is a good change but I think the commit message needs changing.
> It's not really certain wireless drivers that is the issue, it's that
> linux 4.15 added support to load regulatory.db directly without using
> crda. If the kernel can't load regulatory.db directly it will still
> try and use crda. So this change should allow you to stop using crda
> for kernels after 4.15
>
> Thanks
>
> Martin
>
>>
>> Signed-off-by: Christoph Engelbert <me@noctarius.com>
>> ---
>> package/wireless-regdb/wireless-regdb.mk | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/package/wireless-regdb/wireless-regdb.mk b/package/wireless-regdb/wireless-regdb.mk
>> index e9283a00e2..829374edcf 100644
>> --- a/package/wireless-regdb/wireless-regdb.mk
>> +++ b/package/wireless-regdb/wireless-regdb.mk
>> @@ -15,6 +15,10 @@ define WIRELESS_REGDB_INSTALL_TARGET_CMDS
>> $(TARGET_DIR)/usr/lib/crda/regulatory.bin
>> $(INSTALL) -m 644 -D -T $(@D)/sforshee.key.pub.pem \
>> $(TARGET_DIR)/etc/wireless-regdb/pubkeys/sforshee.key.pub.pem
>> + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db \
>> + $(TARGET_DIR)/lib/firmware/regulatory.db
>> + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db.p7s \
>> + $(TARGET_DIR)/lib/firmware/regulatory.db.p7s
>> endef
>>
>> $(eval $(generic-package))
>> --
>> 2.17.1
>>
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds the option to copy "regulatory.db[.p7s]" to /lib/firmware
2018-07-15 8:13 ` Christoph Engelbert
@ 2018-07-15 18:41 ` Martin Bark
2018-07-16 15:15 ` Christoph Engelbert
0 siblings, 1 reply; 11+ messages in thread
From: Martin Bark @ 2018-07-15 18:41 UTC (permalink / raw)
To: buildroot
Chris,
On 15 July 2018 at 09:13, Christoph Engelbert <me@noctarius.com> wrote:
> Hey Martin,
>
> Oh I see, didn?t know it was a general change. Does that mean it would probably make more sense to only install the new files as a new package and deprecate the old one?
I think the changes look good, i was just saying to tweak the commit message.
Thanks
Martin
>
> Chris
>
>> On 14. Jul 2018, at 14:38, Martin Bark <martin@barkynet.com> wrote:
>>
>> Chris,
>>
>> On 13 July 2018 at 10:32, Christoph Engelbert <me@noctarius.com> wrote:
>>> Certain wireless drivers (like the Broadcom FullMac drivers" expect the regulatory.db and
>>> regulatory.db.p7s files to be available to be loadable from /lib/firmware. If not available
>>> the driver still loads but runs on a minimal subset of channels.
>>>
>>> This newly added option gives possibility to have those files copied to the necessary directory.
>>
>> This is a good change but I think the commit message needs changing.
>> It's not really certain wireless drivers that is the issue, it's that
>> linux 4.15 added support to load regulatory.db directly without using
>> crda. If the kernel can't load regulatory.db directly it will still
>> try and use crda. So this change should allow you to stop using crda
>> for kernels after 4.15
>>
>> Thanks
>>
>> Martin
>>
>>>
>>> Signed-off-by: Christoph Engelbert <me@noctarius.com>
>>> ---
>>> package/wireless-regdb/wireless-regdb.mk | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/package/wireless-regdb/wireless-regdb.mk b/package/wireless-regdb/wireless-regdb.mk
>>> index e9283a00e2..829374edcf 100644
>>> --- a/package/wireless-regdb/wireless-regdb.mk
>>> +++ b/package/wireless-regdb/wireless-regdb.mk
>>> @@ -15,6 +15,10 @@ define WIRELESS_REGDB_INSTALL_TARGET_CMDS
>>> $(TARGET_DIR)/usr/lib/crda/regulatory.bin
>>> $(INSTALL) -m 644 -D -T $(@D)/sforshee.key.pub.pem \
>>> $(TARGET_DIR)/etc/wireless-regdb/pubkeys/sforshee.key.pub.pem
>>> + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db \
>>> + $(TARGET_DIR)/lib/firmware/regulatory.db
>>> + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db.p7s \
>>> + $(TARGET_DIR)/lib/firmware/regulatory.db.p7s
>>> endef
>>>
>>> $(eval $(generic-package))
>>> --
>>> 2.17.1
>>>
>>>
>>> _______________________________________________
>>> buildroot mailing list
>>> buildroot at busybox.net
>>> http://lists.busybox.net/mailman/listinfo/buildroot
>>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds the option to copy "regulatory.db[.p7s]" to /lib/firmware
2018-07-15 18:41 ` Martin Bark
@ 2018-07-16 15:15 ` Christoph Engelbert
0 siblings, 0 replies; 11+ messages in thread
From: Christoph Engelbert @ 2018-07-16 15:15 UTC (permalink / raw)
To: buildroot
Hey Martin,
For some reason the changed mail became a new thread. Sorry about that :(
Chris
> On 15. Jul 2018, at 20:41, Martin Bark <martin@barkynet.com> wrote:
>
> Chris,
>
> On 15 July 2018 at 09:13, Christoph Engelbert <me@noctarius.com> wrote:
>> Hey Martin,
>>
>> Oh I see, didn?t know it was a general change. Does that mean it would probably make more sense to only install the new files as a new package and deprecate the old one?
>
> I think the changes look good, i was just saying to tweak the commit message.
>
> Thanks
>
> Martin
>
>>
>> Chris
>>
>>> On 14. Jul 2018, at 14:38, Martin Bark <martin@barkynet.com> wrote:
>>>
>>> Chris,
>>>
>>> On 13 July 2018 at 10:32, Christoph Engelbert <me@noctarius.com> wrote:
>>>> Certain wireless drivers (like the Broadcom FullMac drivers" expect the regulatory.db and
>>>> regulatory.db.p7s files to be available to be loadable from /lib/firmware. If not available
>>>> the driver still loads but runs on a minimal subset of channels.
>>>>
>>>> This newly added option gives possibility to have those files copied to the necessary directory.
>>>
>>> This is a good change but I think the commit message needs changing.
>>> It's not really certain wireless drivers that is the issue, it's that
>>> linux 4.15 added support to load regulatory.db directly without using
>>> crda. If the kernel can't load regulatory.db directly it will still
>>> try and use crda. So this change should allow you to stop using crda
>>> for kernels after 4.15
>>>
>>> Thanks
>>>
>>> Martin
>>>
>>>>
>>>> Signed-off-by: Christoph Engelbert <me@noctarius.com>
>>>> ---
>>>> package/wireless-regdb/wireless-regdb.mk | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/package/wireless-regdb/wireless-regdb.mk b/package/wireless-regdb/wireless-regdb.mk
>>>> index e9283a00e2..829374edcf 100644
>>>> --- a/package/wireless-regdb/wireless-regdb.mk
>>>> +++ b/package/wireless-regdb/wireless-regdb.mk
>>>> @@ -15,6 +15,10 @@ define WIRELESS_REGDB_INSTALL_TARGET_CMDS
>>>> $(TARGET_DIR)/usr/lib/crda/regulatory.bin
>>>> $(INSTALL) -m 644 -D -T $(@D)/sforshee.key.pub.pem \
>>>> $(TARGET_DIR)/etc/wireless-regdb/pubkeys/sforshee.key.pub.pem
>>>> + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db \
>>>> + $(TARGET_DIR)/lib/firmware/regulatory.db
>>>> + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db.p7s \
>>>> + $(TARGET_DIR)/lib/firmware/regulatory.db.p7s
>>>> endef
>>>>
>>>> $(eval $(generic-package))
>>>> --
>>>> 2.17.1
>>>>
>>>>
>>>> _______________________________________________
>>>> buildroot mailing list
>>>> buildroot at busybox.net
>>>> http://lists.busybox.net/mailman/listinfo/buildroot
>>>
>>
>>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds the option to copy "regulatory.db[.p7s]" to /lib/firmware
@ 2018-07-13 9:30 noctarius
0 siblings, 0 replies; 11+ messages in thread
From: noctarius @ 2018-07-13 9:30 UTC (permalink / raw)
To: buildroot
From: Christoph Engelbert <me@noctarius.com>
Certain wireless drivers (like the Broadcom FullMac drivers" expect the regulatory.db and
regulatory.db.p7s files to be available to be loadable from /lib/firmware. If not available
the driver still loads but runs on a minimal subset of channels.
This newly added option gives possibility to have those files copied to the necessary directory.
Signed-off-by: Christoph Engelbert <me@noctarius.com>
---
package/wireless-regdb/wireless-regdb.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/wireless-regdb/wireless-regdb.mk b/package/wireless-regdb/wireless-regdb.mk
index e9283a00e2..829374edcf 100644
--- a/package/wireless-regdb/wireless-regdb.mk
+++ b/package/wireless-regdb/wireless-regdb.mk
@@ -15,6 +15,10 @@ define WIRELESS_REGDB_INSTALL_TARGET_CMDS
$(TARGET_DIR)/usr/lib/crda/regulatory.bin
$(INSTALL) -m 644 -D -T $(@D)/sforshee.key.pub.pem \
$(TARGET_DIR)/etc/wireless-regdb/pubkeys/sforshee.key.pub.pem
+ $(INSTALL) -m 644 -D -T $(@D)/regulatory.db \
+ $(TARGET_DIR)/lib/firmware/regulatory.db
+ $(INSTALL) -m 644 -D -T $(@D)/regulatory.db.p7s \
+ $(TARGET_DIR)/lib/firmware/regulatory.db.p7s
endef
$(eval $(generic-package))
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds the option to copy "regulatory.db[.p7s]" to /lib/firmware
@ 2018-07-12 20:09 noctarius
2018-07-13 8:37 ` Arnout Vandecappelle
0 siblings, 1 reply; 11+ messages in thread
From: noctarius @ 2018-07-12 20:09 UTC (permalink / raw)
To: buildroot
Certain wireless drivers (like the Broadcom FullMac drivers" expect the regulatory.db and
regulatory.db.p7s files to be available to be loadable from /lib/firmware. If not available
the driver still loads but runs on a minimal subset of channels.
This newly added option gives possibility to have those files copied to the necessary directory.
Signed-off-by: Christoph Engelbert <me@noctarius.com>
---
package/wireless-regdb/Config.in | 8 ++++++++
package/wireless-regdb/wireless-regdb.mk | 10 ++++++++++
2 files changed, 18 insertions(+)
diff --git a/package/wireless-regdb/Config.in b/package/wireless-regdb/Config.in
index 0c9896deb9..5c91a7d8c7 100644
--- a/package/wireless-regdb/Config.in
+++ b/package/wireless-regdb/Config.in
@@ -7,3 +7,11 @@ config BR2_PACKAGE_WIRELESS_REGDB
allowed radio frequencies for each local jurisdiction.
https://wireless.wiki.kernel.org/en/developers/regulatory/wireless-regdb
+
+config BR2_PACKAGE_WIRELESS_REGDB_FIRMWARE
+ bool "wireless-regdb-firmware"
+ depends on BR2_PACKAGE_WIRELESS_REGDB
+ help
+ Copies the regulatory.db and regulatory.db.p7s files to
+ /lib/firmware which is necessary for certain drivers like
+ the Broadcom FullMac driver.
diff --git a/package/wireless-regdb/wireless-regdb.mk b/package/wireless-regdb/wireless-regdb.mk
index e9283a00e2..e322035841 100644
--- a/package/wireless-regdb/wireless-regdb.mk
+++ b/package/wireless-regdb/wireless-regdb.mk
@@ -10,6 +10,16 @@ WIRELESS_REGDB_SITE = http://kernel.org/pub/software/network/wireless-regdb
WIRELESS_REGDB_LICENSE = ISC
WIRELESS_REGDB_LICENSE_FILES = LICENSE
+ifeq ($(BR2_PACKAGE_WIRELESS_REGDB_FIRMWARE),y)
+define WIRELESS_REGDB_FIRMWARE_INSTALL
+ $(INSTALL) -m 644 -D -T $(@D)/regulatory.db \
+ $(TARGET_DIR)/lib/firmware/regulatory.db
+ $(INSTALL) -m 644 -D -T $(@D)/regulatory.db.p7s \
+ $(TARGET_DIR)/lib/firmware/regulatory.db.p7s
+endef
+WIRELESS_REGDB_POST_INSTALL_TARGET_HOOKS += WIRELESS_REGDB_FIRMWARE_INSTALL
+endif
+
define WIRELESS_REGDB_INSTALL_TARGET_CMDS
$(INSTALL) -m 644 -D -T $(@D)/regulatory.bin \
$(TARGET_DIR)/usr/lib/crda/regulatory.bin
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds the option to copy "regulatory.db[.p7s]" to /lib/firmware
2018-07-12 20:09 noctarius
@ 2018-07-13 8:37 ` Arnout Vandecappelle
2018-07-13 9:22 ` Christoph Engelbert
0 siblings, 1 reply; 11+ messages in thread
From: Arnout Vandecappelle @ 2018-07-13 8:37 UTC (permalink / raw)
To: buildroot
Hi Christoph,
Thank you for this patch. I have a few small remarks.
On 12-07-18 22:09, noctarius wrote:
The Author should be the same as the signed-off-by, so could you set your
user.name to Christoph Engelbert?
> Certain wireless drivers (like the Broadcom FullMac drivers" expect the regulatory.db and
> regulatory.db.p7s files to be available to be loadable from /lib/firmware. If not available
> the driver still loads but runs on a minimal subset of channels.
>
> This newly added option gives possibility to have those files copied to the necessary directory.
>
> Signed-off-by: Christoph Engelbert <me@noctarius.com>
> ---
> package/wireless-regdb/Config.in | 8 ++++++++
> package/wireless-regdb/wireless-regdb.mk | 10 ++++++++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/package/wireless-regdb/Config.in b/package/wireless-regdb/Config.in
> index 0c9896deb9..5c91a7d8c7 100644
> --- a/package/wireless-regdb/Config.in
> +++ b/package/wireless-regdb/Config.in
> @@ -7,3 +7,11 @@ config BR2_PACKAGE_WIRELESS_REGDB
> allowed radio frequencies for each local jurisdiction.
>
> https://wireless.wiki.kernel.org/en/developers/regulatory/wireless-regdb
> +
> +config BR2_PACKAGE_WIRELESS_REGDB_FIRMWARE
> + bool "wireless-regdb-firmware"
> + depends on BR2_PACKAGE_WIRELESS_REGDB
> + help
> + Copies the regulatory.db and regulatory.db.p7s files to
> + /lib/firmware which is necessary for certain drivers like
> + the Broadcom FullMac driver.
> diff --git a/package/wireless-regdb/wireless-regdb.mk b/package/wireless-regdb/wireless-regdb.mk
> index e9283a00e2..e322035841 100644
> --- a/package/wireless-regdb/wireless-regdb.mk
> +++ b/package/wireless-regdb/wireless-regdb.mk
> @@ -10,6 +10,16 @@ WIRELESS_REGDB_SITE = http://kernel.org/pub/software/network/wireless-regdb
> WIRELESS_REGDB_LICENSE = ISC
> WIRELESS_REGDB_LICENSE_FILES = LICENSE
>
> +ifeq ($(BR2_PACKAGE_WIRELESS_REGDB_FIRMWARE),y)
> +define WIRELESS_REGDB_FIRMWARE_INSTALL
> + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db \
> + $(TARGET_DIR)/lib/firmware/regulatory.db
> + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db.p7s \
> + $(TARGET_DIR)/lib/firmware/regulatory.db.p7s
Since these two files only add up to 6KB, I don't think it's worthwhile to make
installing them conditional.
Regards,
Arnout
> +endef
> +WIRELESS_REGDB_POST_INSTALL_TARGET_HOOKS += WIRELESS_REGDB_FIRMWARE_INSTALL
> +endif
> +
> define WIRELESS_REGDB_INSTALL_TARGET_CMDS
> $(INSTALL) -m 644 -D -T $(@D)/regulatory.bin \
> $(TARGET_DIR)/usr/lib/crda/regulatory.bin
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds the option to copy "regulatory.db[.p7s]" to /lib/firmware
2018-07-13 8:37 ` Arnout Vandecappelle
@ 2018-07-13 9:22 ` Christoph Engelbert
2018-07-13 9:34 ` Christoph Engelbert
0 siblings, 1 reply; 11+ messages in thread
From: Christoph Engelbert @ 2018-07-13 9:22 UTC (permalink / raw)
To: buildroot
Hey Arnout,
> On 13. Jul 2018, at 10:37, Arnout Vandecappelle <arnout@mind.be> wrote:
>
> Hi Christoph,
>
> Thank you for this patch. I have a few small remarks.
>
>
> On 12-07-18 22:09, noctarius wrote:
>
> The Author should be the same as the signed-off-by, so could you set your
> user.name to Christoph Engelbert?
Sure thing.
>
>> Certain wireless drivers (like the Broadcom FullMac drivers" expect the regulatory.db and
>> regulatory.db.p7s files to be available to be loadable from /lib/firmware. If not available
>> the driver still loads but runs on a minimal subset of channels.
>>
>> This newly added option gives possibility to have those files copied to the necessary directory.
>>
>> Signed-off-by: Christoph Engelbert <me@noctarius.com>
>> ---
>> package/wireless-regdb/Config.in | 8 ++++++++
>> package/wireless-regdb/wireless-regdb.mk | 10 ++++++++++
>> 2 files changed, 18 insertions(+)
>>
>> diff --git a/package/wireless-regdb/Config.in b/package/wireless-regdb/Config.in
>> index 0c9896deb9..5c91a7d8c7 100644
>> --- a/package/wireless-regdb/Config.in
>> +++ b/package/wireless-regdb/Config.in
>> @@ -7,3 +7,11 @@ config BR2_PACKAGE_WIRELESS_REGDB
>> allowed radio frequencies for each local jurisdiction.
>>
>> https://wireless.wiki.kernel.org/en/developers/regulatory/wireless-regdb
>> +
>> +config BR2_PACKAGE_WIRELESS_REGDB_FIRMWARE
>> + bool "wireless-regdb-firmware"
>> + depends on BR2_PACKAGE_WIRELESS_REGDB
>> + help
>> + Copies the regulatory.db and regulatory.db.p7s files to
>> + /lib/firmware which is necessary for certain drivers like
>> + the Broadcom FullMac driver.
>> diff --git a/package/wireless-regdb/wireless-regdb.mk b/package/wireless-regdb/wireless-regdb.mk
>> index e9283a00e2..e322035841 100644
>> --- a/package/wireless-regdb/wireless-regdb.mk
>> +++ b/package/wireless-regdb/wireless-regdb.mk
>> @@ -10,6 +10,16 @@ WIRELESS_REGDB_SITE = http://kernel.org/pub/software/network/wireless-regdb
>> WIRELESS_REGDB_LICENSE = ISC
>> WIRELESS_REGDB_LICENSE_FILES = LICENSE
>>
>> +ifeq ($(BR2_PACKAGE_WIRELESS_REGDB_FIRMWARE),y)
>> +define WIRELESS_REGDB_FIRMWARE_INSTALL
>> + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db \
>> + $(TARGET_DIR)/lib/firmware/regulatory.db
>> + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db.p7s \
>> + $(TARGET_DIR)/lib/firmware/regulatory.db.p7s
>
> Since these two files only add up to 6KB, I don't think it's worthwhile to make
> installing them conditional.
My thinking was, since nobody seems to miss it, most drivers might not need it at all and it?s specific to the likes of Broadcom. To not change the current behavior I added the condition. Obviously I can remove it, if you prefer.
Thanks,
Chris
>
> Regards,
> Arnout
>
>> +endef
>> +WIRELESS_REGDB_POST_INSTALL_TARGET_HOOKS += WIRELESS_REGDB_FIRMWARE_INSTALL
>> +endif
>> +
>> define WIRELESS_REGDB_INSTALL_TARGET_CMDS
>> $(INSTALL) -m 644 -D -T $(@D)/regulatory.bin \
>> $(TARGET_DIR)/usr/lib/crda/regulatory.bin
>>
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds the option to copy "regulatory.db[.p7s]" to /lib/firmware
2018-07-13 9:22 ` Christoph Engelbert
@ 2018-07-13 9:34 ` Christoph Engelbert
0 siblings, 0 replies; 11+ messages in thread
From: Christoph Engelbert @ 2018-07-13 9:34 UTC (permalink / raw)
To: buildroot
Hey again,
Sorry for the lot of mails, I guess the last version is actually what you?re looking for. Feeling a bit stupid, but first time I?m working with this system over pull requests :(
Thanks,
Chris
> On 13. Jul 2018, at 11:22, Christoph Engelbert <me@noctarius.com> wrote:
>
> Hey Arnout,
>
>> On 13. Jul 2018, at 10:37, Arnout Vandecappelle <arnout at mind.be <mailto:arnout@mind.be>> wrote:
>>
>> Hi Christoph,
>>
>> Thank you for this patch. I have a few small remarks.
>>
>>
>> On 12-07-18 22:09, noctarius wrote:
>>
>> The Author should be the same as the signed-off-by, so could you set your
>> user.name to Christoph Engelbert?
>
> Sure thing.
>
>>
>>> Certain wireless drivers (like the Broadcom FullMac drivers" expect the regulatory.db and
>>> regulatory.db.p7s files to be available to be loadable from /lib/firmware. If not available
>>> the driver still loads but runs on a minimal subset of channels.
>>>
>>> This newly added option gives possibility to have those files copied to the necessary directory.
>>>
>>> Signed-off-by: Christoph Engelbert <me@noctarius.com>
>>> ---
>>> package/wireless-regdb/Config.in | 8 ++++++++
>>> package/wireless-regdb/wireless-regdb.mk | 10 ++++++++++
>>> 2 files changed, 18 insertions(+)
>>>
>>> diff --git a/package/wireless-regdb/Config.in b/package/wireless-regdb/Config.in
>>> index 0c9896deb9..5c91a7d8c7 100644
>>> --- a/package/wireless-regdb/Config.in
>>> +++ b/package/wireless-regdb/Config.in
>>> @@ -7,3 +7,11 @@ config BR2_PACKAGE_WIRELESS_REGDB
>>> allowed radio frequencies for each local jurisdiction.
>>>
>>> https://wireless.wiki.kernel.org/en/developers/regulatory/wireless-regdb
>>> +
>>> +config BR2_PACKAGE_WIRELESS_REGDB_FIRMWARE
>>> + bool "wireless-regdb-firmware"
>>> + depends on BR2_PACKAGE_WIRELESS_REGDB
>>> + help
>>> + Copies the regulatory.db and regulatory.db.p7s files to
>>> + /lib/firmware which is necessary for certain drivers like
>>> + the Broadcom FullMac driver.
>>> diff --git a/package/wireless-regdb/wireless-regdb.mk b/package/wireless-regdb/wireless-regdb.mk
>>> index e9283a00e2..e322035841 100644
>>> --- a/package/wireless-regdb/wireless-regdb.mk
>>> +++ b/package/wireless-regdb/wireless-regdb.mk
>>> @@ -10,6 +10,16 @@ WIRELESS_REGDB_SITE = http://kernel.org/pub/software/network/wireless-regdb
>>> WIRELESS_REGDB_LICENSE = ISC
>>> WIRELESS_REGDB_LICENSE_FILES = LICENSE
>>>
>>> +ifeq ($(BR2_PACKAGE_WIRELESS_REGDB_FIRMWARE),y)
>>> +define WIRELESS_REGDB_FIRMWARE_INSTALL
>>> + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db \
>>> + $(TARGET_DIR)/lib/firmware/regulatory.db
>>> + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db.p7s \
>>> + $(TARGET_DIR)/lib/firmware/regulatory.db.p7s
>>
>> Since these two files only add up to 6KB, I don't think it's worthwhile to make
>> installing them conditional.
>
> My thinking was, since nobody seems to miss it, most drivers might not need it at all and it?s specific to the likes of Broadcom. To not change the current behavior I added the condition. Obviously I can remove it, if you prefer.
>
> Thanks,
> Chris
>
>>
>> Regards,
>> Arnout
>>
>>> +endef
>>> +WIRELESS_REGDB_POST_INSTALL_TARGET_HOOKS += WIRELESS_REGDB_FIRMWARE_INSTALL
>>> +endif
>>> +
>>> define WIRELESS_REGDB_INSTALL_TARGET_CMDS
>>> $(INSTALL) -m 644 -D -T $(@D)/regulatory.bin \
>>> $(TARGET_DIR)/usr/lib/crda/regulatory.bin
>>>
>>
>> --
>> Arnout Vandecappelle arnout at mind be
>> Senior Embedded Software Architect +32-16-286500
>> Essensium/Mind http://www.mind.be
>> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
>> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
>> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net <mailto:buildroot@busybox.net>
>> http://lists.busybox.net/mailman/listinfo/buildroot <http://lists.busybox.net/mailman/listinfo/buildroot>
>>
>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net <mailto:buildroot@busybox.net>
> http://lists.busybox.net/mailman/listinfo/buildroot <http://lists.busybox.net/mailman/listinfo/buildroot>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180713/ef8f2258/attachment.html>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds the option to copy "regulatory.db[.p7s]" to /lib/firmware
@ 2018-07-12 20:01 noctarius
0 siblings, 0 replies; 11+ messages in thread
From: noctarius @ 2018-07-12 20:01 UTC (permalink / raw)
To: buildroot
Certain wireless drivers (like the Broadcom FullMac drivers" expect the regulatory.db and
regulatory.db.p7s files to be available to be loadable from /lib/firmware. If not available
the driver still loads but runs on a minimal subset of channels.
This newly added option gives possibility to have those files copied to the necessary directory.
Signed-off-by: Christoph Engelbert <me@noctarius.com>
---
package/wireless-regdb/Config.in | 8 ++++++++
package/wireless-regdb/wireless-regdb.mk | 10 ++++++++++
2 files changed, 18 insertions(+)
diff --git a/package/wireless-regdb/Config.in b/package/wireless-regdb/Config.in
index 0c9896deb9..5c91a7d8c7 100644
--- a/package/wireless-regdb/Config.in
+++ b/package/wireless-regdb/Config.in
@@ -7,3 +7,11 @@ config BR2_PACKAGE_WIRELESS_REGDB
allowed radio frequencies for each local jurisdiction.
https://wireless.wiki.kernel.org/en/developers/regulatory/wireless-regdb
+
+config BR2_PACKAGE_WIRELESS_REGDB_FIRMWARE
+ bool "wireless-regdb-firmware"
+ depends on BR2_PACKAGE_WIRELESS_REGDB
+ help
+ Copies the regulatory.db and regulatory.db.p7s files to
+ /lib/firmware which is necessary for certain drivers like
+ the Broadcom FullMac driver.
diff --git a/package/wireless-regdb/wireless-regdb.mk b/package/wireless-regdb/wireless-regdb.mk
index e9283a00e2..e322035841 100644
--- a/package/wireless-regdb/wireless-regdb.mk
+++ b/package/wireless-regdb/wireless-regdb.mk
@@ -10,6 +10,16 @@ WIRELESS_REGDB_SITE = http://kernel.org/pub/software/network/wireless-regdb
WIRELESS_REGDB_LICENSE = ISC
WIRELESS_REGDB_LICENSE_FILES = LICENSE
+ifeq ($(BR2_PACKAGE_WIRELESS_REGDB_FIRMWARE),y)
+define WIRELESS_REGDB_FIRMWARE_INSTALL
+ $(INSTALL) -m 644 -D -T $(@D)/regulatory.db \
+ $(TARGET_DIR)/lib/firmware/regulatory.db
+ $(INSTALL) -m 644 -D -T $(@D)/regulatory.db.p7s \
+ $(TARGET_DIR)/lib/firmware/regulatory.db.p7s
+endef
+WIRELESS_REGDB_POST_INSTALL_TARGET_HOOKS += WIRELESS_REGDB_FIRMWARE_INSTALL
+endif
+
define WIRELESS_REGDB_INSTALL_TARGET_CMDS
$(INSTALL) -m 644 -D -T $(@D)/regulatory.bin \
$(TARGET_DIR)/usr/lib/crda/regulatory.bin
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-07-16 15:15 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13 9:32 [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds the option to copy "regulatory.db[.p7s]" to /lib/firmware Christoph Engelbert
2018-07-14 12:38 ` Martin Bark
2018-07-15 8:13 ` Christoph Engelbert
2018-07-15 18:41 ` Martin Bark
2018-07-16 15:15 ` Christoph Engelbert
-- strict thread matches above, loose matches on Subject: below --
2018-07-13 9:30 noctarius
2018-07-12 20:09 noctarius
2018-07-13 8:37 ` Arnout Vandecappelle
2018-07-13 9:22 ` Christoph Engelbert
2018-07-13 9:34 ` Christoph Engelbert
2018-07-12 20:01 noctarius
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.