[PATCH 1/2] debian: Remove --enable-smp

[PATCH 1/2] debian: Remove --enable-smp

[Richard Weinberger]

SMP is now enabled by default for all architectures.
No need to use --enable-smp anymore.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 debian/rules | 1 -
 1 file changed, 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 3fe6bece93c9..60094734630d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -17,7 +17,6 @@ CONFIG_OPTS = --prefix=/usr \
             --includedir=/usr/include/xenomai \
             --mandir=/usr/share/man \
             --with-testdir=/usr/lib/xenomai/testsuite \
-            --enable-smp \
             --enable-lazy-setsched \
             --enable-debug=symbols \
             --enable-dlopen-libs
-- 
2.26.2

[PATCH 2/2] doc: Remove references to --enable-smp

[Richard Weinberger]

SMP is enabled by default, remove usage of --enable-smp
and document how to disable SMP, if needed.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 doc/asciidoc/README.INSTALL.adoc | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/doc/asciidoc/README.INSTALL.adoc b/doc/asciidoc/README.INSTALL.adoc
index c0f4c12e99b4..d2b7e6f782eb 100644
--- a/doc/asciidoc/README.INSTALL.adoc
+++ b/doc/asciidoc/README.INSTALL.adoc
@@ -538,9 +538,9 @@ only reason to turn this feature on would be aimed at cancelling
 threads which run significantly long, syscall-less busy loops with no
 explicit exit condition, which should probably be revisited anyway.
 
-*--enable-smp*::
+*--disable-smp*::
 
-	Turns on SMP support for Xenomai libraries.
+	Turns off SMP support for Xenomai libraries.
 
 [CAUTION]
 SMP support must be enabled in Xenomai libraries when the
@@ -671,9 +671,6 @@ The examples in following sections use the following conventions:
  the host immediately updates the target system with the installed
  programs and libraries.
 
-CAUTION: In the examples below, make sure to add `--enable-smp` to the
-_configure_ script options if building for a SMP-enabled kernel.
-
 Building the x86 libraries (32/64bit)
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
@@ -683,7 +680,7 @@ typically run:
 
 ------------------------------------------------------------------------------
 $ mkdir $build_root && cd $build_root
-$ $xenomai_root/configure --with-core=mercury --enable-smp --enable-pshared
+$ $xenomai_root/configure --with-core=mercury --enable-pshared
 $ make install
 ------------------------------------------------------------------------------
 
@@ -692,7 +689,7 @@ same feature set, for running on x86_32 could be:
 
 ------------------------------------------------------------------------------
 $ mkdir $build_root && cd $build_root
-$ $xenomai_root/configure --with-core=cobalt --enable-smp --enable-pshared \
+$ $xenomai_root/configure --with-core=cobalt --enable-pshared \
   --host=i686-linux CFLAGS="-m32 -O2" LDFLAGS="-m32"
 $ make install
 ------------------------------------------------------------------------------
@@ -743,10 +740,10 @@ for the supported SOCs:
 		gcc versions the flag for armv7
 		may be `-march=armv7-a` or
 		`-march=armv7a`]|
-|imx6q	     | `-march=armv7-a -mfpu=vfp3` footnoteref:[armv7] | --enable-smp
+|imx6q	     | `-march=armv7-a -mfpu=vfp3` footnoteref:[armv7] |
 |ixp4xx      | `-march=armv5 -msoft-float`         | `--enable-arm-tsc=ixp4xx`
 |omap3       | `-march=armv7-a -mfpu=vfp3` footnoteref:[armv7] |
-|omap4       | `-march=armv7-a -mfpu=vfp3` footnoteref:[armv7] | --enable-smp
+|omap4       | `-march=armv7-a -mfpu=vfp3` footnoteref:[armv7] |
 |orion       | `-march=armv5 -mfpu=vfp`            |
 |pxa         | `-march=armv5 -msoft-float`         |
 |pxa3xx      | `-march=armv5 -msoft-float`         | --enable-arm-quirks=xscale3
-- 
2.26.2

Re: [PATCH 1/2] debian: Remove --enable-smp

[Richard Weinberger]

ping? :-)

On Wed, Apr 13, 2022 at 2:05 PM Richard Weinberger via Xenomai
<xenomai@xenomai.org> wrote:
>
> SMP is now enabled by default for all architectures.
> No need to use --enable-smp anymore.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  debian/rules | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/debian/rules b/debian/rules
> index 3fe6bece93c9..60094734630d 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -17,7 +17,6 @@ CONFIG_OPTS = --prefix=/usr \
>              --includedir=/usr/include/xenomai \
>              --mandir=/usr/share/man \
>              --with-testdir=/usr/lib/xenomai/testsuite \
> -            --enable-smp \
>              --enable-lazy-setsched \
>              --enable-debug=symbols \
>              --enable-dlopen-libs
> --
> 2.26.2
>
>


-- 
Thanks,
//richard

Re: [PATCH 1/2] debian: Remove --enable-smp

[Jan Kiszka]

On 05.05.22 22:06, Richard Weinberger via Xenomai wrote:
> ping? :-)
> 

Thanks for the reminder - merged.

But "configure --help" itself still talks about "--enable-smp". Should
like be changed to "--disable-smp" to reflect the default.

Jan

> On Wed, Apr 13, 2022 at 2:05 PM Richard Weinberger via Xenomai
> <xenomai@xenomai.org> wrote:
>>
>> SMP is now enabled by default for all architectures.
>> No need to use --enable-smp anymore.
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>>  debian/rules | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/debian/rules b/debian/rules
>> index 3fe6bece93c9..60094734630d 100755
>> --- a/debian/rules
>> +++ b/debian/rules
>> @@ -17,7 +17,6 @@ CONFIG_OPTS = --prefix=/usr \
>>              --includedir=/usr/include/xenomai \
>>              --mandir=/usr/share/man \
>>              --with-testdir=/usr/lib/xenomai/testsuite \
>> -            --enable-smp \
>>              --enable-lazy-setsched \
>>              --enable-debug=symbols \
>>              --enable-dlopen-libs
>> --
>> 2.26.2
>>
>>
> 
> 


-- 
Siemens AG, Technology
Competence Center Embedded Linux

Re: [PATCH 1/2] debian: Remove --enable-smp

[Richard Weinberger]

----- Ursprüngliche Mail -----
> Von: "Jan Kiszka" <jan.kiszka@siemens.com>
> On 05.05.22 22:06, Richard Weinberger via Xenomai wrote:
>> ping? :-)
>> 
> 
> Thanks for the reminder - merged.

Did you also apply "[PATCH 2/2] doc: Remove references to --enable-smp"?
 
> But "configure --help" itself still talks about "--enable-smp". Should
> like be changed to "--disable-smp" to reflect the default.

Hm, I thought (hoped?) --help is auto generated by autoconf.
Will check.

Thanks,
//richard

Re: [PATCH 1/2] debian: Remove --enable-smp

[Jan Kiszka]

On 06.05.22 08:55, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
>> Von: "Jan Kiszka" <jan.kiszka@siemens.com>
>> On 05.05.22 22:06, Richard Weinberger via Xenomai wrote:
>>> ping? :-)
>>>
>>
>> Thanks for the reminder - merged.
> 
> Did you also apply "[PATCH 2/2] doc: Remove references to --enable-smp"?
>  
>> But "configure --help" itself still talks about "--enable-smp". Should
>> like be changed to "--disable-smp" to reflect the default.
> 
> Hm, I thought (hoped?) --help is auto generated by autoconf.
> Will check.
> 

You series did not touch configure.ac.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux

Re: [PATCH 1/2] debian: Remove --enable-smp

[Richard Weinberger]

----- Ursprüngliche Mail -----
> Von: "Jan Kiszka" <jan.kiszka@siemens.com>
>> Hm, I thought (hoped?) --help is auto generated by autoconf.
>> Will check.
>> 
> 
> You series did not touch configure.ac.

But 54f69549266b ("configure.ac: Enable SMP by default") did.

Now I see that the help text is part of the AC_ARG_ENABLE() macro. ;-\
Will send a follow up patch to massage the help message.

Thanks,
//richard