* [PATCH -next 0/4] ubifs: Fix some kernel-doc warnings for ubifs
@ 2020-09-14 13:56 ` Wang Hai
0 siblings, 0 replies; 12+ messages in thread
From: Wang Hai @ 2020-09-14 13:56 UTC (permalink / raw)
To: richard; +Cc: linux-mtd, linux-kernel
In the ubifs module, there are some kernel-doc warnings,
this series of patches can fix these warnings.
Wang Hai (4):
ubifs: Fix 'hash' kernel-doc warning in auth.c
ubifs: Fix some kernel-doc warnings in gc.c
ubifs: Fix some kernel-doc warnings in replay.c
ubifs: Fix some kernel-doc warnings in tnc.c
fs/ubifs/auth.c | 2 +-
fs/ubifs/gc.c | 4 ----
fs/ubifs/replay.c | 2 --
fs/ubifs/tnc.c | 3 +--
4 files changed, 2 insertions(+), 9 deletions(-)
--
2.17.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH -next 1/4] ubifs: Fix 'hash' kernel-doc warning in auth.c
2020-09-14 13:56 ` Wang Hai
@ 2020-09-14 13:56 ` Wang Hai
-1 siblings, 0 replies; 12+ messages in thread
From: Wang Hai @ 2020-09-14 13:56 UTC (permalink / raw)
To: richard; +Cc: linux-mtd, linux-kernel
Fixes the following W=1 kernel build warning(s):
fs/ubifs/auth.c:66: warning: Excess function parameter 'hash' description in 'ubifs_prepare_auth_node'
Rename hash to inhash.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
fs/ubifs/auth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c
index cc5c0abfd536..b93b3cd10bfd 100644
--- a/fs/ubifs/auth.c
+++ b/fs/ubifs/auth.c
@@ -54,7 +54,7 @@ static int ubifs_hash_calc_hmac(const struct ubifs_info *c, const u8 *hash,
* ubifs_prepare_auth_node - Prepare an authentication node
* @c: UBIFS file-system description object
* @node: the node to calculate a hash for
- * @hash: input hash of previous nodes
+ * @inhash: input hash of previous nodes
*
* This function prepares an authentication node for writing onto flash.
* It creates a HMAC from the given input hash and writes it to the node.
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH -next 1/4] ubifs: Fix 'hash' kernel-doc warning in auth.c
@ 2020-09-14 13:56 ` Wang Hai
0 siblings, 0 replies; 12+ messages in thread
From: Wang Hai @ 2020-09-14 13:56 UTC (permalink / raw)
To: richard; +Cc: linux-mtd, linux-kernel
Fixes the following W=1 kernel build warning(s):
fs/ubifs/auth.c:66: warning: Excess function parameter 'hash' description in 'ubifs_prepare_auth_node'
Rename hash to inhash.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
fs/ubifs/auth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c
index cc5c0abfd536..b93b3cd10bfd 100644
--- a/fs/ubifs/auth.c
+++ b/fs/ubifs/auth.c
@@ -54,7 +54,7 @@ static int ubifs_hash_calc_hmac(const struct ubifs_info *c, const u8 *hash,
* ubifs_prepare_auth_node - Prepare an authentication node
* @c: UBIFS file-system description object
* @node: the node to calculate a hash for
- * @hash: input hash of previous nodes
+ * @inhash: input hash of previous nodes
*
* This function prepares an authentication node for writing onto flash.
* It creates a HMAC from the given input hash and writes it to the node.
--
2.17.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH -next 2/4] ubifs: Fix some kernel-doc warnings in gc.c
2020-09-14 13:56 ` Wang Hai
@ 2020-09-14 13:56 ` Wang Hai
-1 siblings, 0 replies; 12+ messages in thread
From: Wang Hai @ 2020-09-14 13:56 UTC (permalink / raw)
To: richard; +Cc: linux-mtd, linux-kernel
Fixes the following W=1 kernel build warning(s):
fs/ubifs/gc.c:70: warning: Excess function parameter 'buf' description in 'switch_gc_head'
fs/ubifs/gc.c:70: warning: Excess function parameter 'len' description in 'switch_gc_head'
fs/ubifs/gc.c:70: warning: Excess function parameter 'lnum' description in 'switch_gc_head'
fs/ubifs/gc.c:70: warning: Excess function parameter 'offs' description in 'switch_gc_head'
They're not in use. Remove them.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
fs/ubifs/gc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c
index 62cb3db44e6e..a4aaeea63893 100644
--- a/fs/ubifs/gc.c
+++ b/fs/ubifs/gc.c
@@ -57,10 +57,6 @@
/**
* switch_gc_head - switch the garbage collection journal head.
* @c: UBIFS file-system description object
- * @buf: buffer to write
- * @len: length of the buffer to write
- * @lnum: LEB number written is returned here
- * @offs: offset written is returned here
*
* This function switch the GC head to the next LEB which is reserved in
* @c->gc_lnum. Returns %0 in case of success, %-EAGAIN if commit is required,
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH -next 2/4] ubifs: Fix some kernel-doc warnings in gc.c
@ 2020-09-14 13:56 ` Wang Hai
0 siblings, 0 replies; 12+ messages in thread
From: Wang Hai @ 2020-09-14 13:56 UTC (permalink / raw)
To: richard; +Cc: linux-mtd, linux-kernel
Fixes the following W=1 kernel build warning(s):
fs/ubifs/gc.c:70: warning: Excess function parameter 'buf' description in 'switch_gc_head'
fs/ubifs/gc.c:70: warning: Excess function parameter 'len' description in 'switch_gc_head'
fs/ubifs/gc.c:70: warning: Excess function parameter 'lnum' description in 'switch_gc_head'
fs/ubifs/gc.c:70: warning: Excess function parameter 'offs' description in 'switch_gc_head'
They're not in use. Remove them.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
fs/ubifs/gc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c
index 62cb3db44e6e..a4aaeea63893 100644
--- a/fs/ubifs/gc.c
+++ b/fs/ubifs/gc.c
@@ -57,10 +57,6 @@
/**
* switch_gc_head - switch the garbage collection journal head.
* @c: UBIFS file-system description object
- * @buf: buffer to write
- * @len: length of the buffer to write
- * @lnum: LEB number written is returned here
- * @offs: offset written is returned here
*
* This function switch the GC head to the next LEB which is reserved in
* @c->gc_lnum. Returns %0 in case of success, %-EAGAIN if commit is required,
--
2.17.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH -next 3/4] ubifs: Fix some kernel-doc warnings in replay.c
2020-09-14 13:56 ` Wang Hai
@ 2020-09-14 13:56 ` Wang Hai
-1 siblings, 0 replies; 12+ messages in thread
From: Wang Hai @ 2020-09-14 13:56 UTC (permalink / raw)
To: richard; +Cc: linux-mtd, linux-kernel
Fixes the following W=1 kernel build warning(s):
fs/ubifs/replay.c:942: warning: Excess function parameter 'ref_lnum' description in 'validate_ref'
fs/ubifs/replay.c:942: warning: Excess function parameter 'ref_offs' description in 'validate_ref'
They're not in use. Remove them.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
fs/ubifs/replay.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/ubifs/replay.c b/fs/ubifs/replay.c
index b69ffac7e415..2f8d8f4f411a 100644
--- a/fs/ubifs/replay.c
+++ b/fs/ubifs/replay.c
@@ -931,8 +931,6 @@ static int add_replay_bud(struct ubifs_info *c, int lnum, int offs, int jhead,
* validate_ref - validate a reference node.
* @c: UBIFS file-system description object
* @ref: the reference node to validate
- * @ref_lnum: LEB number of the reference node
- * @ref_offs: reference node offset
*
* This function returns %1 if a bud reference already exists for the LEB. %0 is
* returned if the reference node is new, otherwise %-EINVAL is returned if
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH -next 3/4] ubifs: Fix some kernel-doc warnings in replay.c
@ 2020-09-14 13:56 ` Wang Hai
0 siblings, 0 replies; 12+ messages in thread
From: Wang Hai @ 2020-09-14 13:56 UTC (permalink / raw)
To: richard; +Cc: linux-mtd, linux-kernel
Fixes the following W=1 kernel build warning(s):
fs/ubifs/replay.c:942: warning: Excess function parameter 'ref_lnum' description in 'validate_ref'
fs/ubifs/replay.c:942: warning: Excess function parameter 'ref_offs' description in 'validate_ref'
They're not in use. Remove them.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
fs/ubifs/replay.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/ubifs/replay.c b/fs/ubifs/replay.c
index b69ffac7e415..2f8d8f4f411a 100644
--- a/fs/ubifs/replay.c
+++ b/fs/ubifs/replay.c
@@ -931,8 +931,6 @@ static int add_replay_bud(struct ubifs_info *c, int lnum, int offs, int jhead,
* validate_ref - validate a reference node.
* @c: UBIFS file-system description object
* @ref: the reference node to validate
- * @ref_lnum: LEB number of the reference node
- * @ref_offs: reference node offset
*
* This function returns %1 if a bud reference already exists for the LEB. %0 is
* returned if the reference node is new, otherwise %-EINVAL is returned if
--
2.17.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH -next 4/4] ubifs: Fix some kernel-doc warnings in tnc.c
2020-09-14 13:56 ` Wang Hai
@ 2020-09-14 13:56 ` Wang Hai
-1 siblings, 0 replies; 12+ messages in thread
From: Wang Hai @ 2020-09-14 13:56 UTC (permalink / raw)
To: richard; +Cc: linux-mtd, linux-kernel
Fixes the following W=1 kernel build warning(s):
fs/ubifs/tnc.c:3479: warning: Excess function parameter 'inum' description in 'dbg_check_inode_size'
fs/ubifs/tnc.c:366: warning: Excess function parameter 'node' description in 'lnc_free'
@inum in 'dbg_check_inode_size' should be @inode, fix it.
@node in 'lnc_free' is not in use, Remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
fs/ubifs/tnc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ubifs/tnc.c b/fs/ubifs/tnc.c
index f609f6cdde70..de21625804a9 100644
--- a/fs/ubifs/tnc.c
+++ b/fs/ubifs/tnc.c
@@ -360,7 +360,6 @@ static int lnc_add_directly(struct ubifs_info *c, struct ubifs_zbranch *zbr,
/**
* lnc_free - remove a leaf node from the leaf node cache.
* @zbr: zbranch of leaf node
- * @node: leaf node
*/
static void lnc_free(struct ubifs_zbranch *zbr)
{
@@ -3466,7 +3465,7 @@ int ubifs_dirty_idx_node(struct ubifs_info *c, union ubifs_key *key, int level,
/**
* dbg_check_inode_size - check if inode size is correct.
* @c: UBIFS file-system description object
- * @inum: inode number
+ * @inode: inode to check
* @size: inode size
*
* This function makes sure that the inode size (@size) is correct and it does
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH -next 4/4] ubifs: Fix some kernel-doc warnings in tnc.c
@ 2020-09-14 13:56 ` Wang Hai
0 siblings, 0 replies; 12+ messages in thread
From: Wang Hai @ 2020-09-14 13:56 UTC (permalink / raw)
To: richard; +Cc: linux-mtd, linux-kernel
Fixes the following W=1 kernel build warning(s):
fs/ubifs/tnc.c:3479: warning: Excess function parameter 'inum' description in 'dbg_check_inode_size'
fs/ubifs/tnc.c:366: warning: Excess function parameter 'node' description in 'lnc_free'
@inum in 'dbg_check_inode_size' should be @inode, fix it.
@node in 'lnc_free' is not in use, Remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
fs/ubifs/tnc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ubifs/tnc.c b/fs/ubifs/tnc.c
index f609f6cdde70..de21625804a9 100644
--- a/fs/ubifs/tnc.c
+++ b/fs/ubifs/tnc.c
@@ -360,7 +360,6 @@ static int lnc_add_directly(struct ubifs_info *c, struct ubifs_zbranch *zbr,
/**
* lnc_free - remove a leaf node from the leaf node cache.
* @zbr: zbranch of leaf node
- * @node: leaf node
*/
static void lnc_free(struct ubifs_zbranch *zbr)
{
@@ -3466,7 +3465,7 @@ int ubifs_dirty_idx_node(struct ubifs_info *c, union ubifs_key *key, int level,
/**
* dbg_check_inode_size - check if inode size is correct.
* @c: UBIFS file-system description object
- * @inum: inode number
+ * @inode: inode to check
* @size: inode size
*
* This function makes sure that the inode size (@size) is correct and it does
--
2.17.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH -next 0/4] ubifs: Fix some kernel-doc warnings for ubifs
2020-09-14 13:56 ` Wang Hai
@ 2020-09-17 21:01 ` Richard Weinberger
-1 siblings, 0 replies; 12+ messages in thread
From: Richard Weinberger @ 2020-09-17 21:01 UTC (permalink / raw)
To: Wang Hai; +Cc: Richard Weinberger, linux-mtd, LKML
On Mon, Sep 14, 2020 at 4:06 PM Wang Hai <wanghai38@huawei.com> wrote:
>
> In the ubifs module, there are some kernel-doc warnings,
> this series of patches can fix these warnings.
>
> Wang Hai (4):
> ubifs: Fix 'hash' kernel-doc warning in auth.c
> ubifs: Fix some kernel-doc warnings in gc.c
> ubifs: Fix some kernel-doc warnings in replay.c
> ubifs: Fix some kernel-doc warnings in tnc.c
Applied to next, thanks!
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next 0/4] ubifs: Fix some kernel-doc warnings for ubifs
@ 2020-09-17 21:01 ` Richard Weinberger
0 siblings, 0 replies; 12+ messages in thread
From: Richard Weinberger @ 2020-09-17 21:01 UTC (permalink / raw)
To: Wang Hai; +Cc: Richard Weinberger, linux-mtd, LKML
On Mon, Sep 14, 2020 at 4:06 PM Wang Hai <wanghai38@huawei.com> wrote:
>
> In the ubifs module, there are some kernel-doc warnings,
> this series of patches can fix these warnings.
>
> Wang Hai (4):
> ubifs: Fix 'hash' kernel-doc warning in auth.c
> ubifs: Fix some kernel-doc warnings in gc.c
> ubifs: Fix some kernel-doc warnings in replay.c
> ubifs: Fix some kernel-doc warnings in tnc.c
Applied to next, thanks!
--
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 12+ messages in thread