* [PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins
@ 2017-05-17 20:41 ` Thomas Meyer
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Meyer @ 2017-05-17 20:41 UTC (permalink / raw)
To: Linux Kernel Mailing List, user-mode-linux-devel
For some reasons I don't know users-offsets.s get's build before the
gcc-plugins itself.
This patch fixes the problem by not using the gcc-plugins for building
user-offsets.s
make order example:
$ make ARCH=um
CHK include/generated/uapi/linux/version.h
HOSTCC scripts/basic/fixdep
HOSTCC scripts/basic/bin2c
HOSTCC scripts/unifdef
CC arch/x86/um/user-offsets.s
CHK include/generated/user_constants.h
CHK include/config/kernel.release
CHK include/generated/utsrelease.h
HOSTCXX -fPIC scripts/gcc-plugins/latent_entropy_plugin.o
HOSTLLD -shared scripts/gcc-plugins/latent_entropy_plugin.so
HOSTCXX -fPIC scripts/gcc-plugins/structleak_plugin.o
HOSTLLD -shared scripts/gcc-plugins/structleak_plugin.so
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
arch/x86/um/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/um/Makefile b/arch/x86/um/Makefile
index 46cbbfe..d67c78a 100644
--- a/arch/x86/um/Makefile
+++ b/arch/x86/um/Makefile
@@ -36,7 +36,7 @@ subarch-$(CONFIG_MODULES) += ../kernel/module.o
USER_OBJS := bugs_$(BITS).o ptrace_user.o fault.o
extra-y += user-offsets.s
-$(obj)/user-offsets.s: c_flags = -Wp,-MD,$(depfile) $(USER_CFLAGS) \
+$(obj)/user-offsets.s: c_flags = -Wp,-MD,$(depfile) $(filter-out $(GCC_PLUGINS_CFLAGS), $(USER_CFLAGS) ) \
-Iarch/x86/include/generated
UNPROFILE_OBJS := stub_segv.o
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [uml-devel] [PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins
@ 2017-05-17 20:41 ` Thomas Meyer
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Meyer @ 2017-05-17 20:41 UTC (permalink / raw)
To: Linux Kernel Mailing List, user-mode-linux-devel
For some reasons I don't know users-offsets.s get's build before the
gcc-plugins itself.
This patch fixes the problem by not using the gcc-plugins for building
user-offsets.s
make order example:
$ make ARCH=um
CHK include/generated/uapi/linux/version.h
HOSTCC scripts/basic/fixdep
HOSTCC scripts/basic/bin2c
HOSTCC scripts/unifdef
CC arch/x86/um/user-offsets.s
CHK include/generated/user_constants.h
CHK include/config/kernel.release
CHK include/generated/utsrelease.h
HOSTCXX -fPIC scripts/gcc-plugins/latent_entropy_plugin.o
HOSTLLD -shared scripts/gcc-plugins/latent_entropy_plugin.so
HOSTCXX -fPIC scripts/gcc-plugins/structleak_plugin.o
HOSTLLD -shared scripts/gcc-plugins/structleak_plugin.so
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
arch/x86/um/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/um/Makefile b/arch/x86/um/Makefile
index 46cbbfe..d67c78a 100644
--- a/arch/x86/um/Makefile
+++ b/arch/x86/um/Makefile
@@ -36,7 +36,7 @@ subarch-$(CONFIG_MODULES) += ../kernel/module.o
USER_OBJS := bugs_$(BITS).o ptrace_user.o fault.o
extra-y += user-offsets.s
-$(obj)/user-offsets.s: c_flags = -Wp,-MD,$(depfile) $(USER_CFLAGS) \
+$(obj)/user-offsets.s: c_flags = -Wp,-MD,$(depfile) $(filter-out $(GCC_PLUGINS_CFLAGS), $(USER_CFLAGS) ) \
-Iarch/x86/include/generated
UNPROFILE_OBJS := stub_segv.o
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [uml-devel] [PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins
2017-05-17 20:41 ` [uml-devel] " Thomas Meyer
(?)
@ 2017-05-21 21:30 ` Richard Weinberger
2017-07-07 21:10 ` [uml-devel] [PATCH] um: Fix gcc-plugins dependency Thomas Meyer
-1 siblings, 1 reply; 6+ messages in thread
From: Richard Weinberger @ 2017-05-21 21:30 UTC (permalink / raw)
To: Thomas Meyer; +Cc: Linux Kernel Mailing List, user-mode-linux-devel
Thomas,
On Wed, May 17, 2017 at 10:41 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
> For some reasons I don't know users-offsets.s get's build before the
> gcc-plugins itself.
Can you please figure? I want to make sure that we really fix the root cause
and not just papering over a symptom.
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [uml-devel] [PATCH] um: Fix gcc-plugins dependency
2017-05-21 21:30 ` Richard Weinberger
@ 2017-07-07 21:10 ` Thomas Meyer
2017-07-07 22:10 ` Richard Weinberger
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Meyer @ 2017-07-07 21:10 UTC (permalink / raw)
To: user-mode-linux-devel, richard.weinberger
Ensure to build the gcc-plugins for user-offsets.s
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
arch/um/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/um/Makefile b/arch/um/Makefile
index 0ca46ededfc7..7cb04d9da544 100644
--- a/arch/um/Makefile
+++ b/arch/um/Makefile
@@ -146,7 +146,7 @@ archclean:
# Generated files
-$(HOST_DIR)/um/user-offsets.s: __headers FORCE
+$(HOST_DIR)/um/user-offsets.s: gcc-plugins __headers FORCE
$(Q)$(MAKE) $(build)=$(HOST_DIR)/um $@
define filechk_gen-asm-offsets
--
2.13.0
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [uml-devel] [PATCH] um: Fix gcc-plugins dependency
2017-07-07 21:10 ` [uml-devel] [PATCH] um: Fix gcc-plugins dependency Thomas Meyer
@ 2017-07-07 22:10 ` Richard Weinberger
2017-07-09 22:14 ` [uml-devel] [PATCH] um: v2: " Thomas Meyer
0 siblings, 1 reply; 6+ messages in thread
From: Richard Weinberger @ 2017-07-07 22:10 UTC (permalink / raw)
To: Thomas Meyer, user-mode-linux-devel
Thomas,
Am 07.07.2017 um 23:10 schrieb Thomas Meyer:
> Ensure to build the gcc-plugins for user-offsets.s
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Please describe the problem what this commit solves.
IOW the compiler error.
Thanks,
//richard
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [uml-devel] [PATCH] um: v2: Fix gcc-plugins dependency
2017-07-07 22:10 ` Richard Weinberger
@ 2017-07-09 22:14 ` Thomas Meyer
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Meyer @ 2017-07-09 22:14 UTC (permalink / raw)
To: richard, user-mode-linux-devel
Ensure to build the gcc-plugins for user-offsets.s
The target arch/x86/um/user-offsets.s is build with normal CC flags, i.e with
gcc plugins, e.g. -fplugin=./scripts/gcc-plugins/latent_entropy_plugin.so
Ensure to build all gcc-plugins before trying to build this target; else an error
message is thrown:
cc1: error: cannot load plugin ./scripts/gcc-plugins/structleak_plugin.so
./scripts/gcc-plugins/structleak_plugin.so: cannot open shared object file: No such file or directory
cc1: error: cannot load plugin ./scripts/gcc-plugins/latent_entropy_plugin.so
./scripts/gcc-plugins/latent_entropy_plugin.so: cannot open shared object file: No such file or directory
cc1: error: cannot load plugin ./scripts/gcc-plugins/randomize_layout_plugin.so
./scripts/gcc-plugins/randomize_layout_plugin.so: cannot open shared object file: No such file or directory
make[1]: *** [scripts/Makefile.build:154: arch/x86/um/user-offsets.s] Error 1
make: *** [arch/um/Makefile:150: arch/x86/um/user-offsets.s] Error 2
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
arch/um/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/um/Makefile b/arch/um/Makefile
index 0ca46ededfc7..7cb04d9da544 100644
--- a/arch/um/Makefile
+++ b/arch/um/Makefile
@@ -146,7 +146,7 @@ archclean:
# Generated files
-$(HOST_DIR)/um/user-offsets.s: __headers FORCE
+$(HOST_DIR)/um/user-offsets.s: gcc-plugins __headers FORCE
$(Q)$(MAKE) $(build)=$(HOST_DIR)/um $@
define filechk_gen-asm-offsets
--
2.13.0
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-07-09 22:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-17 20:41 [PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins Thomas Meyer
2017-05-17 20:41 ` [uml-devel] " Thomas Meyer
2017-05-21 21:30 ` Richard Weinberger
2017-07-07 21:10 ` [uml-devel] [PATCH] um: Fix gcc-plugins dependency Thomas Meyer
2017-07-07 22:10 ` Richard Weinberger
2017-07-09 22:14 ` [uml-devel] [PATCH] um: v2: " Thomas Meyer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.