* [PATCH] fix the outdated comment in ext2_nfs_get_inode()
@ 2011-08-30 12:11 Li Haifeng
2011-08-30 15:39 ` Jan Kara
0 siblings, 1 reply; 9+ messages in thread
From: Li Haifeng @ 2011-08-30 12:11 UTC (permalink / raw)
To: jack; +Cc: linux-kernel, linux-ext4
I am sorry, the last patch "fix the outdated comment in
ext2_nfs_get_inode()" has some " whitespace errors detected". So
correct it and remake it.
I will be more careful later.
Signed-off-by: Li Haifeng <omycle@gmail.com>
---
fs/ext2/super.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 1dd62ed..bda10cf 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -327,10 +327,9 @@ static struct inode *ext2_nfs_get_inode(struct
super_block *sb,
if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
return ERR_PTR(-ESTALE);
- /* iget isn't really right if the inode is currently unallocated!!
- * ext2_read_inode currently does appropriate checks, but
- * it might be "neater" to call ext2_get_inode first and check
- * if the inode is valid.....
+ /*
+ * ext2_iget isn't really right if the inode is currently unallocated!!
+ * And it also does appropriate checks to handle the stale inode.
*/
inode = ext2_iget(sb, ino);
if (IS_ERR(inode))
--
1.7.4.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] fix the outdated comment in ext2_nfs_get_inode()
2011-08-30 12:11 [PATCH] fix the outdated comment in ext2_nfs_get_inode() Li Haifeng
@ 2011-08-30 15:39 ` Jan Kara
2011-08-31 2:06 ` Li Haifeng
0 siblings, 1 reply; 9+ messages in thread
From: Jan Kara @ 2011-08-30 15:39 UTC (permalink / raw)
To: Li Haifeng; +Cc: jack, linux-kernel, linux-ext4
On Tue 30-08-11 20:11:28, Li Haifeng wrote:
> I am sorry, the last patch "fix the outdated comment in
> ext2_nfs_get_inode()" has some " whitespace errors detected". So
> correct it and remake it.
>
> I will be more careful later.
Hmm, your patch still has mangled whitespaces and wrapped long lines.
Please make sure your mailer doesn't do it or use git send-email to send
patches. Also the subject line misses "ext2:" in the beginning (after
[PATCH]). Finally, I've further changed the text in the comment because
"And" does not really make sense in that context to me. The patch I now
carry in my tree is below.
Honza
>From 8e871fa6a2db8ec615614e547d95de21f9045a52 Mon Sep 17 00:00:00 2001
From: Li Haifeng <omycle@gmail.com>
Date: Tue, 30 Aug 2011 17:32:50 +0200
Subject: [PATCH] ext2: fix the outdated comment in ext2_nfs_get_inode()
Signed-off-by: Li Haifeng <omycle@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/ext2/super.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 174782f..adf3cde 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -327,10 +327,10 @@ static struct inode *ext2_nfs_get_inode(struct super_block *sb,
if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
return ERR_PTR(-ESTALE);
- /* iget isn't really right if the inode is currently unallocated!!
- * ext2_read_inode currently does appropriate checks, but
- * it might be "neater" to call ext2_get_inode first and check
- * if the inode is valid.....
+ /*
+ * ext2_iget isn't quite right if the inode is currently unallocated!
+ * However ext2_iget currently does appropriate checks to handle stale
+ * inodes so everything is OK.
*/
inode = ext2_iget(sb, ino);
if (IS_ERR(inode))
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] fix the outdated comment in ext2_nfs_get_inode()
2011-08-30 15:39 ` Jan Kara
@ 2011-08-31 2:06 ` Li Haifeng
0 siblings, 0 replies; 9+ messages in thread
From: Li Haifeng @ 2011-08-31 2:06 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-kernel, linux-ext4
Thanks, Jan.
2011/8/30 Jan Kara <jack@suse.cz>:
> On Tue 30-08-11 20:11:28, Li Haifeng wrote:
>> I am sorry, the last patch "fix the outdated comment in
>> ext2_nfs_get_inode()" has some " whitespace errors detected". So
>> correct it and remake it.
>>
>> I will be more careful later.
> Hmm, your patch still has mangled whitespaces and wrapped long lines.
> Please make sure your mailer doesn't do it or use git send-email to send
> patches. Also the subject line misses "ext2:" in the beginning (after
> [PATCH]). Finally, I've further changed the text in the comment because
> "And" does not really make sense in that context to me. The patch I now
> carry in my tree is below.
>
> Honza
>
> From 8e871fa6a2db8ec615614e547d95de21f9045a52 Mon Sep 17 00:00:00 2001
> From: Li Haifeng <omycle@gmail.com>
> Date: Tue, 30 Aug 2011 17:32:50 +0200
> Subject: [PATCH] ext2: fix the outdated comment in ext2_nfs_get_inode()
>
> Signed-off-by: Li Haifeng <omycle@gmail.com>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/ext2/super.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 174782f..adf3cde 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -327,10 +327,10 @@ static struct inode *ext2_nfs_get_inode(struct super_block *sb,
> if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
> return ERR_PTR(-ESTALE);
>
> - /* iget isn't really right if the inode is currently unallocated!!
> - * ext2_read_inode currently does appropriate checks, but
> - * it might be "neater" to call ext2_get_inode first and check
> - * if the inode is valid.....
> + /*
> + * ext2_iget isn't quite right if the inode is currently unallocated!
> + * However ext2_iget currently does appropriate checks to handle stale
> + * inodes so everything is OK.
> */
> inode = ext2_iget(sb, ino);
> if (IS_ERR(inode))
> --
> 1.7.1
>
--
Li Haifeng
Laboratory of Service Computing Technology and System
Home page:http://tek-life.org
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] fix the outdated comment in ext2_nfs_get_inode()
@ 2011-08-31 2:06 ` Li Haifeng
0 siblings, 0 replies; 9+ messages in thread
From: Li Haifeng @ 2011-08-31 2:06 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-kernel, linux-ext4
Thanks, Jan.
2011/8/30 Jan Kara <jack@suse.cz>:
> On Tue 30-08-11 20:11:28, Li Haifeng wrote:
>> I am sorry, the last patch "fix the outdated comment in
>> ext2_nfs_get_inode()" has some " whitespace errors detected". So
>> correct it and remake it.
>>
>> I will be more careful later.
> Hmm, your patch still has mangled whitespaces and wrapped long lines.
> Please make sure your mailer doesn't do it or use git send-email to send
> patches. Also the subject line misses "ext2:" in the beginning (after
> [PATCH]). Finally, I've further changed the text in the comment because
> "And" does not really make sense in that context to me. The patch I now
> carry in my tree is below.
>
> Honza
>
> From 8e871fa6a2db8ec615614e547d95de21f9045a52 Mon Sep 17 00:00:00 2001
> From: Li Haifeng <omycle@gmail.com>
> Date: Tue, 30 Aug 2011 17:32:50 +0200
> Subject: [PATCH] ext2: fix the outdated comment in ext2_nfs_get_inode()
>
> Signed-off-by: Li Haifeng <omycle@gmail.com>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/ext2/super.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 174782f..adf3cde 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -327,10 +327,10 @@ static struct inode *ext2_nfs_get_inode(struct super_block *sb,
> if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
> return ERR_PTR(-ESTALE);
>
> - /* iget isn't really right if the inode is currently unallocated!!
> - * ext2_read_inode currently does appropriate checks, but
> - * it might be "neater" to call ext2_get_inode first and check
> - * if the inode is valid.....
> + /*
> + * ext2_iget isn't quite right if the inode is currently unallocated!
> + * However ext2_iget currently does appropriate checks to handle stale
> + * inodes so everything is OK.
> */
> inode = ext2_iget(sb, ino);
> if (IS_ERR(inode))
> --
> 1.7.1
>
--
Li Haifeng
Laboratory of Service Computing Technology and System
Home page:http://tek-life.org
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] fix the outdated comment in ext2_nfs_get_inode()
@ 2011-08-30 11:46 Li Haifeng
0 siblings, 0 replies; 9+ messages in thread
From: Li Haifeng @ 2011-08-30 11:46 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-kernel, linux-ext4
Signed-off-by: Li Haifeng <omycle@gmail.com>
---
fs/ext2/super.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 1dd62ed..bda10cf 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -327,10 +327,9 @@ static struct inode *ext2_nfs_get_inode(struct
super_block *sb,
if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
return ERR_PTR(-ESTALE);
- /* iget isn't really right if the inode is currently unallocated!!
- * ext2_read_inode currently does appropriate checks, but
- * it might be "neater" to call ext2_get_inode first and check
- * if the inode is valid.....
+ /*
+ * ext2_iget isn't really right if the inode is currently unallocated!!
+ * And it also does appropriate checks to handle the stale inode.
*/
inode = ext2_iget(sb, ino);
if (IS_ERR(inode))
--
1.7.4.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] fix the outdated comment in ext2_nfs_get_inode()
2011-08-30 10:35 ` Jan Kara
@ 2011-08-30 11:29 ` Li Haifeng
0 siblings, 0 replies; 9+ messages in thread
From: Li Haifeng @ 2011-08-30 11:29 UTC (permalink / raw)
To: linux-ext4; +Cc: linux-kernel
Thanks for your point. I will remake this patch.
2011/8/30 Jan Kara <jack@suse.cz>
>
> On Tue 30-08-11 17:53:58, Li Haifeng wrote:
> > The function iget referred by the comment is replaced by ext2_iget .
> > And the ext2_read_inode() is not exist, the ext2_iget is "neater". So
> > the comment is fixed here.
> >
> > Signed-off-by: Li Haifeng <omycle@gmail.com>
> > ---
> > fs/ext2/super.c | 6 ++----
> > 1 files changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> > index 1dd62ed..994ced3 100644
> > --- a/fs/ext2/super.c
> > +++ b/fs/ext2/super.c
> > @@ -327,10 +327,8 @@ static struct inode *ext2_nfs_get_inode(struct
> > super_block *sb,
> > if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
> > return ERR_PTR(-ESTALE);
> >
> > - /* iget isn't really right if the inode is currently unallocated!!
> > - * ext2_read_inode currently does appropriate checks, but
> > - * it might be "neater" to call ext2_get_inode first and check
> > - * if the inode is valid.....
> > + /*
> > + * ext2_iget isn't really right if the inode is currently unallocated!!
> OK, but we should keep there a note that ext2_iget() does appropriate
> checks to handle stale inodes.
>
> Honza
> > */
> > inode = ext2_iget(sb, ino);
> > if (IS_ERR(inode))
> > --
> > 1.7.4.1
> --
> Jan Kara <jack@suse.cz>
> SUSE Labs, CR
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] fix the outdated comment in ext2_nfs_get_inode()
@ 2011-08-30 11:29 ` Li Haifeng
0 siblings, 0 replies; 9+ messages in thread
From: Li Haifeng @ 2011-08-30 11:29 UTC (permalink / raw)
To: linux-ext4; +Cc: linux-kernel
Thanks for your point. I will remake this patch.
2011/8/30 Jan Kara <jack@suse.cz>
>
> On Tue 30-08-11 17:53:58, Li Haifeng wrote:
> > The function iget referred by the comment is replaced by ext2_iget .
> > And the ext2_read_inode() is not exist, the ext2_iget is "neater". So
> > the comment is fixed here.
> >
> > Signed-off-by: Li Haifeng <omycle@gmail.com>
> > ---
> > fs/ext2/super.c | 6 ++----
> > 1 files changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> > index 1dd62ed..994ced3 100644
> > --- a/fs/ext2/super.c
> > +++ b/fs/ext2/super.c
> > @@ -327,10 +327,8 @@ static struct inode *ext2_nfs_get_inode(struct
> > super_block *sb,
> > if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
> > return ERR_PTR(-ESTALE);
> >
> > - /* iget isn't really right if the inode is currently unallocated!!
> > - * ext2_read_inode currently does appropriate checks, but
> > - * it might be "neater" to call ext2_get_inode first and check
> > - * if the inode is valid.....
> > + /*
> > + * ext2_iget isn't really right if the inode is currently unallocated!!
> OK, but we should keep there a note that ext2_iget() does appropriate
> checks to handle stale inodes.
>
> Honza
> > */
> > inode = ext2_iget(sb, ino);
> > if (IS_ERR(inode))
> > --
> > 1.7.4.1
> --
> Jan Kara <jack@suse.cz>
> SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] fix the outdated comment in ext2_nfs_get_inode()
2011-08-30 9:53 Li Haifeng
@ 2011-08-30 10:35 ` Jan Kara
2011-08-30 11:29 ` Li Haifeng
0 siblings, 1 reply; 9+ messages in thread
From: Jan Kara @ 2011-08-30 10:35 UTC (permalink / raw)
To: Li Haifeng; +Cc: jack, linux-kernel, linux-ext4
On Tue 30-08-11 17:53:58, Li Haifeng wrote:
> The function iget referred by the comment is replaced by ext2_iget .
> And the ext2_read_inode() is not exist, the ext2_iget is "neater". So
> the comment is fixed here.
>
> Signed-off-by: Li Haifeng <omycle@gmail.com>
> ---
> fs/ext2/super.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 1dd62ed..994ced3 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -327,10 +327,8 @@ static struct inode *ext2_nfs_get_inode(struct
> super_block *sb,
> if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
> return ERR_PTR(-ESTALE);
>
> - /* iget isn't really right if the inode is currently unallocated!!
> - * ext2_read_inode currently does appropriate checks, but
> - * it might be "neater" to call ext2_get_inode first and check
> - * if the inode is valid.....
> + /*
> + * ext2_iget isn't really right if the inode is currently unallocated!!
OK, but we should keep there a note that ext2_iget() does appropriate
checks to handle stale inodes.
Honza
> */
> inode = ext2_iget(sb, ino);
> if (IS_ERR(inode))
> --
> 1.7.4.1
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] fix the outdated comment in ext2_nfs_get_inode()
@ 2011-08-30 9:53 Li Haifeng
2011-08-30 10:35 ` Jan Kara
0 siblings, 1 reply; 9+ messages in thread
From: Li Haifeng @ 2011-08-30 9:53 UTC (permalink / raw)
To: jack; +Cc: linux-kernel, linux-ext4
The function iget referred by the comment is replaced by ext2_iget .
And the ext2_read_inode() is not exist, the ext2_iget is "neater". So
the comment is fixed here.
Signed-off-by: Li Haifeng <omycle@gmail.com>
---
fs/ext2/super.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 1dd62ed..994ced3 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -327,10 +327,8 @@ static struct inode *ext2_nfs_get_inode(struct
super_block *sb,
if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
return ERR_PTR(-ESTALE);
- /* iget isn't really right if the inode is currently unallocated!!
- * ext2_read_inode currently does appropriate checks, but
- * it might be "neater" to call ext2_get_inode first and check
- * if the inode is valid.....
+ /*
+ * ext2_iget isn't really right if the inode is currently unallocated!!
*/
inode = ext2_iget(sb, ino);
if (IS_ERR(inode))
--
1.7.4.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-08-31 2:06 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-30 12:11 [PATCH] fix the outdated comment in ext2_nfs_get_inode() Li Haifeng
2011-08-30 15:39 ` Jan Kara
2011-08-31 2:06 ` Li Haifeng
2011-08-31 2:06 ` Li Haifeng
-- strict thread matches above, loose matches on Subject: below --
2011-08-30 11:46 Li Haifeng
2011-08-30 9:53 Li Haifeng
2011-08-30 10:35 ` Jan Kara
2011-08-30 11:29 ` Li Haifeng
2011-08-30 11:29 ` Li Haifeng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.