[U-Boot] [PATCH] openrd: Once again shrink binary size

[U-Boot] [PATCH] openrd: Once again shrink binary size

[Tom Rini]

With some recent changes to relevant drivers here the openrd board
(openrd_client in this case) does not fit within its size constraint.
We can however drop the slightly extended baudrate table and then the
duplication of mtdparts/mtdids in the default environment.  These
defaults are set in the environment by the 'mtdparts' command and
otherwise referenced throughout the code.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
 include/configs/mv-common.h | 8 --------
 include/configs/openrd.h    | 4 +---
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/include/configs/mv-common.h b/include/configs/mv-common.h
index 79d61c599e54..8ae521f7e986 100644
--- a/include/configs/mv-common.h
+++ b/include/configs/mv-common.h
@@ -38,14 +38,6 @@
 #define CONFIG_SYS_NS16550_COM1		MV_UART_CONSOLE_BASE
 #endif
 
-/*
- * Serial Port configuration
- * The following definitions let you select what serial you want to use
- * for your console driver.
- */
-
-#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, \
-					  115200,230400, 460800, 921600 }
 /* auto boot */
 #define CONFIG_PREBOOT
 
diff --git a/include/configs/openrd.h b/include/configs/openrd.h
index 2b21003b8b75..17611bc56873 100644
--- a/include/configs/openrd.h
+++ b/include/configs/openrd.h
@@ -60,9 +60,7 @@
 	CONFIG_MTDPARTS_DEFAULT " rw ubi.mtd=2,2048\0" \
 	"x_bootcmd_kernel=nand read 0x6400000 0x100000 0x300000\0"	\
 	"x_bootcmd_usb=usb start\0"					\
-	"x_bootargs_root=root=ubi0:rootfs rootfstype=ubifs\0"		\
-	"mtdids="CONFIG_MTDIDS_DEFAULT"\0"					\
-	"mtdparts="CONFIG_MTDPARTS_DEFAULT"\0"
+	"x_bootargs_root=root=ubi0:rootfs rootfstype=ubifs\0"
 
 /*
  * Ethernet Driver configuration
-- 
2.7.4

[U-Boot] [PATCH] openrd: Once again shrink binary size

[Tom Rini]

On Fri, Jul 27, 2018 at 07:59:31AM -0400, Tom Rini wrote:

> With some recent changes to relevant drivers here the openrd board
> (openrd_client in this case) does not fit within its size constraint.
> We can however drop the slightly extended baudrate table and then the
> duplication of mtdparts/mtdids in the default environment.  These
> defaults are set in the environment by the 'mtdparts' command and
> otherwise referenced throughout the code.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180727/37de8685/attachment.sig>

[U-Boot] [PATCH] openrd: Once again shrink binary size

[Chris Packham]

On Fri, Jul 27, 2018 at 11:59 PM Tom Rini <trini@konsulko.com> wrote:
>
> With some recent changes to relevant drivers here the openrd board
> (openrd_client in this case) does not fit within its size constraint.
> We can however drop the slightly extended baudrate table and then the
> duplication of mtdparts/mtdids in the default environment.  These
> defaults are set in the environment by the 'mtdparts' command and
> otherwise referenced throughout the code.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>

We could probably shrink things further by disabling jffs2 and only
supporting ubifs. Similarly having support for both fat and ext4 is
taking up much of the image although it may be less desirable to pick
only one of these since either of those file systems could be on
removable media.

[U-Boot] [PATCH] openrd: Once again shrink binary size

[Tom Rini]

On Wed, Aug 01, 2018 at 08:40:18PM +1200, Chris Packham wrote:

> On Fri, Jul 27, 2018 at 11:59 PM Tom Rini <trini@konsulko.com> wrote:
> >
> > With some recent changes to relevant drivers here the openrd board
> > (openrd_client in this case) does not fit within its size constraint.
> > We can however drop the slightly extended baudrate table and then the
> > duplication of mtdparts/mtdids in the default environment.  These
> > defaults are set in the environment by the 'mtdparts' command and
> > otherwise referenced throughout the code.
> >
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> 
> We could probably shrink things further by disabling jffs2 and only
> supporting ubifs. Similarly having support for both fat and ext4 is
> taking up much of the image although it may be less desirable to pick
> only one of these since either of those file systems could be on
> removable media.

Ah, so, did you also see my email marking the platforms as orphaned?  If
so, please feel free to pick them up and trim the config down :)
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180801/bdf91f23/attachment.sig>

[U-Boot] [PATCH] openrd: Once again shrink binary size

[Chris Packham]

On Wed, 1 Aug 2018, 11:18 PM Tom Rini, <trini@konsulko.com> wrote:

> On Wed, Aug 01, 2018 at 08:40:18PM +1200, Chris Packham wrote:
>
> > On Fri, Jul 27, 2018 at 11:59 PM Tom Rini <trini@konsulko.com> wrote:
> > >
> > > With some recent changes to relevant drivers here the openrd board
> > > (openrd_client in this case) does not fit within its size constraint.
> > > We can however drop the slightly extended baudrate table and then the
> > > duplication of mtdparts/mtdids in the default environment.  These
> > > defaults are set in the environment by the 'mtdparts' command and
> > > otherwise referenced throughout the code.
> > >
> > > Signed-off-by: Tom Rini <trini@konsulko.com>
> >
> > We could probably shrink things further by disabling jffs2 and only
> > supporting ubifs. Similarly having support for both fat and ext4 is
> > taking up much of the image although it may be less desirable to pick
> > only one of these since either of those file systems could be on
> > removable media.
>
> Ah, so, did you also see my email marking the platforms as orphaned?  If
> so, please feel free to pick them up and trim the config down :)
> Thanks!
>

Yep I did. I'm happy to put some effort into trimming them down but I don't
have any genuine openrd hardware to test on (I do have some custom kirkwood
based boards).

I can do some basic things (like disabling jffs2) but I'd be hesitant to do
more involved things like converting to devicetree without actual hardware
to test on. Hopefully we can find someone with access to the real thing.