All of lore.kernel.org
 help / color / mirror / Atom feed
From: gokul cg <gokuljnpr@gmail.com>
To: Thomas Tai <thomas.tai@oracle.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: Possible race condition in the kernel between PCI driver and AER handling
Date: Thu, 2 Aug 2018 00:22:07 +0530	[thread overview]
Message-ID: <CAFP4jM-=EvrLyybxEcpObQOrLS1z8CHG0q0xJZYJUxgtNKQBSw@mail.gmail.com> (raw)
In-Reply-To: <ecb55fb1-c3af-4f5b-86d2-1c669fa9f9ca@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

HI Thomas ,


Yes , its surprise removal .

But as far as I know , linux kernel will handle surprise removal of PCIe
device without panic.

The driver will suddenly start reading all 0xff and will then need to
abort whatever it was doing. Usually all drivers handle this just fine.

Nothing, the driver individually needs to handle the fact that it might
at any time, start getting invalid data. If it doesn't, it needs to be
fixed. Whether AER  driver that does not handle this properly?


Regards,
Gokul

On Wed, Aug 1, 2018 at 11:17 PM, Thomas Tai <thomas.tai@oracle.com> wrote:

>
>
> On 08/01/2018 01:42 AM, gokul cg wrote:
>
>> Hi Thomas,
>>
>> In my hardware, there is i2c power control chip for PCI card, I just
>> powered down using i2c command .
>>
>
> Hi Gokul,
> When you power off the card via the i2c, it forcefully power off the card
> without notify the kernel? That is, during the card power off sequence it
> manages to send a last AER isr to report the error and die? I am kind of
> expect the pcie surprise removal or hot plug driver will handle it
> correctly.
>
> Thanks,
> Thomas
>
>
>> Regards,
>> Gokul
>>
>

[-- Attachment #2: Type: text/html, Size: 4641 bytes --]

  reply	other threads:[~2018-08-01 20:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 12:42 Possible race condition in the kernel between PCI driver and AER handling gokul cg
2018-07-31 13:15 ` Thomas Tai
2018-08-01  5:42   ` gokul cg
2018-08-01 14:17     ` Thomas Tai
2018-08-01 17:47     ` Thomas Tai
2018-08-01 18:52       ` gokul cg [this message]
2018-08-01  5:53   ` gokul cg
2018-08-01 14:24     ` Thomas Tai
2018-08-01 15:22       ` gokul cg
2018-08-02 14:17       ` Thomas Tai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFP4jM-=EvrLyybxEcpObQOrLS1z8CHG0q0xJZYJUxgtNKQBSw@mail.gmail.com' \
    --to=gokuljnpr@gmail.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=thomas.tai@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.