All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/cage: only enable XWayland if wlroots has X11
@ 2021-12-25  5:08 Yunhao Tian
  2021-12-25 15:31 ` Yann E. MORIN
  2022-01-24 17:14 ` Peter Korsgaard
  0 siblings, 2 replies; 4+ messages in thread
From: Yunhao Tian @ 2021-12-25  5:08 UTC (permalink / raw)
  To: buildroot; +Cc: Adrian Perez de Castro, Yann E . MORIN, Yunhao Tian

Cage requires wlroots to be built with X11 enabled
in order to enable XWayland, otherwise it will fail
with error:

"ERROR: Problem encountered: Cannot build Cage with
XWayland support: wlroots has been built without it"

Signed-off-by: Yunhao Tian <t123yh.xyz@gmail.com>
---
 package/cage/cage.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/cage/cage.mk b/package/cage/cage.mk
index a661857a95..6f1046eb2f 100644
--- a/package/cage/cage.mk
+++ b/package/cage/cage.mk
@@ -11,7 +11,7 @@ CAGE_LICENSE_FILES = LICENSE
 CAGE_DEPENDENCIES = host-pkgconf wlroots
 CAGE_CONF_OPTS = -Dman-pages=disabled
 
-ifeq ($(BR2_PACKAGE_XORG7),y)
+ifeq ($(BR2_PACKAGE_XORG7)$(BR2_PACKAGE_WLROOTS_X11),yy)
 CAGE_CONF_OPTS += -Dxwayland=true
 else
 CAGE_CONF_OPTS += -Dxwayland=false
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/cage: only enable XWayland if wlroots has X11
  2021-12-25  5:08 [Buildroot] [PATCH] package/cage: only enable XWayland if wlroots has X11 Yunhao Tian
@ 2021-12-25 15:31 ` Yann E. MORIN
  2021-12-25 16:16   ` Yunhao Tian
  2022-01-24 17:14 ` Peter Korsgaard
  1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2021-12-25 15:31 UTC (permalink / raw)
  To: Yunhao Tian; +Cc: Adrian Perez de Castro, buildroot

Yunhao, All,

On 2021-12-25 13:08 +0800, Yunhao Tian spake thusly:
> Cage requires wlroots to be built with X11 enabled
> in order to enable XWayland, otherwise it will fail
> with error:
> 
> "ERROR: Problem encountered: Cannot build Cage with
> XWayland support: wlroots has been built without it"
> 
> Signed-off-by: Yunhao Tian <t123yh.xyz@gmail.com>
> ---
>  package/cage/cage.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/cage/cage.mk b/package/cage/cage.mk
> index a661857a95..6f1046eb2f 100644
> --- a/package/cage/cage.mk
> +++ b/package/cage/cage.mk
> @@ -11,7 +11,7 @@ CAGE_LICENSE_FILES = LICENSE
>  CAGE_DEPENDENCIES = host-pkgconf wlroots
>  CAGE_CONF_OPTS = -Dman-pages=disabled
>  
> -ifeq ($(BR2_PACKAGE_XORG7),y)
> +ifeq ($(BR2_PACKAGE_XORG7)$(BR2_PACKAGE_WLROOTS_X11),yy)

BR2_PACKAGE_WLROOTS_X11 already depends on BR2_PACKAGE_XORG7, so keeping
BR2_PACKAGE_XORG7 in this codition is redundant, so I dropped it.

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  CAGE_CONF_OPTS += -Dxwayland=true
>  else
>  CAGE_CONF_OPTS += -Dxwayland=false
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/cage: only enable XWayland if wlroots has X11
  2021-12-25 15:31 ` Yann E. MORIN
@ 2021-12-25 16:16   ` Yunhao Tian
  0 siblings, 0 replies; 4+ messages in thread
From: Yunhao Tian @ 2021-12-25 16:16 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: Adrian Perez de Castro, buildroot

Hi all,

I'm still not able to get XWayland working under cage, because
/usr/bin/XWayland is not found. I couldn't find an option in Buildroot
to build this binary. I would like to ask if there's any thing I'm missing?

Regards,
Yunhao


Yann E. MORIN <yann.morin.1998@free.fr> 于2021年12月25日周六 23:31写道:
>
> Yunhao, All,
>
> On 2021-12-25 13:08 +0800, Yunhao Tian spake thusly:
> > Cage requires wlroots to be built with X11 enabled
> > in order to enable XWayland, otherwise it will fail
> > with error:
> >
> > "ERROR: Problem encountered: Cannot build Cage with
> > XWayland support: wlroots has been built without it"
> >
> > Signed-off-by: Yunhao Tian <t123yh.xyz@gmail.com>
> > ---
> >  package/cage/cage.mk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/cage/cage.mk b/package/cage/cage.mk
> > index a661857a95..6f1046eb2f 100644
> > --- a/package/cage/cage.mk
> > +++ b/package/cage/cage.mk
> > @@ -11,7 +11,7 @@ CAGE_LICENSE_FILES = LICENSE
> >  CAGE_DEPENDENCIES = host-pkgconf wlroots
> >  CAGE_CONF_OPTS = -Dman-pages=disabled
> >
> > -ifeq ($(BR2_PACKAGE_XORG7),y)
> > +ifeq ($(BR2_PACKAGE_XORG7)$(BR2_PACKAGE_WLROOTS_X11),yy)
>
> BR2_PACKAGE_WLROOTS_X11 already depends on BR2_PACKAGE_XORG7, so keeping
> BR2_PACKAGE_XORG7 in this codition is redundant, so I dropped it.
>
> Applied to master, thanks.
>
> Regards,
> Yann E. MORIN.
>
> >  CAGE_CONF_OPTS += -Dxwayland=true
> >  else
> >  CAGE_CONF_OPTS += -Dxwayland=false
> > --
> > 2.25.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/cage: only enable XWayland if wlroots has X11
  2021-12-25  5:08 [Buildroot] [PATCH] package/cage: only enable XWayland if wlroots has X11 Yunhao Tian
  2021-12-25 15:31 ` Yann E. MORIN
@ 2022-01-24 17:14 ` Peter Korsgaard
  1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2022-01-24 17:14 UTC (permalink / raw)
  To: buildroot

On 25/12/2021 06.08, Yunhao Tian wrote:
> Cage requires wlroots to be built with X11 enabled
> in order to enable XWayland, otherwise it will fail
> with error:
> 
> "ERROR: Problem encountered: Cannot build Cage with
> XWayland support: wlroots has been built without it"
> 
> Signed-off-by: Yunhao Tian <t123yh.xyz@gmail.com>

Committed to 2021.02.x / 2021.11.x, thanks.

--
Bye, Peter Korsgaard

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-24 17:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-25  5:08 [Buildroot] [PATCH] package/cage: only enable XWayland if wlroots has X11 Yunhao Tian
2021-12-25 15:31 ` Yann E. MORIN
2021-12-25 16:16   ` Yunhao Tian
2022-01-24 17:14 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.