From: Axel Lin <axel.lin@ingics.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Grant Likely <grant.likely@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Lars Poeschel <poeschel@lemonage.de>,
Peter Korsgaard <jacmet@sunsite.dk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: mcp23s08: Fix build error when CONFIG_SPI_MASTER=y && CONFIG_I2C=m
Date: Sun, 19 May 2013 19:14:59 +0800 [thread overview]
Message-ID: <CAFRkauCDBtubvZs7nZ9-jAJmiJbKWJFZ0OaO_5ofYt17udV0Zw@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vc6U00XvTN91Q=NFKncZSuVNdbC8wPPH-0DdpxQV7UZAA@mail.gmail.com>
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -636,7 +636,7 @@ config GPIO_MAX7301
>>
>> config GPIO_MCP23S08
>> tristate "Microchip MCP23xxx I/O expander"
>> - depends on SPI_MASTER || I2C
>> + depends on (SPI_MASTER && I2C!=m) || I2C
>
> For me it looks like the result of the following will be the same
> depends on (SPI_MASTER && !I2C) || I2C
Yes, I think the result is the same.
I just send a v2.
So you can Ack the version you prefer.
Thanks for the review.
Axel
prev parent reply other threads:[~2013-05-19 11:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-19 6:10 [PATCH] gpio: mcp23s08: Fix build error when CONFIG_SPI_MASTER=y && CONFIG_I2C=m Axel Lin
2013-05-19 7:55 ` Andy Shevchenko
2013-05-19 11:14 ` Axel Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFRkauCDBtubvZs7nZ9-jAJmiJbKWJFZ0OaO_5ofYt17udV0Zw@mail.gmail.com \
--to=axel.lin@ingics.com \
--cc=andy.shevchenko@gmail.com \
--cc=grant.likely@linaro.org \
--cc=jacmet@sunsite.dk \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=poeschel@lemonage.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.