* [PATCH] gpio: mcp23s08: Fix build error when CONFIG_SPI_MASTER=y && CONFIG_I2C=m
@ 2013-05-19 6:10 Axel Lin
2013-05-19 7:55 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2013-05-19 6:10 UTC (permalink / raw)
To: Grant Likely, Linus Walleij; +Cc: Lars Poeschel, Peter Korsgaard, linux-kernel
This patch fixes below build error when CONFIG_SPI_MASTER=y && CONFIG_I2C=m &&
CONFIG_GPIO_MCP23S08=y.
LD init/built-in.o
drivers/built-in.o: In function `mcp23017_write':
clkdev.c:(.text+0x1e14): undefined reference to `i2c_smbus_write_word_data'
drivers/built-in.o: In function `mcp23017_read':
clkdev.c:(.text+0x1e24): undefined reference to `i2c_smbus_read_word_data'
drivers/built-in.o: In function `mcp23008_write':
clkdev.c:(.text+0x1e8c): undefined reference to `i2c_smbus_write_byte_data'
drivers/built-in.o: In function `mcp23008_read':
clkdev.c:(.text+0x1e98): undefined reference to `i2c_smbus_read_byte_data'
drivers/built-in.o: In function `mcp23008_read_regs':
clkdev.c:(.text+0x1ed0): undefined reference to `i2c_smbus_read_byte_data'
drivers/built-in.o: In function `mcp23s08_init':
clkdev.c:(.init.text+0x30): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `mcp23s08_exit':
clkdev.c:(.exit.text+0x30): undefined reference to `i2c_del_driver'
make: *** [vmlinux] Error 1
When CONFIG_I2C=m, meaning we can't build the drivers in with I2C support.
Thus don't allow the drivers to be compiled as built-in when CONFIG_I2C=m.
The real fix though is to break the driver apart into a SPI part, an I2C part
and a common part. But that's something for 3.11 while this is something for
3.10/stable.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 87d5670..6575d77 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -636,7 +636,7 @@ config GPIO_MAX7301
config GPIO_MCP23S08
tristate "Microchip MCP23xxx I/O expander"
- depends on SPI_MASTER || I2C
+ depends on (SPI_MASTER && I2C!=m) || I2C
help
SPI/I2C driver for Microchip MCP23S08/MCP23S17/MCP23008/MCP23017
I/O expanders.
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: mcp23s08: Fix build error when CONFIG_SPI_MASTER=y && CONFIG_I2C=m
2013-05-19 6:10 [PATCH] gpio: mcp23s08: Fix build error when CONFIG_SPI_MASTER=y && CONFIG_I2C=m Axel Lin
@ 2013-05-19 7:55 ` Andy Shevchenko
2013-05-19 11:14 ` Axel Lin
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2013-05-19 7:55 UTC (permalink / raw)
To: Axel Lin
Cc: Grant Likely, Linus Walleij, Lars Poeschel, Peter Korsgaard,
linux-kernel
On Sun, May 19, 2013 at 9:10 AM, Axel Lin <axel.lin@ingics.com> wrote:
> This patch fixes below build error when CONFIG_SPI_MASTER=y && CONFIG_I2C=m &&
> CONFIG_GPIO_MCP23S08=y.
> When CONFIG_I2C=m, meaning we can't build the drivers in with I2C support.
> Thus don't allow the drivers to be compiled as built-in when CONFIG_I2C=m.
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -636,7 +636,7 @@ config GPIO_MAX7301
>
> config GPIO_MCP23S08
> tristate "Microchip MCP23xxx I/O expander"
> - depends on SPI_MASTER || I2C
> + depends on (SPI_MASTER && I2C!=m) || I2C
For me it looks like the result of the following will be the same
depends on (SPI_MASTER && !I2C) || I2C
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: mcp23s08: Fix build error when CONFIG_SPI_MASTER=y && CONFIG_I2C=m
2013-05-19 7:55 ` Andy Shevchenko
@ 2013-05-19 11:14 ` Axel Lin
0 siblings, 0 replies; 3+ messages in thread
From: Axel Lin @ 2013-05-19 11:14 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Grant Likely, Linus Walleij, Lars Poeschel, Peter Korsgaard,
linux-kernel
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -636,7 +636,7 @@ config GPIO_MAX7301
>>
>> config GPIO_MCP23S08
>> tristate "Microchip MCP23xxx I/O expander"
>> - depends on SPI_MASTER || I2C
>> + depends on (SPI_MASTER && I2C!=m) || I2C
>
> For me it looks like the result of the following will be the same
> depends on (SPI_MASTER && !I2C) || I2C
Yes, I think the result is the same.
I just send a v2.
So you can Ack the version you prefer.
Thanks for the review.
Axel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-19 11:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-19 6:10 [PATCH] gpio: mcp23s08: Fix build error when CONFIG_SPI_MASTER=y && CONFIG_I2C=m Axel Lin
2013-05-19 7:55 ` Andy Shevchenko
2013-05-19 11:14 ` Axel Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.