All of lore.kernel.org
 help / color / mirror / Atom feed
* Possible bug compiling Audit 2.6.x against kernel headers older than 3.19
@ 2016-07-06 14:53 Adam Duskett
  2016-07-06 22:52 ` Steve Grubb
  0 siblings, 1 reply; 2+ messages in thread
From: Adam Duskett @ 2016-07-06 14:53 UTC (permalink / raw)
  To: linux-audit

Audit 2.6.x checks for AUDIT_FEATURE_VERSION to be defined in
include/linux/audit.h (this define was introduced in kernel version
3.13) and then blindly assumes that struct audit_status has
feature_bitmap.

However this looks like a problem as feature_bitmap wasn't introduced
until kernel 3.19, even though the requirements for Audit state that anything >
2.6.30 should work.  (http://people.redhat.com/sgrubb/audit/)

This causes a compile error when attempting to compile audit 2.6.x
against kernel headers younger than 3.19.

libaudit.c:609:33: error: 'struct audit_status' has no member named
'feature_bitmap'
features_bitmap = rep.status->feature_bitmap;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Possible bug compiling Audit 2.6.x against kernel headers older than 3.19
  2016-07-06 14:53 Possible bug compiling Audit 2.6.x against kernel headers older than 3.19 Adam Duskett
@ 2016-07-06 22:52 ` Steve Grubb
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Grubb @ 2016-07-06 22:52 UTC (permalink / raw)
  To: linux-audit

On Wednesday, July 6, 2016 10:53:37 AM EDT Adam Duskett wrote:
> Audit 2.6.x checks for AUDIT_FEATURE_VERSION to be defined in
> include/linux/audit.h (this define was introduced in kernel version
> 3.13) and then blindly assumes that struct audit_status has
> feature_bitmap.
> 
> However this looks like a problem as feature_bitmap wasn't introduced
> until kernel 3.19, even though the requirements for Audit state that
> anything > 2.6.30 should work.  (http://people.redhat.com/sgrubb/audit/)

Yes, but this is obvious a mistake. :-)
 
> This causes a compile error when attempting to compile audit 2.6.x
> against kernel headers younger than 3.19.
> 
> libaudit.c:609:33: error: 'struct audit_status' has no member named
> 'feature_bitmap'
> features_bitmap = rep.status->feature_bitmap;

I think this is now fixed in svn. I don't know if you can try a pre-release or 
not. I'll probably do a new release in a few days.

-Steve

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-07-06 22:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-06 14:53 Possible bug compiling Audit 2.6.x against kernel headers older than 3.19 Adam Duskett
2016-07-06 22:52 ` Steve Grubb

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.