All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string
@ 2018-09-18 11:43 Fabio Estevam
  2018-09-18 11:43 ` [PATCH 2/2] ARM: dts: imx6qdl-zii-rdu2: Disable the internal RTC Fabio Estevam
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Fabio Estevam @ 2018-09-18 11:43 UTC (permalink / raw)
  To: linux-arm-kernel

According to Documentation/devicetree/bindings/rtc/rtc-ds1307.txt the
original compatible "maxim,ds1341" is not a valid entry.

Switch to the documented "dallas,ds1341" compatible.

Reported-by: Chris Healy <cphealy@gmail.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
index 469cce2..e45a15c 100644
--- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
+++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
@@ -508,7 +508,7 @@
 	};
 
 	ds1341: rtc at 68 {
-		compatible = "maxim,ds1341";
+		compatible = "dallas,ds1341";
 		reg = <0x68>;
 	};
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/2] ARM: dts: imx6qdl-zii-rdu2: Disable the internal RTC
  2018-09-18 11:43 [PATCH 1/2] ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string Fabio Estevam
@ 2018-09-18 11:43 ` Fabio Estevam
  2018-09-18 16:09   ` Lucas Stach
  2018-09-19 14:45   ` Chris Healy
  2018-09-18 16:09 ` [PATCH 1/2] ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string Lucas Stach
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 7+ messages in thread
From: Fabio Estevam @ 2018-09-18 11:43 UTC (permalink / raw)
  To: linux-arm-kernel

On the imx6qdl-zii-rdu2 board the RTC functionality is provided via
a DS1341 RTC connected via I2C bus, so we can safely disable the internal
one. 

Reported-by: Chris Healy <cphealy@gmail.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index 7fff371..85e79a3 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -813,6 +813,10 @@
 	status = "okay";
 };
 
+&snvs_rtc {
+	status = "disabled";
+};
+
 &ssi1 {
 	status = "okay";
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 1/2] ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string
  2018-09-18 11:43 [PATCH 1/2] ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string Fabio Estevam
  2018-09-18 11:43 ` [PATCH 2/2] ARM: dts: imx6qdl-zii-rdu2: Disable the internal RTC Fabio Estevam
@ 2018-09-18 16:09 ` Lucas Stach
  2018-09-19 14:44 ` Chris Healy
  2018-09-26  9:41 ` Shawn Guo
  3 siblings, 0 replies; 7+ messages in thread
From: Lucas Stach @ 2018-09-18 16:09 UTC (permalink / raw)
  To: linux-arm-kernel

Am Dienstag, den 18.09.2018, 08:43 -0300 schrieb Fabio Estevam:
> According to Documentation/devicetree/bindings/rtc/rtc-ds1307.txt the
> original compatible "maxim,ds1341" is not a valid entry.
> 
> Switch to the documented "dallas,ds1341" compatible.
> 
> Reported-by: Chris Healy <cphealy@gmail.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

> ---
> ?arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> index 469cce2..e45a15c 100644
> --- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
> +++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> @@ -508,7 +508,7 @@
> > ?	};
> ?
> > > ?	ds1341: rtc at 68 {
> > -		compatible = "maxim,ds1341";
> > +		compatible = "dallas,ds1341";
> > ?		reg = <0x68>;
> > ?	};
> ?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/2] ARM: dts: imx6qdl-zii-rdu2: Disable the internal RTC
  2018-09-18 11:43 ` [PATCH 2/2] ARM: dts: imx6qdl-zii-rdu2: Disable the internal RTC Fabio Estevam
@ 2018-09-18 16:09   ` Lucas Stach
  2018-09-19 14:45   ` Chris Healy
  1 sibling, 0 replies; 7+ messages in thread
From: Lucas Stach @ 2018-09-18 16:09 UTC (permalink / raw)
  To: linux-arm-kernel

Am Dienstag, den 18.09.2018, 08:43 -0300 schrieb Fabio Estevam:
> On the imx6qdl-zii-rdu2 board the RTC functionality is provided via
> a DS1341 RTC connected via I2C bus, so we can safely disable the internal
> one.?
> 
> Reported-by: Chris Healy <cphealy@gmail.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

> ---
> ?arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++++
> ?1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 7fff371..85e79a3 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -813,6 +813,10 @@
> > ?	status = "okay";
> ?};
> ?
> +&snvs_rtc {
> > +	status = "disabled";
> +};
> +
> ?&ssi1 {
> > ?	status = "okay";
> ?};

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string
  2018-09-18 11:43 [PATCH 1/2] ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string Fabio Estevam
  2018-09-18 11:43 ` [PATCH 2/2] ARM: dts: imx6qdl-zii-rdu2: Disable the internal RTC Fabio Estevam
  2018-09-18 16:09 ` [PATCH 1/2] ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string Lucas Stach
@ 2018-09-19 14:44 ` Chris Healy
  2018-09-26  9:41 ` Shawn Guo
  3 siblings, 0 replies; 7+ messages in thread
From: Chris Healy @ 2018-09-19 14:44 UTC (permalink / raw)
  To: linux-arm-kernel

> According to Documentation/devicetree/bindings/rtc/rtc-ds1307.txt the
> original compatible "maxim,ds1341" is not a valid entry.
>
> Switch to the documented "dallas,ds1341" compatible.

Tested-by: Chris Healy <cphealy@gmail.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/2] ARM: dts: imx6qdl-zii-rdu2: Disable the internal RTC
  2018-09-18 11:43 ` [PATCH 2/2] ARM: dts: imx6qdl-zii-rdu2: Disable the internal RTC Fabio Estevam
  2018-09-18 16:09   ` Lucas Stach
@ 2018-09-19 14:45   ` Chris Healy
  1 sibling, 0 replies; 7+ messages in thread
From: Chris Healy @ 2018-09-19 14:45 UTC (permalink / raw)
  To: linux-arm-kernel

> On the imx6qdl-zii-rdu2 board the RTC functionality is provided via
> a DS1341 RTC connected via I2C bus, so we can safely disable the internal
> one.

Tested-by: Chris Healy <cphealy@gmail.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string
  2018-09-18 11:43 [PATCH 1/2] ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string Fabio Estevam
                   ` (2 preceding siblings ...)
  2018-09-19 14:44 ` Chris Healy
@ 2018-09-26  9:41 ` Shawn Guo
  3 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2018-09-26  9:41 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Sep 18, 2018 at 08:43:31AM -0300, Fabio Estevam wrote:
> According to Documentation/devicetree/bindings/rtc/rtc-ds1307.txt the
> original compatible "maxim,ds1341" is not a valid entry.
> 
> Switch to the documented "dallas,ds1341" compatible.
> 
> Reported-by: Chris Healy <cphealy@gmail.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Applied both, thanks.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-09-26  9:41 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-18 11:43 [PATCH 1/2] ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string Fabio Estevam
2018-09-18 11:43 ` [PATCH 2/2] ARM: dts: imx6qdl-zii-rdu2: Disable the internal RTC Fabio Estevam
2018-09-18 16:09   ` Lucas Stach
2018-09-19 14:45   ` Chris Healy
2018-09-18 16:09 ` [PATCH 1/2] ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string Lucas Stach
2018-09-19 14:44 ` Chris Healy
2018-09-26  9:41 ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.