* [PATCH] ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size
@ 2017-11-09 23:48 Andrew Lunn
2017-11-10 0:02 ` Chris Healy
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Andrew Lunn @ 2017-11-09 23:48 UTC (permalink / raw)
To: linux-arm-kernel
The two Ethernet switches have an AT24C512 each. This is a 64K device,
not 512 bytes as currently listed in the device tree.
Reported-by: Chris Healy <cphealy@gmail.com>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
index db3b408ea55a..0c557a9e7e17 100644
--- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
+++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
@@ -73,7 +73,7 @@
#size-cells = <0>;
reg = <0>;
dsa,member = <0 0>;
- eeprom-length = <512>;
+ eeprom-length = <65536>;
interrupt-parent = <&gpio0>;
interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
interrupt-controller;
@@ -170,7 +170,7 @@
#size-cells = <0>;
reg = <0>;
dsa,member = <0 1>;
- eeprom-length = <512>;
+ eeprom-length = <65536>;
interrupt-parent = <&gpio0>;
interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
interrupt-controller;
--
2.15.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size
2017-11-09 23:48 [PATCH] ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size Andrew Lunn
@ 2017-11-10 0:02 ` Chris Healy
2017-11-10 0:18 ` Fabio Estevam
2017-11-16 11:19 ` Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Chris Healy @ 2017-11-10 0:02 UTC (permalink / raw)
To: linux-arm-kernel
Reviewed-by: Chris Healy <cphealy@gmail.com>
On Thu, Nov 9, 2017 at 3:48 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> The two Ethernet switches have an AT24C512 each. This is a 64K device,
> not 512 bytes as currently listed in the device tree.
>
> Reported-by: Chris Healy <cphealy@gmail.com>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> index db3b408ea55a..0c557a9e7e17 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> @@ -73,7 +73,7 @@
> #size-cells = <0>;
> reg = <0>;
> dsa,member = <0 0>;
> - eeprom-length = <512>;
> + eeprom-length = <65536>;
> interrupt-parent = <&gpio0>;
> interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
> interrupt-controller;
> @@ -170,7 +170,7 @@
> #size-cells = <0>;
> reg = <0>;
> dsa,member = <0 1>;
> - eeprom-length = <512>;
> + eeprom-length = <65536>;
> interrupt-parent = <&gpio0>;
> interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
> interrupt-controller;
> --
> 2.15.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size
2017-11-09 23:48 [PATCH] ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size Andrew Lunn
2017-11-10 0:02 ` Chris Healy
@ 2017-11-10 0:18 ` Fabio Estevam
2017-11-10 1:03 ` Andrew Lunn
2017-11-16 11:19 ` Shawn Guo
2 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2017-11-10 0:18 UTC (permalink / raw)
To: linux-arm-kernel
Hi Andrew,
On Thu, Nov 9, 2017 at 9:48 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> The two Ethernet switches have an AT24C512 each. This is a 64K device,
> not 512 bytes as currently listed in the device tree.
>
> Reported-by: Chris Healy <cphealy@gmail.com>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> index db3b408ea55a..0c557a9e7e17 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> @@ -73,7 +73,7 @@
> #size-cells = <0>;
> reg = <0>;
> dsa,member = <0 0>;
> - eeprom-length = <512>;
> + eeprom-length = <65536>;
vf610-zii-dev-rev-b.dts also uses 512.
Should it be also changed or is it correct for the rev-b?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size
2017-11-10 0:18 ` Fabio Estevam
@ 2017-11-10 1:03 ` Andrew Lunn
2017-11-10 1:09 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2017-11-10 1:03 UTC (permalink / raw)
To: linux-arm-kernel
Hi Fabio
> vf610-zii-dev-rev-b.dts also uses 512.
>
> Should it be also changed or is it correct for the rev-b?
Rev-B is correct. Rev-C has a newer generation of Ethernet switch,
which has a little microcontroller in it. That microcontroller gets
its code from the EEPROM. So a bigger EEPROM is required.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size
2017-11-10 1:03 ` Andrew Lunn
@ 2017-11-10 1:09 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2017-11-10 1:09 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 9, 2017 at 11:03 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> Hi Fabio
>
>> vf610-zii-dev-rev-b.dts also uses 512.
>>
>> Should it be also changed or is it correct for the rev-b?
>
> Rev-B is correct. Rev-C has a newer generation of Ethernet switch,
> which has a little microcontroller in it. That microcontroller gets
> its code from the EEPROM. So a bigger EEPROM is required.
Thanks for the clarification:
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size
2017-11-09 23:48 [PATCH] ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size Andrew Lunn
2017-11-10 0:02 ` Chris Healy
2017-11-10 0:18 ` Fabio Estevam
@ 2017-11-16 11:19 ` Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2017-11-16 11:19 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 10, 2017 at 12:48:56AM +0100, Andrew Lunn wrote:
> The two Ethernet switches have an AT24C512 each. This is a 64K device,
> not 512 bytes as currently listed in the device tree.
>
> Reported-by: Chris Healy <cphealy@gmail.com>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-16 11:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-09 23:48 [PATCH] ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size Andrew Lunn
2017-11-10 0:02 ` Chris Healy
2017-11-10 0:18 ` Fabio Estevam
2017-11-10 1:03 ` Andrew Lunn
2017-11-10 1:09 ` Fabio Estevam
2017-11-16 11:19 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.