Fwd: spin_unlock is missed in function (netpoll_send_skb_on_dev) in file (linux-3.12/net/core/netpoll.c)

* Fwd: spin_unlock is missed in function (netpoll_send_skb_on_dev) in file (linux-3.12/net/core/netpoll.c)
       [not found] <CAFZT-jLtQNZnsoWO8nzJ0i5qUE6J--wXhg+gUXvh4qdmxMG4=g@mail.gmail.com>
@ 2014-01-03 15:38 ` Ahmed Tamrawi
  2014-01-03 20:50   ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmed Tamrawi @ 2014-01-03 15:38 UTC (permalink / raw)
  To: netdev

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

Hi there!

Bug Report Filed: https://bugzilla.kernel.org/show_bug.cgi?id=68011
Linux Version [3.12]
Configuration: Default configuration for x86

In function (netpoll_send_skb_on_dev) in file (linux-3.12/net/core/netpoll.c):

The structure (txq->_xmit_lock) gets successfully locked at line (383)
by (__netif_tx_trylock(txq)) and unlocked by (__netif_tx_unlock(txq))
at line (398).

The problem occurs when the loop breaks at line (390) and the
structure (txq->_xmit_lock) still locked. In that case, the structure
(txq->_xmit_lock) never gets unlocked.

A possible solution is to call (__netif_tx_unlock(txq)) before the
break at line (390).

Attached is a highlighted source code for the function.

Thanks,
Ahmed

[-- Attachment #2: bug_netpoll_send_skb_on_dev.png --]
[-- Type: image/png, Size: 880311 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread