* [PATCH] Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")
@ 2018-03-12 9:46 ` ShuFanLee
0 siblings, 0 replies; 8+ messages in thread
From: ShuFan Lee @ 2018-03-12 9:46 UTC (permalink / raw)
To: heikki.krogerus, linux, greg
Cc: shufan_lee, cy_huang, jun.li, linux-kernel, linux-usb
From: ShuFan Lee <shufan_lee@richtek.com>
The parameter, dev_id, of tcpci_irq should be tcpci_chip.
Remove definition of TCPC_CC_STATUS_DRPRST in tcpci.h.
Signed-off-by: ShuFan Lee <shufan_lee@richtek.com>
Reviewed-by: Li Jun <jun.li@nxp.com>
Tested-by: Li Jun <jun.li@nxp.com>
---
drivers/staging/typec/tcpci.c | 4 ++--
drivers/staging/typec/tcpci.h | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index 804374056a1e..076d97eaff6f 100644
--- a/drivers/staging/typec/tcpci.c
+++ b/drivers/staging/typec/tcpci.c
@@ -451,9 +451,9 @@ irqreturn_t tcpci_irq(struct tcpci *tcpci)
static irqreturn_t _tcpci_irq(int irq, void *dev_id)
{
- struct tcpci *tcpci = dev_id;
+ struct tcpci_chip *chip = dev_id;
- return tcpci_irq(tcpci);
+ return tcpci_irq(chip->tcpci);
}
static const struct regmap_config tcpci_regmap_config = {
diff --git a/drivers/staging/typec/tcpci.h b/drivers/staging/typec/tcpci.h
index a2c1754ca222..34c865f0dcf6 100644
--- a/drivers/staging/typec/tcpci.h
+++ b/drivers/staging/typec/tcpci.h
@@ -59,7 +59,6 @@
#define TCPC_POWER_CTRL_VCONN_ENABLE BIT(0)
#define TCPC_CC_STATUS 0x1d
-#define TCPC_CC_STATUS_DRPRST BIT(5)
#define TCPC_CC_STATUS_TERM BIT(4)
#define TCPC_CC_STATUS_CC2_SHIFT 2
#define TCPC_CC_STATUS_CC2_MASK 0x3
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")
@ 2018-03-12 9:46 ` ShuFanLee
0 siblings, 0 replies; 8+ messages in thread
From: ShuFanLee @ 2018-03-12 9:46 UTC (permalink / raw)
To: heikki.krogerus, linux, greg
Cc: shufan_lee, cy_huang, jun.li, linux-kernel, linux-usb
From: ShuFan Lee <shufan_lee@richtek.com>
The parameter, dev_id, of tcpci_irq should be tcpci_chip.
Remove definition of TCPC_CC_STATUS_DRPRST in tcpci.h.
Signed-off-by: ShuFan Lee <shufan_lee@richtek.com>
Reviewed-by: Li Jun <jun.li@nxp.com>
Tested-by: Li Jun <jun.li@nxp.com>
---
drivers/staging/typec/tcpci.c | 4 ++--
drivers/staging/typec/tcpci.h | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index 804374056a1e..076d97eaff6f 100644
--- a/drivers/staging/typec/tcpci.c
+++ b/drivers/staging/typec/tcpci.c
@@ -451,9 +451,9 @@ irqreturn_t tcpci_irq(struct tcpci *tcpci)
static irqreturn_t _tcpci_irq(int irq, void *dev_id)
{
- struct tcpci *tcpci = dev_id;
+ struct tcpci_chip *chip = dev_id;
- return tcpci_irq(tcpci);
+ return tcpci_irq(chip->tcpci);
}
static const struct regmap_config tcpci_regmap_config = {
diff --git a/drivers/staging/typec/tcpci.h b/drivers/staging/typec/tcpci.h
index a2c1754ca222..34c865f0dcf6 100644
--- a/drivers/staging/typec/tcpci.h
+++ b/drivers/staging/typec/tcpci.h
@@ -59,7 +59,6 @@
#define TCPC_POWER_CTRL_VCONN_ENABLE BIT(0)
#define TCPC_CC_STATUS 0x1d
-#define TCPC_CC_STATUS_DRPRST BIT(5)
#define TCPC_CC_STATUS_TERM BIT(4)
#define TCPC_CC_STATUS_CC2_SHIFT 2
#define TCPC_CC_STATUS_CC2_MASK 0x3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")
@ 2018-03-12 11:07 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2018-03-12 11:07 UTC (permalink / raw)
To: ShuFan Lee
Cc: heikki.krogerus, linux, shufan_lee, cy_huang, jun.li,
linux-kernel, linux-usb
On Mon, Mar 12, 2018 at 05:46:42PM +0800, ShuFan Lee wrote:
> From: ShuFan Lee <shufan_lee@richtek.com>
Your subject is odd, that line should be below, in the signed-off-by:
area, not as the subject of the patch :(
Can you fix this up and resend?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")
@ 2018-03-12 11:07 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2018-03-12 11:07 UTC (permalink / raw)
To: ShuFan Lee
Cc: heikki.krogerus, linux, shufan_lee, cy_huang, jun.li,
linux-kernel, linux-usb
On Mon, Mar 12, 2018 at 05:46:42PM +0800, ShuFan Lee wrote:
> From: ShuFan Lee <shufan_lee@richtek.com>
Your subject is odd, that line should be below, in the signed-off-by:
area, not as the subject of the patch :(
Can you fix this up and resend?
thanks,
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")
@ 2018-03-12 11:26 ` ShuFanLee
0 siblings, 0 replies; 8+ messages in thread
From: 李書帆 @ 2018-03-12 11:26 UTC (permalink / raw)
To: Greg KH
Cc: heikki.krogerus, Guenter Roeck,
shufan_lee(李書帆),
cy_huang(黃啟原),
Jun Li, linux-kernel, linux-usb
Hi Greg,
2018-03-12 19:07 GMT+08:00 Greg KH <greg@kroah.com>:
> On Mon, Mar 12, 2018 at 05:46:42PM +0800, ShuFan Lee wrote:
>> From: ShuFan Lee <shufan_lee@richtek.com>
>
> Your subject is odd, that line should be below, in the signed-off-by:
> area, not as the subject of the patch :(
>
> Can you fix this up and resend?
Yes.
If I understand correctly, the title should be like
staging: typec: modify parameter of tcpci_irq
and the "Fixes" tag should be put in the signed-off-by area.
Should it be in the beginning of the area:
Fixes: 8f9439022648("staging: typec: handle vendor defined part and
modify drp toggling flow")
Signed-off-by: xxx
or the end of the area?
Signed-off-by: xxx
Fixes: 8f9439022648("staging: typec: handle vendor defined part and
modify drp toggling flow")
>
> thanks,
>
> greg k-h
--
Best Regards,
書帆
^ permalink raw reply [flat|nested] 8+ messages in thread
* Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")
@ 2018-03-12 11:26 ` ShuFanLee
0 siblings, 0 replies; 8+ messages in thread
From: ShuFanLee @ 2018-03-12 11:26 UTC (permalink / raw)
To: Greg KH
Cc: heikki.krogerus, Guenter Roeck,
shufan_lee(李書帆),
cy_huang(黃啟原),
Jun Li, linux-kernel, linux-usb
Hi Greg,
2018-03-12 19:07 GMT+08:00 Greg KH <greg@kroah.com>:
> On Mon, Mar 12, 2018 at 05:46:42PM +0800, ShuFan Lee wrote:
>> From: ShuFan Lee <shufan_lee@richtek.com>
>
> Your subject is odd, that line should be below, in the signed-off-by:
> area, not as the subject of the patch :(
>
> Can you fix this up and resend?
Yes.
If I understand correctly, the title should be like
staging: typec: modify parameter of tcpci_irq
and the "Fixes" tag should be put in the signed-off-by area.
Should it be in the beginning of the area:
Fixes: 8f9439022648("staging: typec: handle vendor defined part and
modify drp toggling flow")
Signed-off-by: xxx
or the end of the area?
Signed-off-by: xxx
Fixes: 8f9439022648("staging: typec: handle vendor defined part and
modify drp toggling flow")
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")
@ 2018-03-12 11:43 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2018-03-12 11:43 UTC (permalink / raw)
To: 李書帆
Cc: heikki.krogerus, Guenter Roeck,
shufan_lee(李書帆),
cy_huang(黃啟原),
Jun Li, linux-kernel, linux-usb
On Mon, Mar 12, 2018 at 07:26:07PM +0800, 李書帆 wrote:
> Hi Greg,
>
> 2018-03-12 19:07 GMT+08:00 Greg KH <greg@kroah.com>:
> > On Mon, Mar 12, 2018 at 05:46:42PM +0800, ShuFan Lee wrote:
> >> From: ShuFan Lee <shufan_lee@richtek.com>
> >
> > Your subject is odd, that line should be below, in the signed-off-by:
> > area, not as the subject of the patch :(
> >
> > Can you fix this up and resend?
> Yes.
> If I understand correctly, the title should be like
> staging: typec: modify parameter of tcpci_irq
> and the "Fixes" tag should be put in the signed-off-by area.
Correct.
> Should it be in the beginning of the area:
> Fixes: 8f9439022648("staging: typec: handle vendor defined part and
> modify drp toggling flow")
> Signed-off-by: xxx
>
> or the end of the area?
> Signed-off-by: xxx
> Fixes: 8f9439022648("staging: typec: handle vendor defined part and
> modify drp toggling flow")
Either is acceptable, but usually you see the first example here.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")
@ 2018-03-12 11:43 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2018-03-12 11:43 UTC (permalink / raw)
To: 李書帆
Cc: heikki.krogerus, Guenter Roeck,
shufan_lee(李書帆),
cy_huang(黃啟原),
Jun Li, linux-kernel, linux-usb
On Mon, Mar 12, 2018 at 07:26:07PM +0800, 李書帆 wrote:
> Hi Greg,
>
> 2018-03-12 19:07 GMT+08:00 Greg KH <greg@kroah.com>:
> > On Mon, Mar 12, 2018 at 05:46:42PM +0800, ShuFan Lee wrote:
> >> From: ShuFan Lee <shufan_lee@richtek.com>
> >
> > Your subject is odd, that line should be below, in the signed-off-by:
> > area, not as the subject of the patch :(
> >
> > Can you fix this up and resend?
> Yes.
> If I understand correctly, the title should be like
> staging: typec: modify parameter of tcpci_irq
> and the "Fixes" tag should be put in the signed-off-by area.
Correct.
> Should it be in the beginning of the area:
> Fixes: 8f9439022648("staging: typec: handle vendor defined part and
> modify drp toggling flow")
> Signed-off-by: xxx
>
> or the end of the area?
> Signed-off-by: xxx
> Fixes: 8f9439022648("staging: typec: handle vendor defined part and
> modify drp toggling flow")
Either is acceptable, but usually you see the first example here.
thanks,
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-03-12 11:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-12 9:46 [PATCH] Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq") ShuFan Lee
2018-03-12 9:46 ` ShuFanLee
2018-03-12 11:07 ` [PATCH] " Greg KH
2018-03-12 11:07 ` Greg KH
2018-03-12 11:26 ` [PATCH] " 李書帆
2018-03-12 11:26 ` ShuFanLee
2018-03-12 11:43 ` [PATCH] " Greg KH
2018-03-12 11:43 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.