From: Brendan Higgins <brendanhiggins@google.com> To: Ignat Korchagin <ignat@cloudflare.com> Cc: Jeff Dike <jdike@addtoit.com>, Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, linux-um <linux-um@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, kernel-team@cloudflare.com Subject: Re: [PATCH v2 3/3] um: allow static linking for non-glibc implementations Date: Wed, 15 Jul 2020 01:44:17 -0700 [thread overview] Message-ID: <CAFd5g44Hxhxjqb6WkfaMtaTDKVhs0onnkRaQ0Aq55z6oYTbJbA@mail.gmail.com> (raw) In-Reply-To: <20200704085213.444645-4-ignat@cloudflare.com> On Sat, Jul 4, 2020 at 1:52 AM Ignat Korchagin <ignat@cloudflare.com> wrote: > > It is possible to produce a statically linked UML binary with UML_NET_VECTOR, > UML_NET_VDE and UML_NET_PCAP options enabled using alternative libc > implementations, which do not rely on NSS, such as musl. > > Allow static linking in this case. > > Signed-off-by: Ignat Korchagin <ignat@cloudflare.com> One minor issue below. Other than that: Reviewed-by: Brendan Higgins <brendanhiggins@google.com> > --- > arch/um/Kconfig | 2 +- > arch/um/drivers/Kconfig | 3 --- > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/um/Kconfig b/arch/um/Kconfig > index 9318dc6d1a0c..af7ed63f9c74 100644 > --- a/arch/um/Kconfig > +++ b/arch/um/Kconfig > @@ -67,7 +67,7 @@ config FORBID_STATIC_LINK Doesn't look like FORBID_STATIC_LINK is used anymore, so you should probably drop it as well. With the preceding changes, in this patchset, you can revert my patch like you did in the RFC - or not, your choice. I am not offended by people reverting my commits. I just don't like it when people break allyesconfig. :-) > config STATIC_LINK > bool "Force a static link" > - depends on !FORBID_STATIC_LINK > + depends on CC_CAN_LINK_STATIC_NO_RUNTIME_DEPS || (!UML_NET_VECTOR && !UML_NET_VDE && !UML_NET_PCAP) > help > This option gives you the ability to force a static link of UML. > Normally, UML is linked as a shared binary. This is inconvenient for > diff --git a/arch/um/drivers/Kconfig b/arch/um/drivers/Kconfig > index 9160ead56e33..72d417055782 100644 > --- a/arch/um/drivers/Kconfig > +++ b/arch/um/drivers/Kconfig > @@ -234,7 +234,6 @@ config UML_NET_DAEMON > config UML_NET_VECTOR > bool "Vector I/O high performance network devices" > depends on UML_NET > - select FORBID_STATIC_LINK > help > This User-Mode Linux network driver uses multi-message send > and receive functions. The host running the UML guest must have > @@ -246,7 +245,6 @@ config UML_NET_VECTOR > config UML_NET_VDE > bool "VDE transport (obsolete)" > depends on UML_NET > - select FORBID_STATIC_LINK > help > This User-Mode Linux network transport allows one or more running > UMLs on a single host to communicate with each other and also > @@ -294,7 +292,6 @@ config UML_NET_MCAST > config UML_NET_PCAP > bool "pcap transport (obsolete)" > depends on UML_NET > - select FORBID_STATIC_LINK > help > The pcap transport makes a pcap packet stream on the host look > like an ethernet device inside UML. This is useful for making > -- > 2.20.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Brendan Higgins <brendanhiggins@google.com> To: Ignat Korchagin <ignat@cloudflare.com> Cc: kernel-team@cloudflare.com, Richard Weinberger <richard@nod.at>, Jeff Dike <jdike@addtoit.com>, linux-um <linux-um@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Anton Ivanov <anton.ivanov@cambridgegreys.com> Subject: Re: [PATCH v2 3/3] um: allow static linking for non-glibc implementations Date: Wed, 15 Jul 2020 01:44:17 -0700 [thread overview] Message-ID: <CAFd5g44Hxhxjqb6WkfaMtaTDKVhs0onnkRaQ0Aq55z6oYTbJbA@mail.gmail.com> (raw) In-Reply-To: <20200704085213.444645-4-ignat@cloudflare.com> On Sat, Jul 4, 2020 at 1:52 AM Ignat Korchagin <ignat@cloudflare.com> wrote: > > It is possible to produce a statically linked UML binary with UML_NET_VECTOR, > UML_NET_VDE and UML_NET_PCAP options enabled using alternative libc > implementations, which do not rely on NSS, such as musl. > > Allow static linking in this case. > > Signed-off-by: Ignat Korchagin <ignat@cloudflare.com> One minor issue below. Other than that: Reviewed-by: Brendan Higgins <brendanhiggins@google.com> > --- > arch/um/Kconfig | 2 +- > arch/um/drivers/Kconfig | 3 --- > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/um/Kconfig b/arch/um/Kconfig > index 9318dc6d1a0c..af7ed63f9c74 100644 > --- a/arch/um/Kconfig > +++ b/arch/um/Kconfig > @@ -67,7 +67,7 @@ config FORBID_STATIC_LINK Doesn't look like FORBID_STATIC_LINK is used anymore, so you should probably drop it as well. With the preceding changes, in this patchset, you can revert my patch like you did in the RFC - or not, your choice. I am not offended by people reverting my commits. I just don't like it when people break allyesconfig. :-) > config STATIC_LINK > bool "Force a static link" > - depends on !FORBID_STATIC_LINK > + depends on CC_CAN_LINK_STATIC_NO_RUNTIME_DEPS || (!UML_NET_VECTOR && !UML_NET_VDE && !UML_NET_PCAP) > help > This option gives you the ability to force a static link of UML. > Normally, UML is linked as a shared binary. This is inconvenient for > diff --git a/arch/um/drivers/Kconfig b/arch/um/drivers/Kconfig > index 9160ead56e33..72d417055782 100644 > --- a/arch/um/drivers/Kconfig > +++ b/arch/um/drivers/Kconfig > @@ -234,7 +234,6 @@ config UML_NET_DAEMON > config UML_NET_VECTOR > bool "Vector I/O high performance network devices" > depends on UML_NET > - select FORBID_STATIC_LINK > help > This User-Mode Linux network driver uses multi-message send > and receive functions. The host running the UML guest must have > @@ -246,7 +245,6 @@ config UML_NET_VECTOR > config UML_NET_VDE > bool "VDE transport (obsolete)" > depends on UML_NET > - select FORBID_STATIC_LINK > help > This User-Mode Linux network transport allows one or more running > UMLs on a single host to communicate with each other and also > @@ -294,7 +292,6 @@ config UML_NET_MCAST > config UML_NET_PCAP > bool "pcap transport (obsolete)" > depends on UML_NET > - select FORBID_STATIC_LINK > help > The pcap transport makes a pcap packet stream on the host look > like an ethernet device inside UML. This is useful for making > -- > 2.20.1 > _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2020-07-15 8:44 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-04 8:52 [PATCH v2 0/3] um: allow static linking for non-glibc libc implementations Ignat Korchagin 2020-07-04 8:52 ` Ignat Korchagin 2020-07-04 8:52 ` [PATCH v2 1/3] um/kconfig: introduce CC_CAN_LINK_STATIC_NO_RUNTIME_DEPS Ignat Korchagin 2020-07-04 8:52 ` Ignat Korchagin 2020-07-15 8:38 ` Brendan Higgins 2020-07-15 8:38 ` Brendan Higgins 2020-07-04 8:52 ` [PATCH v2 2/3] um: some fixes to build UML with musl Ignat Korchagin 2020-07-04 8:52 ` Ignat Korchagin 2020-07-14 8:40 ` Anton Ivanov 2020-07-14 8:40 ` Anton Ivanov 2020-07-14 10:23 ` Ignat Korchagin 2020-07-14 10:23 ` Ignat Korchagin 2020-07-14 10:43 ` Anton Ivanov 2020-07-14 10:43 ` Anton Ivanov 2020-07-14 16:02 ` Johannes Berg 2020-07-14 16:02 ` Johannes Berg 2020-07-15 8:47 ` Brendan Higgins 2020-07-15 8:47 ` Brendan Higgins 2020-07-04 8:52 ` [PATCH v2 3/3] um: allow static linking for non-glibc implementations Ignat Korchagin 2020-07-04 8:52 ` Ignat Korchagin 2020-07-15 8:44 ` Brendan Higgins [this message] 2020-07-15 8:44 ` Brendan Higgins 2020-07-15 9:30 ` Ignat Korchagin 2020-07-15 9:30 ` Ignat Korchagin 2020-07-15 8:36 ` [PATCH v2 0/3] um: allow static linking for non-glibc libc implementations Brendan Higgins 2020-07-15 8:36 ` Brendan Higgins
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAFd5g44Hxhxjqb6WkfaMtaTDKVhs0onnkRaQ0Aq55z6oYTbJbA@mail.gmail.com \ --to=brendanhiggins@google.com \ --cc=anton.ivanov@cambridgegreys.com \ --cc=ignat@cloudflare.com \ --cc=jdike@addtoit.com \ --cc=kernel-team@cloudflare.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-um@lists.infradead.org \ --cc=richard@nod.at \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.