From: Brendan Higgins <brendanhiggins@google.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
KUnit Development <kunit-dev@googlegroups.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Alan Maguire <alan.maguire@oracle.com>
Subject: Re: linux-next: Tree for Jan 13 (drivers/base/test/property-entry-test.o)
Date: Mon, 13 Jan 2020 17:10:03 -0800 [thread overview]
Message-ID: <CAFd5g454Xgb-tnG-rBQ3fkCe2bsO7M8_dauOTpG3bxDjnxOX9A@mail.gmail.com> (raw)
In-Reply-To: <20200114104049.5244f612@canb.auug.org.au>
+KUnit Development
+open list:KERNEL SELFTEST FRAMEWORK
On Mon, Jan 13, 2020 at 3:40 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Randy,
>
> On Mon, 13 Jan 2020 14:59:54 -0800 Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > on i386:
> >
> > WARNING: modpost: missing MODULE_LICENSE() in drivers/base/test/property-entry-test.o
> > see include/linux/module.h for more information
>
> Sorry, I missed that yesterday.
>
> Caused by commit
>
> c032ace71c29 ("software node: add basic tests for property entries")
>
> from the pm tree interacting with commit
>
> 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module")
>
> from the kunit-next tree.
Yes, the problem seems to be that the property-entry-test is turned on
when CONFIG_KUNIT is y or m.
From drivers/base/test/Makefile:
...
obj-$(CONFIG_KUNIT) += property-entry-test.o
It seems we can fix it just by adding the missing MODULE_LICENSE, but
I think there is a bigger question of whether we should let people do
this. Do we want to just let people have their tests run whenever
CONFIG_KUNIT is enabled? I am inclined to think no. It should be
possible for people to run their test and their test only.
next prev parent reply other threads:[~2020-01-14 1:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 7:14 linux-next: Tree for Jan 13 Stephen Rothwell
2020-01-13 18:27 ` BUG_ON hit in "reimplement path_mountpoint() with less magic" [Was: Re: linux-next: Tree for Jan 13] Jason A. Donenfeld
2020-01-13 19:23 ` Al Viro
2020-01-13 19:33 ` Jason A. Donenfeld
2020-01-13 22:59 ` linux-next: Tree for Jan 13 (drivers/base/test/property-entry-test.o) Randy Dunlap
2020-01-13 23:40 ` Stephen Rothwell
2020-01-14 1:10 ` Brendan Higgins [this message]
2020-01-14 16:14 ` Alan Maguire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFd5g454Xgb-tnG-rBQ3fkCe2bsO7M8_dauOTpG3bxDjnxOX9A@mail.gmail.com \
--to=brendanhiggins@google.com \
--cc=alan.maguire@oracle.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=sfr@canb.auug.org.au \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.