All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: BUG_ON hit in "reimplement path_mountpoint() with less magic" [Was: Re: linux-next: Tree for Jan 13]
Date: Mon, 13 Jan 2020 14:33:31 -0500	[thread overview]
Message-ID: <CAHmME9rBb5Otr-96W38kNjXkfok9NwFJ6V263qoPTJHqNEsgoA@mail.gmail.com> (raw)
In-Reply-To: <20200113192315.GS8904@ZenIV.linux.org.uk>

Hey Al,

On Mon, Jan 13, 2020 at 2:23 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> On Mon, Jan 13, 2020 at 01:27:34PM -0500, Jason A. Donenfeld wrote:
> > Hi Al,
> >
> > Your "reimplement path_mountpoint() with less magic" commit is causing
> > oopses on the linux-next tests running on https://build.wireguard.com/ .
> > Here's one such crash with debug symbols:
>
> Check if that persists with the version currently in #fixes (commit
> 7a955b7363b8).  It ought to be fixed there; quick check is to look
> at fs/namei.c:path_mountpoint() in your tree - it should read
>         if (!err && (nd->flags & LOOKUP_RCU))
>                 err = unlazy_walk(nd);
> not
>         if (!err)
>                 err = unlazy_walk(nd);
> as in the broken variant.

That does the trick. Glad that's sorted. Thanks.

Jason

  reply	other threads:[~2020-01-13 19:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13  7:14 linux-next: Tree for Jan 13 Stephen Rothwell
2020-01-13 18:27 ` BUG_ON hit in "reimplement path_mountpoint() with less magic" [Was: Re: linux-next: Tree for Jan 13] Jason A. Donenfeld
2020-01-13 19:23   ` Al Viro
2020-01-13 19:33     ` Jason A. Donenfeld [this message]
2020-01-13 22:59 ` linux-next: Tree for Jan 13 (drivers/base/test/property-entry-test.o) Randy Dunlap
2020-01-13 23:40   ` Stephen Rothwell
2020-01-14  1:10     ` Brendan Higgins
2020-01-14 16:14       ` Alan Maguire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9rBb5Otr-96W38kNjXkfok9NwFJ6V263qoPTJHqNEsgoA@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.