* [PATCH] libsemanage: Improve warning for installing disabled module
@ 2018-02-28 12:12 Vit Mojzis
2018-02-28 17:44 ` William Roberts
0 siblings, 1 reply; 3+ messages in thread
From: Vit Mojzis @ 2018-02-28 12:12 UTC (permalink / raw)
To: selinux
Resolves: rhbz#1337199
Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
---
libsemanage/src/direct_api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libsemanage/src/direct_api.c b/libsemanage/src/direct_api.c
index 88873c43..9c305c75 100644
--- a/libsemanage/src/direct_api.c
+++ b/libsemanage/src/direct_api.c
@@ -2797,7 +2797,7 @@ static int semanage_direct_install_info(semanage_handle_t *sh,
if (higher_info->enabled == 0 && modinfo->enabled == -1) {
errno = 0;
WARN(sh,
- "%s module will be disabled after install due to default enabled status.",
+ "%s module will be disabled after install as there is a disabled instance of this module present in the system.",
modinfo->name);
}
}
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libsemanage: Improve warning for installing disabled module
2018-02-28 12:12 [PATCH] libsemanage: Improve warning for installing disabled module Vit Mojzis
@ 2018-02-28 17:44 ` William Roberts
2018-02-28 19:37 ` William Roberts
0 siblings, 1 reply; 3+ messages in thread
From: William Roberts @ 2018-02-28 17:44 UTC (permalink / raw)
To: Vit Mojzis; +Cc: selinux
On Wed, Feb 28, 2018 at 4:12 AM, Vit Mojzis <vmojzis@redhat.com> wrote:
> Resolves: rhbz#1337199
>
> Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
> ---
> libsemanage/src/direct_api.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libsemanage/src/direct_api.c b/libsemanage/src/direct_api.c
> index 88873c43..9c305c75 100644
> --- a/libsemanage/src/direct_api.c
> +++ b/libsemanage/src/direct_api.c
> @@ -2797,7 +2797,7 @@ static int semanage_direct_install_info(semanage_handle_t *sh,
> if (higher_info->enabled == 0 && modinfo->enabled == -1) {
> errno = 0;
> WARN(sh,
> - "%s module will be disabled after install due to default enabled status.",
> + "%s module will be disabled after install as there is a disabled instance of this module present in the system.",
> modinfo->name);
> }
> }
> --
> 2.14.3
>
>
ack
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libsemanage: Improve warning for installing disabled module
2018-02-28 17:44 ` William Roberts
@ 2018-02-28 19:37 ` William Roberts
0 siblings, 0 replies; 3+ messages in thread
From: William Roberts @ 2018-02-28 19:37 UTC (permalink / raw)
To: Vit Mojzis; +Cc: selinux
On Wed, Feb 28, 2018 at 9:44 AM, William Roberts
<bill.c.roberts@gmail.com> wrote:
> On Wed, Feb 28, 2018 at 4:12 AM, Vit Mojzis <vmojzis@redhat.com> wrote:
>> Resolves: rhbz#1337199
>>
>> Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
>> ---
>> libsemanage/src/direct_api.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libsemanage/src/direct_api.c b/libsemanage/src/direct_api.c
>> index 88873c43..9c305c75 100644
>> --- a/libsemanage/src/direct_api.c
>> +++ b/libsemanage/src/direct_api.c
>> @@ -2797,7 +2797,7 @@ static int semanage_direct_install_info(semanage_handle_t *sh,
>> if (higher_info->enabled == 0 && modinfo->enabled == -1) {
>> errno = 0;
>> WARN(sh,
>> - "%s module will be disabled after install due to default enabled status.",
>> + "%s module will be disabled after install as there is a disabled instance of this module present in the system.",
>> modinfo->name);
>> }
>> }
>> --
>> 2.14.3
>>
>>
>
> ack
merged: https://github.com/SELinuxProject/selinux/pull/82
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-28 19:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-28 12:12 [PATCH] libsemanage: Improve warning for installing disabled module Vit Mojzis
2018-02-28 17:44 ` William Roberts
2018-02-28 19:37 ` William Roberts
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.