Re: [PATCH] README: add pkg kernel-devel to dnf command

[William Roberts <bill.c.roberts@gmail.com>]

On Fri, May 15, 2020 at 4:06 PM Ondrej Mosnacek <omosnace@redhat.com> wrote:
>
> On Fri, May 15, 2020 at 10:46 PM William Roberts
> <bill.c.roberts@gmail.com> wrote:
> > On Fri, May 15, 2020 at 2:41 PM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> > >
> > > On Fri, May 15, 2020 at 9:27 PM William Roberts
> > > <bill.c.roberts@gmail.com> wrote:
> > > > On Fri, May 15, 2020 at 1:51 PM Stephen Smalley
> > > > <stephen.smalley.work@gmail.com> wrote:
> > > > >
> > > > > On Fri, May 15, 2020 at 2:11 PM William Roberts
> > > > > <bill.c.roberts@gmail.com> wrote:
> > > > > >
> > > > > > On Fri, May 15, 2020 at 12:59 PM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> > > > > > >
> > > > > > > On Fri, May 15, 2020 at 7:31 PM <william.c.roberts@intel.com> wrote:
> > > > > > > > From: William Roberts <william.c.roberts@intel.com>
> > > > > > > >
> > > > > > > > The text above states that kernel-devel is needed, but it's missing from
> > > > > > > > the dnf command.
> > > > > > > >
> > > > > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com>
> > > > > > > > ---
> > > > > > > >  README.md | 3 ++-
> > > > > > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > > > > > >
> > > > > > > > diff --git a/README.md b/README.md
> > > > > > > > index 1f7e5d92a100..a73e9cc0c06d 100644
> > > > > > > > --- a/README.md
> > > > > > > > +++ b/README.md
> > > > > > > > @@ -77,7 +77,8 @@ following command:
> > > > > > > >                 kernel-devel \
> > > > > > >
> > > > > > > It's actually right there already ^^
> > > > > >
> > > > > > Yeah that's the foot cannon, I thought I was good, but you need the
> > > > > > specific ones
> > > > > > as Ondrej pointed out to me.
> > > > > >
> > > > > > >
> > > > > > > >                 quota \
> > > > > > > >                 xfsprogs-devel \
> > > > > > > > -               libuuid-devel
> > > > > > > > +               libuuid-devel \
> > > > > > > > +               kernel-devel-$(uname -r)
> > > > > > >
> > > > > > > I proposed adding the -$(uname -r) before, but there were some valid
> > > > > > > counterarguments. See the discussion here:
> > > > > > > https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/
> > > > > > >
> > > > > >
> > > > > > Arguments for why the dnf command should have it with uname:
> > > > > > 1. We tried to add it twice, it's bit people twice.
> > > > > > 2. The README states "On a modern Fedora system you can install these
> > > > > > dependencies with the following command:"
> > > > > >     - which is wrong, you need the specific package
> > > > > >     - If you're going to provide a "dnf install" or a apt-get install,
> > > > > > it should just work
> > > > > >     - the apt-get example has uname -r in it.
> > > > > >     - so the precludes building your own kernel, if you do that as
> > > > > > Paul stated, you're on your own. (lore comment)
> > > > >
> > > > > I'm ok with adding it.
> > > >
> > > > Does anyone want to ack this one?
> > >
> > > As Stephen already said while I was writing this message, please just
> > > update the existing kernel-devel line.
> > >
> > > >
> > > > Ok I found another one, kernel-modules-extra is needed for the sctp module.
> > >
> > > On Fedora it shouldn't be, only on RHEL/CentOS 8.
> >
> > Not on the cloud image, so I am assuming that desktop just has it already
> > fulfilled.
>
> That's strange... Was this with the 5.6.6-300.fc32.x86_64 kernel
> mentioned in the other thread? I just downloaded the RPMs for that
> build and sctp.ko was in kernel-modules, not kernel-modules-extra.

I say it was in kernel-modules-extra-$(uname -r), but what I should have said,
that solved the issue od not having the sctp module, but it solved it buy
being dependent on kernel-modules, so the correct line to add would be
that one, not extra.

I don't do really use fedora distros, so bear me with as I learn where
to find info
and poke the system.

>
> --
> Ondrej Mosnacek <omosnace at redhat dot com>
> Software Engineer, Security Technologies
> Red Hat, Inc.
>